* [PATCH] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev
@ 2020-05-26 22:56 Colin King
2020-05-26 23:29 ` Ido Schimmel
2020-05-27 1:15 ` David Ahern
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2020-05-26 22:56 UTC (permalink / raw)
To: Jiri Pirko, Ido Schimmel, David S . Miller, Jakub Kicinski, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer br_dev is being initialized with a value that is never read
and is being updated with a new value later on. The initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index 71aee4914619..8f485f9a07a7 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -7572,11 +7572,12 @@ static struct mlxsw_sp_fid *
mlxsw_sp_rif_vlan_fid_get(struct mlxsw_sp_rif *rif,
struct netlink_ext_ack *extack)
{
- struct net_device *br_dev = rif->dev;
+ struct net_device *br_dev;
u16 vid;
int err;
if (is_vlan_dev(rif->dev)) {
+
vid = vlan_dev_vlan_id(rif->dev);
br_dev = vlan_dev_real_dev(rif->dev);
if (WARN_ON(!netif_is_bridge_master(br_dev)))
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev
2020-05-26 22:56 [PATCH] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev Colin King
@ 2020-05-26 23:29 ` Ido Schimmel
2020-05-27 1:15 ` David Ahern
1 sibling, 0 replies; 3+ messages in thread
From: Ido Schimmel @ 2020-05-26 23:29 UTC (permalink / raw)
To: Colin King
Cc: Jiri Pirko, Ido Schimmel, David S . Miller, Jakub Kicinski,
netdev, kernel-janitors, linux-kernel
On Tue, May 26, 2020 at 11:56:49PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
> index 71aee4914619..8f485f9a07a7 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
> @@ -7572,11 +7572,12 @@ static struct mlxsw_sp_fid *
> mlxsw_sp_rif_vlan_fid_get(struct mlxsw_sp_rif *rif,
> struct netlink_ext_ack *extack)
> {
> - struct net_device *br_dev = rif->dev;
> + struct net_device *br_dev;
> u16 vid;
> int err;
>
> if (is_vlan_dev(rif->dev)) {
> +
Colin, please drop the extra blank line and mention in subject prefix
that the patch is for net-next. Thanks!
> vid = vlan_dev_vlan_id(rif->dev);
> br_dev = vlan_dev_real_dev(rif->dev);
> if (WARN_ON(!netif_is_bridge_master(br_dev)))
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev
2020-05-26 22:56 [PATCH] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev Colin King
2020-05-26 23:29 ` Ido Schimmel
@ 2020-05-27 1:15 ` David Ahern
1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2020-05-27 1:15 UTC (permalink / raw)
To: Colin King, Jiri Pirko, Ido Schimmel, David S . Miller,
Jakub Kicinski, netdev
Cc: kernel-janitors, linux-kernel
On 5/26/20 4:56 PM, Colin King wrote:
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
> index 71aee4914619..8f485f9a07a7 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
> @@ -7572,11 +7572,12 @@ static struct mlxsw_sp_fid *
> mlxsw_sp_rif_vlan_fid_get(struct mlxsw_sp_rif *rif,
> struct netlink_ext_ack *extack)
> {
> - struct net_device *br_dev = rif->dev;
> + struct net_device *br_dev;
> u16 vid;
> int err;
>
> if (is_vlan_dev(rif->dev)) {
> +
stray newline added
> vid = vlan_dev_vlan_id(rif->dev);
> br_dev = vlan_dev_real_dev(rif->dev);
> if (WARN_ON(!netif_is_bridge_master(br_dev)))
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-27 1:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-26 22:56 [PATCH] mlxsw: spectrum_router: remove redundant initialization of pointer br_dev Colin King
2020-05-26 23:29 ` Ido Schimmel
2020-05-27 1:15 ` David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).