From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: <laurent.pinchart@ideasonboard.com>,
<kieran.bingham+renesas@ideasonboard.com>, <geert@linux-m68k.org>,
<horms@verge.net.au>, <uli+renesas@fpond.eu>,
<VenkataRajesh.Kalakodima@in.bosch.com>, <airlied@linux.ie>,
<daniel@ffwll.ch>, <koji.matsuoka.xm@renesas.com>,
<muroya@ksk.co.jp>, <Harsha.ManjulaMallikarjun@in.bosch.com>,
<ezequiel@collabora.com>, <seanpaul@chromium.org>,
<linux-renesas-soc@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<michael.dege@renesas.com>, <gotthard.voellmeke@renesas.com>,
<efriedrich@de.adit-jv.com>, <mrodin@de.adit-jv.com>,
<ChaitanyaKumar.Borah@in.bosch.com>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Eugeniu Rosca <roscaeugeniu@gmail.com>
Subject: Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)
Date: Wed, 27 May 2020 09:15:55 +0200 [thread overview]
Message-ID: <20200527071555.GA23912@lxhi-065.adit-jv.com> (raw)
In-Reply-To: <20191015104621.62514-1-jacopo+renesas@jmondi.org>
Hi Jacopo,
On Tue, Oct 15, 2019 at 12:46:13PM +0200, Jacopo Mondi wrote:
----8<---
> * Testing
> I have tested by injecting a color inversion LUT table and enabling/disabling it
> every 50 displayed frames:
> https://jmondi.org/cgit/kmsxx/log/?h=gamma_lut
Could you kindly share the cross compilation steps for your kmsxx fork?
Just out of curiosity, have you ever tried to pull the display's HDMI
cable while reading from CM2_LUT_TBL?
At least with the out-of-tree CMM implementation [*], this sends the
R-Car3 reference targets into an unrecoverable freeze, with no lockup
reported by the kernel (i.e. looks like an serious HW issue).
>
> CMM functionalities are retained between suspend/resume cycles (tested with
> suspend-to-idle) without requiring a re-programming of the LUT tables.
Hmm. Is this backed up by any statement in the HW User's manual?
This comes in contrast with the original Renesas CMM implementation [**]
which does make use of suspend (where the freeze actually happens).
Can we infer, based on your statement, that we could also get rid of
the suspend callback in [**]?
[*] https://github.com/renesas-rcar/du_cmm
[**] https://github.com/renesas-rcar/du_cmm/blob/c393ed49834bdbc/meta-rcar-gen3/recipes-kernel/linux/linux-renesas/0001-drm-rcar-du-Add-DU-CMM-support.patch#L1912
--
Best regards,
Eugeniu Rosca
next prev parent reply other threads:[~2020-05-27 7:16 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 10:46 [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM) Jacopo Mondi
2019-10-15 10:46 ` [PATCH v5 1/8] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Jacopo Mondi
2019-10-15 11:38 ` Kieran Bingham
2019-10-15 14:03 ` Geert Uytterhoeven
2019-10-15 10:46 ` [PATCH v5 2/8] dt-bindings: display, renesas,du: Document cmms property Jacopo Mondi
2019-10-15 10:46 ` [PATCH v5 3/8] drm: rcar-du: Add support for CMM Jacopo Mondi
2019-10-15 11:53 ` Kieran Bingham
2019-10-15 13:17 ` Kieran Bingham
2019-10-15 13:33 ` Jacopo Mondi
2019-10-15 14:26 ` Kieran Bingham
2019-10-15 17:25 ` Laurent Pinchart
2019-10-15 10:46 ` [PATCH v5 4/8] drm: rcar-du: kms: Initialize CMM instances Jacopo Mondi
2019-10-15 10:46 ` [PATCH v5 5/8] drm: rcar-du: crtc: Control CMM operations Jacopo Mondi
2019-10-15 13:15 ` Kieran Bingham
2019-10-15 13:37 ` Jacopo Mondi
2019-10-15 17:54 ` Laurent Pinchart
2019-10-15 19:17 ` Jacopo Mondi
2019-10-15 19:53 ` Laurent Pinchart
2019-10-15 10:46 ` [PATCH v5 6/8] drm: rcar-du: crtc: Register GAMMA_LUT properties Jacopo Mondi
2019-10-15 10:46 ` [PATCH v5 7/8] arm64: dts: renesas: Add CMM units to Gen3 SoCs Jacopo Mondi
2019-10-15 12:52 ` Kieran Bingham
2019-10-15 18:06 ` Laurent Pinchart
2019-10-15 10:46 ` [PATCH v5 8/8] drm: rcar-du: kms: Expand comment in vsps parsing routine Jacopo Mondi
2019-10-15 13:04 ` Kieran Bingham
2019-10-15 16:54 ` [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM) Laurent Pinchart
2019-11-11 11:21 ` Kalakodima Venkata Rajesh (RBEI/ECF3)
2019-11-11 13:06 ` Jacopo Mondi
2020-05-27 7:15 ` Eugeniu Rosca [this message]
2020-05-27 7:34 ` Geert Uytterhoeven
2020-05-27 7:40 ` Gotthard Voellmeke
2020-05-27 7:44 ` Eugeniu Rosca
2020-06-05 13:29 ` Jacopo Mondi
2020-06-05 13:41 ` Eugeniu Rosca
2020-06-05 13:53 ` Jacopo Mondi
2020-06-07 2:41 ` Laurent Pinchart
2020-06-08 9:44 ` Eugeniu Rosca
2020-06-12 15:12 ` Jacopo Mondi
2020-06-15 14:17 ` Eugeniu Rosca
2020-07-17 15:06 ` Jacopo Mondi
2020-06-09 14:29 ` Eugeniu Rosca
2020-06-12 15:00 ` Jacopo Mondi
2020-06-12 15:10 ` Laurent Pinchart
2020-06-12 15:36 ` Eugeniu Rosca
2020-06-12 15:50 ` Laurent Pinchart
2020-08-18 9:50 ` Geert Uytterhoeven
2020-06-05 19:05 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527071555.GA23912@lxhi-065.adit-jv.com \
--to=erosca@de.adit-jv.com \
--cc=ChaitanyaKumar.Borah@in.bosch.com \
--cc=Harsha.ManjulaMallikarjun@in.bosch.com \
--cc=VenkataRajesh.Kalakodima@in.bosch.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=efriedrich@de.adit-jv.com \
--cc=ezequiel@collabora.com \
--cc=geert@linux-m68k.org \
--cc=gotthard.voellmeke@renesas.com \
--cc=horms@verge.net.au \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=koji.matsuoka.xm@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=michael.dege@renesas.com \
--cc=mrodin@de.adit-jv.com \
--cc=muroya@ksk.co.jp \
--cc=roscaeugeniu@gmail.com \
--cc=seanpaul@chromium.org \
--cc=uli+renesas@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).