From: David Miller <davem@redhat.com>
To: arnd@arndb.de
Cc: linux-net-drivers@solarflare.com, ecree@solarflare.com,
mhabets@solarflare.com, kuba@kernel.org, amaftei@solarflare.com,
tzhao@solarflare.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net-next] sfc: avoid an unused-variable warning
Date: Thu, 28 May 2020 12:49:46 -0700 (PDT) [thread overview]
Message-ID: <20200528.124946.275321353658990898.davem@redhat.com> (raw)
In-Reply-To: <20200527134113.827128-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 27 May 2020 15:41:06 +0200
> 'nic_data' is no longer used outside of the #ifdef block
> in efx_ef10_set_mac_address:
>
> drivers/net/ethernet/sfc/ef10.c:3231:28: error: unused variable 'nic_data' [-Werror,-Wunused-variable]
> struct efx_ef10_nic_data *nic_data = efx->nic_data;
>
> Move the variable into a local scope.
>
> Fixes: dfcabb078847 ("sfc: move vport_id to struct efx_nic")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applid, thanks.
next prev parent reply other threads:[~2020-05-28 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 13:41 [PATCH] [net-next] sfc: avoid an unused-variable warning Arnd Bergmann
2020-05-28 19:49 ` David Miller [this message]
2020-05-29 0:30 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528.124946.275321353658990898.davem@redhat.com \
--to=davem@redhat.com \
--cc=amaftei@solarflare.com \
--cc=arnd@arndb.de \
--cc=ecree@solarflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=mhabets@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=tzhao@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).