From: Edward Cree <ecree@solarflare.com>
To: David Miller <davem@redhat.com>, <arnd@arndb.de>
Cc: <linux-net-drivers@solarflare.com>, <mhabets@solarflare.com>,
<kuba@kernel.org>, <amaftei@solarflare.com>,
<tzhao@solarflare.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [net-next] sfc: avoid an unused-variable warning
Date: Fri, 29 May 2020 01:30:03 +0100 [thread overview]
Message-ID: <8e7598b2-3301-1af4-8c2f-b40cdc5166a3@solarflare.com> (raw)
In-Reply-To: <20200528.124946.275321353658990898.davem@redhat.com>
On 28/05/2020 20:49, David Miller wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Wed, 27 May 2020 15:41:06 +0200
>
>> 'nic_data' is no longer used outside of the #ifdef block
>> in efx_ef10_set_mac_address:
>>
>> drivers/net/ethernet/sfc/ef10.c:3231:28: error: unused variable 'nic_data' [-Werror,-Wunused-variable]
>> struct efx_ef10_nic_data *nic_data = efx->nic_data;
>>
>> Move the variable into a local scope.
>>
>> Fixes: dfcabb078847 ("sfc: move vport_id to struct efx_nic")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Applid, thanks.
Sorry I didn't see the original patch (I think it disappeared
into a mail outage). Fix is good, but I think we can improve
the code further by moving the declaration down another block,
into the 'if (rc == -EPERM)', at which point it is no longer
shadowed by the other nic_data declaration in the
'else if (!rc)' block.
Alternatively, we could rename the latter to 'pf_nic_data' or
something. Any opinions/preferences on which way to go? We
could even do both...
When I make up my mind I'll spin an incremental patch.
-ed
prev parent reply other threads:[~2020-05-29 0:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 13:41 [PATCH] [net-next] sfc: avoid an unused-variable warning Arnd Bergmann
2020-05-28 19:49 ` David Miller
2020-05-29 0:30 ` Edward Cree [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e7598b2-3301-1af4-8c2f-b40cdc5166a3@solarflare.com \
--to=ecree@solarflare.com \
--cc=amaftei@solarflare.com \
--cc=arnd@arndb.de \
--cc=davem@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=mhabets@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=tzhao@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).