From: John Stultz <john.stultz@linaro.org>
To: lkml <linux-kernel@vger.kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
Rakesh Pillai <pillair@qti.qualcomm.com>,
Govind Singh <govinds@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Niklas Cassel <niklas.cassel@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>,
Brian Norris <briannorris@chromium.org>,
Kalle Valo <kvalo@codeaurora.org>,
ath10k@lists.infradead.org
Subject: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot
Date: Tue, 2 Jun 2020 05:25:33 +0000 [thread overview]
Message-ID: <20200602052533.15048-1-john.stultz@linaro.org> (raw)
Ever since 5.7-rc1, if we call
ath10k_qmi_remove_msa_permission(), the db845c hard crashes on
reboot, resulting in the device getting stuck in the usb crash
debug mode and not coming back up wihthout a hard power off.
This hack avoids the issue by returning early in
ath10k_qmi_event_server_exit().
A better solution is very much desired!
Feedback and suggestions welcome!
Cc: Rakesh Pillai <pillair@qti.qualcomm.com>
Cc: Govind Singh <govinds@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Amit Pundir <amit.pundir@linaro.org>
Cc: Brian Norris <briannorris@chromium.org>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: ath10k@lists.infradead.org
Reported-by: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
drivers/net/wireless/ath/ath10k/qmi.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c
index 85dce43c5439..ab38562ce1cb 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.c
+++ b/drivers/net/wireless/ath/ath10k/qmi.c
@@ -854,6 +854,11 @@ static void ath10k_qmi_event_server_exit(struct ath10k_qmi *qmi)
struct ath10k *ar = qmi->ar;
struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
+ /*
+ * HACK: Calling ath10k_qmi_remove_msa_permission causes
+ * hardware to hard crash on reboot
+ */
+ return;
ath10k_qmi_remove_msa_permission(qmi);
ath10k_core_free_board_files(ar);
if (!test_bit(ATH10K_SNOC_FLAG_UNREGISTERING, &ar_snoc->flags))
--
2.17.1
next reply other threads:[~2020-06-02 5:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 5:25 John Stultz [this message]
2020-06-02 19:16 ` [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot Brian Norris
2020-06-02 19:40 ` John Stultz
2020-06-02 20:04 ` Brian Norris
2020-06-03 0:27 ` Manivannan Sadhasivam
2020-06-03 10:07 ` govinds
2020-06-04 18:17 ` Sibi Sankar
2020-06-08 11:37 ` Kalle Valo
2020-08-17 9:06 ` Amit Pundir
2020-08-28 12:52 ` Kalle Valo
2020-08-28 13:07 ` Govind Singh
2020-09-07 16:12 ` Kalle Valo
2020-06-08 11:17 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602052533.15048-1-john.stultz@linaro.org \
--to=john.stultz@linaro.org \
--cc=amit.pundir@linaro.org \
--cc=ath10k@lists.infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=briannorris@chromium.org \
--cc=govinds@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=niklas.cassel@linaro.org \
--cc=pillair@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).