* [PATCH 08/15] IB/qib: Use PCI_IRQ_MSI_TYPES where appropriate
@ 2020-06-02 9:20 Piotr Stankiewicz
2020-06-02 15:35 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Piotr Stankiewicz @ 2020-06-02 9:20 UTC (permalink / raw)
To: Dennis Dalessandro, Mike Marciniszyn, Doug Ledford, Jason Gunthorpe
Cc: linux-rdma, linux-kernel, Piotr Stankiewicz
Seeing as there is shorthand available to use when asking for any type
of interrupt, or any type of message signalled interrupt, leverage it.
Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
drivers/infiniband/hw/qib/qib_pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infiniband/hw/qib/qib_pcie.c
index 3dc6ce033319..3e22dd274fb3 100644
--- a/drivers/infiniband/hw/qib/qib_pcie.c
+++ b/drivers/infiniband/hw/qib/qib_pcie.c
@@ -213,7 +213,7 @@ int qib_pcie_params(struct qib_devdata *dd, u32 minw, u32 *nent)
u16 linkstat, speed;
int nvec;
int maxvec;
- unsigned int flags = PCI_IRQ_MSIX | PCI_IRQ_MSI;
+ unsigned int flags = PCI_IRQ_MSI_TYPES;
if (!pci_is_pcie(dd->pcidev)) {
qib_dev_err(dd, "Can't find PCI Express capability!\n");
--
2.17.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 08/15] IB/qib: Use PCI_IRQ_MSI_TYPES where appropriate
2020-06-02 9:20 [PATCH 08/15] IB/qib: Use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
@ 2020-06-02 15:35 ` Andy Shevchenko
2020-06-02 15:36 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-06-02 15:35 UTC (permalink / raw)
To: Piotr Stankiewicz
Cc: Dennis Dalessandro, Mike Marciniszyn, Doug Ledford,
Jason Gunthorpe, open list:HFI1 DRIVER,
Linux Kernel Mailing List
On Tue, Jun 2, 2020 at 12:25 PM Piotr Stankiewicz
<piotr.stankiewicz@intel.com> wrote:
>
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.
...
> - unsigned int flags = PCI_IRQ_MSIX | PCI_IRQ_MSI;
> + unsigned int flags = PCI_IRQ_MSI_TYPES;
>
> if (!pci_is_pcie(dd->pcidev)) {
> qib_dev_err(dd, "Can't find PCI Express capability!\n");
Internally I have proposed at last this:
convert the following
if (dd->flags & QIB_HAS_INTX)
flags |= PCI_IRQ_LEGACY;
to
if (dd->flags & QIB_HAS_INTX)
flags = PCI_IRQ_ALL_TYPES;
if (dd->flags & QIB_HAS_INTX)
flags = PCI_IRQ_MSI_TYPES;
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 08/15] IB/qib: Use PCI_IRQ_MSI_TYPES where appropriate
2020-06-02 15:35 ` Andy Shevchenko
@ 2020-06-02 15:36 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-06-02 15:36 UTC (permalink / raw)
To: Piotr Stankiewicz
Cc: Dennis Dalessandro, Mike Marciniszyn, Doug Ledford,
Jason Gunthorpe, open list:HFI1 DRIVER,
Linux Kernel Mailing List
On Tue, Jun 2, 2020 at 6:35 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Tue, Jun 2, 2020 at 12:25 PM Piotr Stankiewicz
> <piotr.stankiewicz@intel.com> wrote:
...
> if (dd->flags & QIB_HAS_INTX)
> flags = PCI_IRQ_ALL_TYPES;
> if (dd->flags & QIB_HAS_INTX)
This line should be 'else'.
> flags = PCI_IRQ_MSI_TYPES;
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-02 15:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 9:20 [PATCH 08/15] IB/qib: Use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
2020-06-02 15:35 ` Andy Shevchenko
2020-06-02 15:36 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).