* [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate
@ 2020-06-02 9:20 Piotr Stankiewicz
2020-06-02 12:08 ` Ulf Hansson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Piotr Stankiewicz @ 2020-06-02 9:20 UTC (permalink / raw)
To: Adrian Hunter, Ulf Hansson; +Cc: linux-mmc, linux-kernel, Piotr Stankiewicz
Seeing as there is shorthand available to use when asking for any type
of interrupt, or any type of message signalled interrupt, leverage it.
Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
drivers/mmc/host/sdhci-pci-gli.c | 3 +--
drivers/mmc/host/sdhci-pci-o2micro.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
index fd76aa672e02..d14997f9cbf9 100644
--- a/drivers/mmc/host/sdhci-pci-gli.c
+++ b/drivers/mmc/host/sdhci-pci-gli.c
@@ -271,8 +271,7 @@ static void gli_pcie_enable_msi(struct sdhci_pci_slot *slot)
{
int ret;
- ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1,
- PCI_IRQ_MSI | PCI_IRQ_MSIX);
+ ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
if (ret < 0) {
pr_warn("%s: enable PCI MSI failed, error=%d\n",
mmc_hostname(slot->host->mmc), ret);
diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
index fa8105087d68..498c51207bfb 100644
--- a/drivers/mmc/host/sdhci-pci-o2micro.c
+++ b/drivers/mmc/host/sdhci-pci-o2micro.c
@@ -470,8 +470,7 @@ static void sdhci_pci_o2_enable_msi(struct sdhci_pci_chip *chip,
return;
}
- ret = pci_alloc_irq_vectors(chip->pdev, 1, 1,
- PCI_IRQ_MSI | PCI_IRQ_MSIX);
+ ret = pci_alloc_irq_vectors(chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
if (ret < 0) {
pr_err("%s: enable PCI MSI failed, err=%d\n",
mmc_hostname(host->mmc), ret);
--
2.17.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate
2020-06-02 9:20 [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
@ 2020-06-02 12:08 ` Ulf Hansson
2020-06-02 13:16 ` Adrian Hunter
2020-06-03 5:26 ` Christoph Hellwig
2 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2020-06-02 12:08 UTC (permalink / raw)
To: Piotr Stankiewicz; +Cc: Adrian Hunter, linux-mmc, Linux Kernel Mailing List
On Tue, 2 Jun 2020 at 11:21, Piotr Stankiewicz
<piotr.stankiewicz@intel.com> wrote:
>
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.
>
> Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-pci-gli.c | 3 +--
> drivers/mmc/host/sdhci-pci-o2micro.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index fd76aa672e02..d14997f9cbf9 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -271,8 +271,7 @@ static void gli_pcie_enable_msi(struct sdhci_pci_slot *slot)
> {
> int ret;
>
> - ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1,
> - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> + ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
> if (ret < 0) {
> pr_warn("%s: enable PCI MSI failed, error=%d\n",
> mmc_hostname(slot->host->mmc), ret);
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
> index fa8105087d68..498c51207bfb 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -470,8 +470,7 @@ static void sdhci_pci_o2_enable_msi(struct sdhci_pci_chip *chip,
> return;
> }
>
> - ret = pci_alloc_irq_vectors(chip->pdev, 1, 1,
> - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> + ret = pci_alloc_irq_vectors(chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
> if (ret < 0) {
> pr_err("%s: enable PCI MSI failed, err=%d\n",
> mmc_hostname(host->mmc), ret);
> --
> 2.17.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate
2020-06-02 9:20 [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
2020-06-02 12:08 ` Ulf Hansson
@ 2020-06-02 13:16 ` Adrian Hunter
2020-06-03 5:26 ` Christoph Hellwig
2 siblings, 0 replies; 5+ messages in thread
From: Adrian Hunter @ 2020-06-02 13:16 UTC (permalink / raw)
To: Piotr Stankiewicz, Ulf Hansson; +Cc: linux-mmc, linux-kernel
On 2/06/20 12:20 pm, Piotr Stankiewicz wrote:
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.
>
> Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-pci-gli.c | 3 +--
> drivers/mmc/host/sdhci-pci-o2micro.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index fd76aa672e02..d14997f9cbf9 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -271,8 +271,7 @@ static void gli_pcie_enable_msi(struct sdhci_pci_slot *slot)
> {
> int ret;
>
> - ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1,
> - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> + ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
> if (ret < 0) {
> pr_warn("%s: enable PCI MSI failed, error=%d\n",
> mmc_hostname(slot->host->mmc), ret);
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
> index fa8105087d68..498c51207bfb 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -470,8 +470,7 @@ static void sdhci_pci_o2_enable_msi(struct sdhci_pci_chip *chip,
> return;
> }
>
> - ret = pci_alloc_irq_vectors(chip->pdev, 1, 1,
> - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> + ret = pci_alloc_irq_vectors(chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
> if (ret < 0) {
> pr_err("%s: enable PCI MSI failed, err=%d\n",
> mmc_hostname(host->mmc), ret);
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate
2020-06-02 9:20 [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
2020-06-02 12:08 ` Ulf Hansson
2020-06-02 13:16 ` Adrian Hunter
@ 2020-06-03 5:26 ` Christoph Hellwig
2020-06-03 6:16 ` Stankiewicz, Piotr
2 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2020-06-03 5:26 UTC (permalink / raw)
To: Piotr Stankiewicz; +Cc: Adrian Hunter, Ulf Hansson, linux-mmc, linux-kernel
On Tue, Jun 02, 2020 at 11:20:59AM +0200, Piotr Stankiewicz wrote:
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.
>
> Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
So this crap now shows up piecemail on various lists? Indepent of that
it seems like a bad idea to start with, bombing people with patches that
apparently depend on something you did first but they are not Cced on
is just an amazingly bad idea. Don't do that ever.
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate
2020-06-03 5:26 ` Christoph Hellwig
@ 2020-06-03 6:16 ` Stankiewicz, Piotr
0 siblings, 0 replies; 5+ messages in thread
From: Stankiewicz, Piotr @ 2020-06-03 6:16 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Hunter, Adrian, Ulf Hansson, linux-mmc, linux-kernel
> -----Original Message-----
> From: Christoph Hellwig <hch@infradead.org>
> Sent: Wednesday, June 3, 2020 7:27 AM
> To: Stankiewicz, Piotr <piotr.stankiewicz@intel.com>
> Cc: Hunter, Adrian <adrian.hunter@intel.com>; Ulf Hansson
> <ulf.hansson@linaro.org>; linux-mmc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where
> appropriate
>
> On Tue, Jun 02, 2020 at 11:20:59AM +0200, Piotr Stankiewicz wrote:
> > Seeing as there is shorthand available to use when asking for any type
> > of interrupt, or any type of message signalled interrupt, leverage it.
> >
> > Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> So this crap now shows up piecemail on various lists? Indepent of that it seems
> like a bad idea to start with, bombing people with patches that apparently
> depend on something you did first but they are not Cced on is just an amazingly
> bad idea. Don't do that ever.
I've sent the cover letter for the series to everyone question, to avoid spamming
people with irrelevant patches, but so that they can find the rest if necessary.
What would be a preferable thing to do?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-03 6:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 9:20 [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
2020-06-02 12:08 ` Ulf Hansson
2020-06-02 13:16 ` Adrian Hunter
2020-06-03 5:26 ` Christoph Hellwig
2020-06-03 6:16 ` Stankiewicz, Piotr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).