* [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free() [not found] <20200601135644.GD4872@ziepe.ca> @ 2020-06-02 6:16 ` YueHaibing 2020-06-02 15:30 ` Dennis Dalessandro 2020-06-03 0:36 ` Jason Gunthorpe 0 siblings, 2 replies; 4+ messages in thread From: YueHaibing @ 2020-06-02 6:16 UTC (permalink / raw) To: mike.marciniszyn, dennis.dalessandro, dledford, jgg, sadanand.warrier, grzegorz.andrejczuk, yuehaibing Cc: linux-rdma, linux-kernel, dan.carpenter, kernel-janitors dummy_netdev shold be freed by free_netdev() instead of kfree(). Also remove unneeded variable 'priv' Fixes: 4730f4a6c6b2 ("IB/hfi1: Activate the dummy netdev") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/infiniband/hw/hfi1/netdev_rx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c index 58af6a454761..63688e85e8da 100644 --- a/drivers/infiniband/hw/hfi1/netdev_rx.c +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c @@ -371,12 +371,9 @@ int hfi1_netdev_alloc(struct hfi1_devdata *dd) void hfi1_netdev_free(struct hfi1_devdata *dd) { - struct hfi1_netdev_priv *priv; - if (dd->dummy_netdev) { - priv = hfi1_netdev_priv(dd->dummy_netdev); dd_dev_info(dd, "hfi1 netdev freed\n"); - kfree(dd->dummy_netdev); + free_netdev(dd->dummy_netdev); dd->dummy_netdev = NULL; } } -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free() 2020-06-02 6:16 ` [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free() YueHaibing @ 2020-06-02 15:30 ` Dennis Dalessandro 2020-06-02 18:38 ` Dan Carpenter 2020-06-03 0:36 ` Jason Gunthorpe 1 sibling, 1 reply; 4+ messages in thread From: Dennis Dalessandro @ 2020-06-02 15:30 UTC (permalink / raw) To: YueHaibing, mike.marciniszyn, dledford, jgg, sadanand.warrier, grzegorz.andrejczuk Cc: linux-rdma, linux-kernel, dan.carpenter, kernel-janitors On 6/2/2020 2:16 AM, YueHaibing wrote: > dummy_netdev shold be freed by free_netdev() instead of > kfree(). Also remove unneeded variable 'priv' > > Fixes: 4730f4a6c6b2 ("IB/hfi1: Activate the dummy netdev") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/infiniband/hw/hfi1/netdev_rx.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c > index 58af6a454761..63688e85e8da 100644 > --- a/drivers/infiniband/hw/hfi1/netdev_rx.c > +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c > @@ -371,12 +371,9 @@ int hfi1_netdev_alloc(struct hfi1_devdata *dd) > > void hfi1_netdev_free(struct hfi1_devdata *dd) > { > - struct hfi1_netdev_priv *priv; > - > if (dd->dummy_netdev) { > - priv = hfi1_netdev_priv(dd->dummy_netdev); > dd_dev_info(dd, "hfi1 netdev freed\n"); > - kfree(dd->dummy_netdev); > + free_netdev(dd->dummy_netdev); > dd->dummy_netdev = NULL; > } > } > For the kfree->free_netdev, you probably want to add: Reported-by: kbuild test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Also can add: Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com> Thanks ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free() 2020-06-02 15:30 ` Dennis Dalessandro @ 2020-06-02 18:38 ` Dan Carpenter 0 siblings, 0 replies; 4+ messages in thread From: Dan Carpenter @ 2020-06-02 18:38 UTC (permalink / raw) To: Dennis Dalessandro Cc: YueHaibing, mike.marciniszyn, dledford, jgg, sadanand.warrier, grzegorz.andrejczuk, linux-rdma, linux-kernel, kernel-janitors On Tue, Jun 02, 2020 at 11:30:13AM -0400, Dennis Dalessandro wrote: > On 6/2/2020 2:16 AM, YueHaibing wrote: > > dummy_netdev shold be freed by free_netdev() instead of > > kfree(). Also remove unneeded variable 'priv' > > > > Fixes: 4730f4a6c6b2 ("IB/hfi1: Activate the dummy netdev") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > --- > > drivers/infiniband/hw/hfi1/netdev_rx.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c > > index 58af6a454761..63688e85e8da 100644 > > --- a/drivers/infiniband/hw/hfi1/netdev_rx.c > > +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c > > @@ -371,12 +371,9 @@ int hfi1_netdev_alloc(struct hfi1_devdata *dd) > > void hfi1_netdev_free(struct hfi1_devdata *dd) > > { > > - struct hfi1_netdev_priv *priv; > > - > > if (dd->dummy_netdev) { > > - priv = hfi1_netdev_priv(dd->dummy_netdev); > > dd_dev_info(dd, "hfi1 netdev freed\n"); > > - kfree(dd->dummy_netdev); > > + free_netdev(dd->dummy_netdev); > > dd->dummy_netdev = NULL; > > } > > } > > > > For the kfree->free_netdev, you probably want to add: > Reported-by: kbuild test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> YueHaibing wasn't on the CC list when I sent forwarded that kbuild bot email. Forget about it. Let's just apply this. regards, dan carpenter ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free() 2020-06-02 6:16 ` [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free() YueHaibing 2020-06-02 15:30 ` Dennis Dalessandro @ 2020-06-03 0:36 ` Jason Gunthorpe 1 sibling, 0 replies; 4+ messages in thread From: Jason Gunthorpe @ 2020-06-03 0:36 UTC (permalink / raw) To: YueHaibing Cc: mike.marciniszyn, dennis.dalessandro, dledford, sadanand.warrier, grzegorz.andrejczuk, linux-rdma, linux-kernel, dan.carpenter, kernel-janitors On Tue, Jun 02, 2020 at 02:16:35PM +0800, YueHaibing wrote: > dummy_netdev shold be freed by free_netdev() instead of > kfree(). Also remove unneeded variable 'priv' > > Fixes: 4730f4a6c6b2 ("IB/hfi1: Activate the dummy netdev") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > Reported-by: kbuild test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com> > --- > drivers/infiniband/hw/hfi1/netdev_rx.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Applied to for-next, thanks Jason ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-03 0:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200601135644.GD4872@ziepe.ca>
2020-06-02 6:16 ` [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free() YueHaibing
2020-06-02 15:30 ` Dennis Dalessandro
2020-06-02 18:38 ` Dan Carpenter
2020-06-03 0:36 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).