* [PATCH] media: marvell-ccic: Add missed v4l2_async_notifier_cleanup()
@ 2020-06-03 11:56 Chuhong Yuan
2020-06-03 12:41 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2020-06-03 11:56 UTC (permalink / raw)
Cc: Jonathan Corbet, Mauro Carvalho Chehab, Lubomir Rintel,
Sakari Ailus, linux-media, linux-kernel, Chuhong Yuan
mccic_register() forgets to cleanup the notifier in its error handler.
Add the missed call to fix it.
Fixes: 3eefe36cc00c ("media: marvell-ccic: use async notifier to get the sensor")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/media/platform/marvell-ccic/mcam-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/marvell-ccic/mcam-core.c
index 09775b6624c6..cf2a0119e679 100644
--- a/drivers/media/platform/marvell-ccic/mcam-core.c
+++ b/drivers/media/platform/marvell-ccic/mcam-core.c
@@ -1940,6 +1940,7 @@ int mccic_register(struct mcam_camera *cam)
out:
v4l2_async_notifier_unregister(&cam->notifier);
v4l2_device_unregister(&cam->v4l2_dev);
+ v4l2_async_notifier_cleanup(&cam->notifier);
return ret;
}
EXPORT_SYMBOL_GPL(mccic_register);
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: marvell-ccic: Add missed v4l2_async_notifier_cleanup()
2020-06-03 11:56 [PATCH] media: marvell-ccic: Add missed v4l2_async_notifier_cleanup() Chuhong Yuan
@ 2020-06-03 12:41 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2020-06-03 12:41 UTC (permalink / raw)
To: Chuhong Yuan
Cc: Jonathan Corbet, Mauro Carvalho Chehab, Lubomir Rintel,
linux-media, linux-kernel
Hi Chuhong,
Thanks for the patch.
On Wed, Jun 03, 2020 at 07:56:05PM +0800, Chuhong Yuan wrote:
> mccic_register() forgets to cleanup the notifier in its error handler.
> Add the missed call to fix it.
>
> Fixes: 3eefe36cc00c ("media: marvell-ccic: use async notifier to get the sensor")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> drivers/media/platform/marvell-ccic/mcam-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/marvell-ccic/mcam-core.c
> index 09775b6624c6..cf2a0119e679 100644
> --- a/drivers/media/platform/marvell-ccic/mcam-core.c
> +++ b/drivers/media/platform/marvell-ccic/mcam-core.c
> @@ -1940,6 +1940,7 @@ int mccic_register(struct mcam_camera *cam)
> out:
> v4l2_async_notifier_unregister(&cam->notifier);
> v4l2_device_unregister(&cam->v4l2_dev);
> + v4l2_async_notifier_cleanup(&cam->notifier);
> return ret;
> }
> EXPORT_SYMBOL_GPL(mccic_register);
The same issue appears to be present in the mcam_shutdown(), could you fix
that one as well?
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-03 12:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-03 11:56 [PATCH] media: marvell-ccic: Add missed v4l2_async_notifier_cleanup() Chuhong Yuan
2020-06-03 12:41 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).