* [PATCH] power: reset: gpio-poweroff: add missing '\n' in dev_err()
@ 2020-06-03 16:21 Luca Ceresoli
2020-06-05 23:16 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Luca Ceresoli @ 2020-06-03 16:21 UTC (permalink / raw)
To: linux-pm; +Cc: Luca Ceresoli, Sebastian Reichel, linux-kernel
dev_err() needs a terminating newline.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
drivers/power/reset/gpio-poweroff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/reset/gpio-poweroff.c b/drivers/power/reset/gpio-poweroff.c
index 6a4bbb506551..c5067eb75370 100644
--- a/drivers/power/reset/gpio-poweroff.c
+++ b/drivers/power/reset/gpio-poweroff.c
@@ -54,7 +54,7 @@ static int gpio_poweroff_probe(struct platform_device *pdev)
/* If a pm_power_off function has already been added, leave it alone */
if (pm_power_off != NULL) {
dev_err(&pdev->dev,
- "%s: pm_power_off function already registered",
+ "%s: pm_power_off function already registered\n",
__func__);
return -EBUSY;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: reset: gpio-poweroff: add missing '\n' in dev_err()
2020-06-03 16:21 [PATCH] power: reset: gpio-poweroff: add missing '\n' in dev_err() Luca Ceresoli
@ 2020-06-05 23:16 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2020-06-05 23:16 UTC (permalink / raw)
To: Luca Ceresoli; +Cc: linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
Hi,
On Wed, Jun 03, 2020 at 06:21:18PM +0200, Luca Ceresoli wrote:
> dev_err() needs a terminating newline.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/reset/gpio-poweroff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/gpio-poweroff.c b/drivers/power/reset/gpio-poweroff.c
> index 6a4bbb506551..c5067eb75370 100644
> --- a/drivers/power/reset/gpio-poweroff.c
> +++ b/drivers/power/reset/gpio-poweroff.c
> @@ -54,7 +54,7 @@ static int gpio_poweroff_probe(struct platform_device *pdev)
> /* If a pm_power_off function has already been added, leave it alone */
> if (pm_power_off != NULL) {
> dev_err(&pdev->dev,
> - "%s: pm_power_off function already registered",
> + "%s: pm_power_off function already registered\n",
> __func__);
> return -EBUSY;
> }
> --
> 2.26.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-05 23:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-03 16:21 [PATCH] power: reset: gpio-poweroff: add missing '\n' in dev_err() Luca Ceresoli
2020-06-05 23:16 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).