* [PATCH] dmaengine: tegra210-adma: handle pm_runtime_get_sync failure cases
@ 2020-06-04 20:10 Navid Emamdoost
2020-06-05 5:56 ` Jon Hunter
0 siblings, 1 reply; 2+ messages in thread
From: Navid Emamdoost @ 2020-06-04 20:10 UTC (permalink / raw)
To: Laxman Dewangan, Jon Hunter, Dan Williams, Vinod Koul,
Thierry Reding, dmaengine, linux-tegra, linux-kernel
Cc: emamd001, wu000273, kjlu, mccamant, Navid Emamdoost
Calling pm_runtime_get_sync increments the counter even in case of
failure, causing incorrect ref count. Call pm_runtime_put if
pm_runtime_get_sync fails.
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
drivers/dma/tegra210-adma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
index c4ce5dfb149b..899eaaf9fc48 100644
--- a/drivers/dma/tegra210-adma.c
+++ b/drivers/dma/tegra210-adma.c
@@ -659,6 +659,7 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc)
ret = pm_runtime_get_sync(tdc2dev(tdc));
if (ret < 0) {
free_irq(tdc->irq, tdc);
+ pm_runtime_put(tdc2dev(tdc));
return ret;
}
@@ -870,7 +871,7 @@ static int tegra_adma_probe(struct platform_device *pdev)
ret = pm_runtime_get_sync(&pdev->dev);
if (ret < 0)
- goto rpm_disable;
+ goto rpm_put;
ret = tegra_adma_init(tdma);
if (ret)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: tegra210-adma: handle pm_runtime_get_sync failure cases
2020-06-04 20:10 [PATCH] dmaengine: tegra210-adma: handle pm_runtime_get_sync failure cases Navid Emamdoost
@ 2020-06-05 5:56 ` Jon Hunter
0 siblings, 0 replies; 2+ messages in thread
From: Jon Hunter @ 2020-06-05 5:56 UTC (permalink / raw)
To: Navid Emamdoost, Laxman Dewangan, Dan Williams, Vinod Koul,
Thierry Reding, dmaengine, linux-tegra, linux-kernel
Cc: emamd001, wu000273, kjlu, mccamant
On 04/06/2020 21:10, Navid Emamdoost wrote:
> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count. Call pm_runtime_put if
> pm_runtime_get_sync fails.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
> drivers/dma/tegra210-adma.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index c4ce5dfb149b..899eaaf9fc48 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -659,6 +659,7 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc)
> ret = pm_runtime_get_sync(tdc2dev(tdc));
> if (ret < 0) {
> free_irq(tdc->irq, tdc);
> + pm_runtime_put(tdc2dev(tdc));
> return ret;
> }
>
> @@ -870,7 +871,7 @@ static int tegra_adma_probe(struct platform_device *pdev)
>
> ret = pm_runtime_get_sync(&pdev->dev);
> if (ret < 0)
> - goto rpm_disable;
> + goto rpm_put;
>
> ret = tegra_adma_init(tdma);
> if (ret)
>
The label rpm_disable should now be removed. You should also update the
subject-prefix to be [PATCH V2] to make it clear that this is the
updated patch.
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-05 5:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-04 20:10 [PATCH] dmaengine: tegra210-adma: handle pm_runtime_get_sync failure cases Navid Emamdoost
2020-06-05 5:56 ` Jon Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).