* [PATCH] cxgb4: Use kfree() instead kvfree() where appropriate
@ 2020-06-05 19:11 Denis Efremov
2020-06-05 20:23 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Denis Efremov @ 2020-06-05 19:11 UTC (permalink / raw)
To: Vishal Kulkarni, David S. Miller, Jakub Kicinski
Cc: Denis Efremov, netdev, linux-kernel
Use kfree(buf) in blocked_fl_read() because the memory is allocated with
kzalloc(). Use kfree(t) in blocked_fl_write() because the memory is
allocated with kcalloc().
Signed-off-by: Denis Efremov <efremov@linux.com>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
index 41315712deb8..828499256004 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
@@ -3357,7 +3357,7 @@ static ssize_t blocked_fl_read(struct file *filp, char __user *ubuf,
adap->sge.egr_sz, adap->sge.blocked_fl);
len += sprintf(buf + len, "\n");
size = simple_read_from_buffer(ubuf, count, ppos, buf, len);
- kvfree(buf);
+ kfree(buf);
return size;
}
@@ -3374,12 +3374,12 @@ static ssize_t blocked_fl_write(struct file *filp, const char __user *ubuf,
err = bitmap_parse_user(ubuf, count, t, adap->sge.egr_sz);
if (err) {
- kvfree(t);
+ kfree(t);
return err;
}
bitmap_copy(adap->sge.blocked_fl, t, adap->sge.egr_sz);
- kvfree(t);
+ kfree(t);
return count;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cxgb4: Use kfree() instead kvfree() where appropriate
2020-06-05 19:11 [PATCH] cxgb4: Use kfree() instead kvfree() where appropriate Denis Efremov
@ 2020-06-05 20:23 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-06-05 20:23 UTC (permalink / raw)
To: efremov; +Cc: vishal, kuba, netdev, linux-kernel
From: Denis Efremov <efremov@linux.com>
Date: Fri, 5 Jun 2020 22:11:44 +0300
> Use kfree(buf) in blocked_fl_read() because the memory is allocated with
> kzalloc(). Use kfree(t) in blocked_fl_write() because the memory is
> allocated with kcalloc().
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-05 20:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-05 19:11 [PATCH] cxgb4: Use kfree() instead kvfree() where appropriate Denis Efremov
2020-06-05 20:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).