From: Mark Brown <broonie@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Dmitry Osipenko <digetx@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
peron.clem@gmail.com, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-samsung-soc@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
Saravana Kannan <saravanak@google.com>
Subject: Re: [PATCH] regulator: do not balance 'boot-on' coupled regulators without constraints
Date: Fri, 5 Jun 2020 11:20:18 +0100 [thread overview]
Message-ID: <20200605102018.GA5413@sirena.org.uk> (raw)
In-Reply-To: <20200605063724.9030-1-m.szyprowski@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On Fri, Jun 05, 2020 at 08:37:24AM +0200, Marek Szyprowski wrote:
> Balancing of the 'boot-on' coupled regulators must wait until the clients
> set their constraints, otherwise the balancing code might change the
No, this is not what boot-on means at all. It is there for cases where
we can't read the enable status from the hardware. Trying to infer
*anything* about the runtime behaviour from it being present or absent
is very badly broken.
Saravana (CCed) was working on some patches which tried to deal with
some stuff around this for enables using the sync_state() callback.
Unfortunately there's quite a few problems with the current approach
(the biggest one from my point of view being that it's implemented so
that it requires every single consumer of every device on the PMIC to
come up but there's others at more of an implementation level).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-05 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200605063729eucas1p288dd9d3acdb62cc86745cb6af5c31fc6@eucas1p2.samsung.com>
2020-06-05 6:37 ` [PATCH] regulator: do not balance 'boot-on' coupled regulators without constraints Marek Szyprowski
2020-06-05 6:54 ` Viresh Kumar
2020-06-05 10:20 ` Mark Brown [this message]
2020-06-05 13:37 ` Marek Szyprowski
2020-06-05 15:59 ` Mark Brown
2020-06-09 2:37 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605102018.GA5413@sirena.org.uk \
--to=broonie@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=digetx@gmail.com \
--cc=krzk@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=nm@ti.com \
--cc=peron.clem@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).