* [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq()
@ 2020-06-05 12:55 Frank Lee
2020-06-05 12:55 ` [PATCH 2/2] mmc: mediatek: do not hide address in msdc_request_timeout() Frank Lee
2020-06-05 15:18 ` [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq() Maxime Ripard
0 siblings, 2 replies; 5+ messages in thread
From: Frank Lee @ 2020-06-05 12:55 UTC (permalink / raw)
To: chaotian.jing, ulf.hansson, matthias.bgg, mripard, wens,
tiny.windzz, rmfrfs, frank, marex, linux-mmc, linux-arm-kernel,
linux-mediatek, linux-kernel
From: Yangtao Li <tiny.windzz@gmail.com>
Using %px to show the actual address in sunxi_mmc_irq()
to help us to debug issue.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Signed-off-by: Frank Lee <frank@allwinnertech.com>
---
drivers/mmc/host/sunxi-mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index 5e95bbc51644..dcd30c3e1fac 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -574,7 +574,7 @@ static irqreturn_t sunxi_mmc_irq(int irq, void *dev_id)
idma_int = mmc_readl(host, REG_IDST);
msk_int = mmc_readl(host, REG_MISTA);
- dev_dbg(mmc_dev(host->mmc), "irq: rq %p mi %08x idi %08x\n",
+ dev_dbg(mmc_dev(host->mmc), "irq: rq %px mi %08x idi %08x\n",
host->mrq, msk_int, idma_int);
mrq = host->mrq;
--
2.24.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] mmc: mediatek: do not hide address in msdc_request_timeout()
2020-06-05 12:55 [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq() Frank Lee
@ 2020-06-05 12:55 ` Frank Lee
2020-06-05 15:18 ` [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq() Maxime Ripard
1 sibling, 0 replies; 5+ messages in thread
From: Frank Lee @ 2020-06-05 12:55 UTC (permalink / raw)
To: chaotian.jing, ulf.hansson, matthias.bgg, mripard, wens,
tiny.windzz, rmfrfs, frank, marex, linux-mmc, linux-arm-kernel,
linux-mediatek, linux-kernel
From: Yangtao Li <tiny.windzz@gmail.com>
Using %px to show the actual address in msdc_request_timeout()
to help us to debug issue.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Signed-off-by: Frank Lee <frank@allwinnertech.com>
---
drivers/mmc/host/mtk-sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 39e7fc54c438..28b4a136fc72 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1411,7 +1411,7 @@ static void msdc_request_timeout(struct work_struct *work)
/* simulate HW timeout status */
dev_err(host->dev, "%s: aborting cmd/data/mrq\n", __func__);
if (host->mrq) {
- dev_err(host->dev, "%s: aborting mrq=%p cmd=%d\n", __func__,
+ dev_err(host->dev, "%s: aborting mrq=%px cmd=%d\n", __func__,
host->mrq, host->mrq->cmd->opcode);
if (host->cmd) {
dev_err(host->dev, "%s: aborting cmd=%d\n",
--
2.24.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq()
2020-06-05 12:55 [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq() Frank Lee
2020-06-05 12:55 ` [PATCH 2/2] mmc: mediatek: do not hide address in msdc_request_timeout() Frank Lee
@ 2020-06-05 15:18 ` Maxime Ripard
2020-06-08 12:54 ` Frank Lee
1 sibling, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2020-06-05 15:18 UTC (permalink / raw)
To: Frank Lee
Cc: chaotian.jing, ulf.hansson, matthias.bgg, wens, tiny.windzz,
rmfrfs, marex, linux-mmc, linux-arm-kernel, linux-mediatek,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
Hi,
On Fri, Jun 05, 2020 at 08:55:44PM +0800, Frank Lee wrote:
> From: Yangtao Li <tiny.windzz@gmail.com>
>
> Using %px to show the actual address in sunxi_mmc_irq()
> to help us to debug issue.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> Signed-off-by: Frank Lee <frank@allwinnertech.com>
I'm fairly sure this hash is on purpose, and both the commit log of the
%px introduction (ad67b74d2469) and the checkpatch message are pretty
explicit about it.
What issue were you trying to solve here?
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq()
2020-06-05 15:18 ` [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq() Maxime Ripard
@ 2020-06-08 12:54 ` Frank Lee
2020-06-09 16:04 ` Maxime Ripard
0 siblings, 1 reply; 5+ messages in thread
From: Frank Lee @ 2020-06-08 12:54 UTC (permalink / raw)
To: Maxime Ripard
Cc: Frank Lee, chaotian.jing, Ulf Hansson, Matthias Brugger,
Chen-Yu Tsai, rmfrfs, marex, linux-mmc, Linux ARM,
linux-mediatek, Linux Kernel Mailing List
On Fri, Jun 5, 2020 at 11:18 PM Maxime Ripard <maxime@cerno.tech> wrote:
>
> Hi,
>
> On Fri, Jun 05, 2020 at 08:55:44PM +0800, Frank Lee wrote:
> > From: Yangtao Li <tiny.windzz@gmail.com>
> >
> > Using %px to show the actual address in sunxi_mmc_irq()
> > to help us to debug issue.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > Signed-off-by: Frank Lee <frank@allwinnertech.com>
>
> I'm fairly sure this hash is on purpose, and both the commit log of the
> %px introduction (ad67b74d2469) and the checkpatch message are pretty
> explicit about it.
>
> What issue were you trying to solve here?
There doesn't seem to be a strong requirement to force this to be printed out,
I just think that ____ptrval____ is very unpleasant.
Or delete %p directly?
Yangtao
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq()
2020-06-08 12:54 ` Frank Lee
@ 2020-06-09 16:04 ` Maxime Ripard
0 siblings, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2020-06-09 16:04 UTC (permalink / raw)
To: Frank Lee
Cc: Frank Lee, chaotian.jing, Ulf Hansson, Matthias Brugger,
Chen-Yu Tsai, rmfrfs, marex, linux-mmc, Linux ARM,
linux-mediatek, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]
On Mon, Jun 08, 2020 at 08:54:51PM +0800, Frank Lee wrote:
> On Fri, Jun 5, 2020 at 11:18 PM Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > Hi,
> >
> > On Fri, Jun 05, 2020 at 08:55:44PM +0800, Frank Lee wrote:
> > > From: Yangtao Li <tiny.windzz@gmail.com>
> > >
> > > Using %px to show the actual address in sunxi_mmc_irq()
> > > to help us to debug issue.
> > >
> > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > > Signed-off-by: Frank Lee <frank@allwinnertech.com>
> >
> > I'm fairly sure this hash is on purpose, and both the commit log of the
> > %px introduction (ad67b74d2469) and the checkpatch message are pretty
> > explicit about it.
> >
> > What issue were you trying to solve here?
>
> There doesn't seem to be a strong requirement to force this to be printed out,
> I just think that ____ptrval____ is very unpleasant.
That should happen only at boot when the system doesn't have enough
entropy iirc, after a while it prints out hashes.
> Or delete %p directly?
You mean the message in the driver? I'd be fine with that too.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-09 16:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-05 12:55 [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq() Frank Lee
2020-06-05 12:55 ` [PATCH 2/2] mmc: mediatek: do not hide address in msdc_request_timeout() Frank Lee
2020-06-05 15:18 ` [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq() Maxime Ripard
2020-06-08 12:54 ` Frank Lee
2020-06-09 16:04 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).