* [PATCH] dtc: also check <yaml.h> for libyaml
@ 2020-06-08 8:41 Jiping Ma
2020-06-08 19:09 ` Rob Herring
0 siblings, 1 reply; 9+ messages in thread
From: Jiping Ma @ 2020-06-08 8:41 UTC (permalink / raw)
To: frowand.list, jiping.ma2; +Cc: devicetree, linux-kernel
yamltree.c includes <yaml.h>, If /usr/include/yaml.h does not exist,
it fails to build.
Signed-off-by: Jiping Ma <jiping.ma2@windriver.com>
---
scripts/dtc/Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
index b5a5b1c..b49dfea 100644
--- a/scripts/dtc/Makefile
+++ b/scripts/dtc/Makefile
@@ -18,9 +18,13 @@ $(error dtc needs libyaml for DT schema validation support. \
endif
HOST_EXTRACFLAGS += -DNO_YAML
else
+ifeq ($(wildcard /usr/include/yaml.h),)
+HOST_EXTRACFLAGS += -DNO_YAML
+else
dtc-objs += yamltree.o
HOSTLDLIBS_dtc := $(shell pkg-config yaml-0.1 --libs)
endif
+endif
# Generated files need one more search path to include headers in source tree
HOSTCFLAGS_dtc-lexer.lex.o := -I $(srctree)/$(src)
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] dtc: also check <yaml.h> for libyaml
2020-06-08 8:41 [PATCH] dtc: also check <yaml.h> for libyaml Jiping Ma
@ 2020-06-08 19:09 ` Rob Herring
2020-06-09 1:00 ` Jiping Ma
0 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2020-06-08 19:09 UTC (permalink / raw)
To: Jiping Ma; +Cc: Frank Rowand, devicetree, linux-kernel
On Mon, Jun 8, 2020 at 2:42 AM Jiping Ma <jiping.ma2@windriver.com> wrote:
>
> yamltree.c includes <yaml.h>, If /usr/include/yaml.h does not exist,
> it fails to build.
Does this patch fix your issue?:
https://lore.kernel.org/linux-devicetree/20200505100319.741454-1-masahiroy@kernel.org/
> Signed-off-by: Jiping Ma <jiping.ma2@windriver.com>
> ---
> scripts/dtc/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
> index b5a5b1c..b49dfea 100644
> --- a/scripts/dtc/Makefile
> +++ b/scripts/dtc/Makefile
> @@ -18,9 +18,13 @@ $(error dtc needs libyaml for DT schema validation support. \
> endif
> HOST_EXTRACFLAGS += -DNO_YAML
> else
> +ifeq ($(wildcard /usr/include/yaml.h),)
> +HOST_EXTRACFLAGS += -DNO_YAML
> +else
> dtc-objs += yamltree.o
> HOSTLDLIBS_dtc := $(shell pkg-config yaml-0.1 --libs)
> endif
> +endif
>
> # Generated files need one more search path to include headers in source tree
> HOSTCFLAGS_dtc-lexer.lex.o := -I $(srctree)/$(src)
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dtc: also check <yaml.h> for libyaml
2020-06-08 19:09 ` Rob Herring
@ 2020-06-09 1:00 ` Jiping Ma
2020-06-09 2:43 ` Masahiro Yamada
2020-06-09 2:52 ` Masahiro Yamada
0 siblings, 2 replies; 9+ messages in thread
From: Jiping Ma @ 2020-06-09 1:00 UTC (permalink / raw)
To: Rob Herring; +Cc: Frank Rowand, devicetree, linux-kernel
On 06/09/2020 03:09 AM, Rob Herring wrote:
> On Mon, Jun 8, 2020 at 2:42 AM Jiping Ma <jiping.ma2@windriver.com> wrote:
>> yamltree.c includes <yaml.h>, If /usr/include/yaml.h does not exist,
>> it fails to build.
> Does this patch fix your issue?:
>
> https://lore.kernel.org/linux-devicetree/20200505100319.741454-1-masahiroy@kernel.org/
No, it did not fix the issue.
$ pkg-config --cflags yaml-0.1
$ pkg-config yaml-0.1 --libs
-L/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux/usr/lib64
-lyaml
>
>
>> Signed-off-by: Jiping Ma <jiping.ma2@windriver.com>
>> ---
>> scripts/dtc/Makefile | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
>> index b5a5b1c..b49dfea 100644
>> --- a/scripts/dtc/Makefile
>> +++ b/scripts/dtc/Makefile
>> @@ -18,9 +18,13 @@ $(error dtc needs libyaml for DT schema validation support. \
>> endif
>> HOST_EXTRACFLAGS += -DNO_YAML
>> else
>> +ifeq ($(wildcard /usr/include/yaml.h),)
>> +HOST_EXTRACFLAGS += -DNO_YAML
>> +else
>> dtc-objs += yamltree.o
>> HOSTLDLIBS_dtc := $(shell pkg-config yaml-0.1 --libs)
>> endif
>> +endif
>>
>> # Generated files need one more search path to include headers in source tree
>> HOSTCFLAGS_dtc-lexer.lex.o := -I $(srctree)/$(src)
>> --
>> 1.9.1
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dtc: also check <yaml.h> for libyaml
2020-06-09 1:00 ` Jiping Ma
@ 2020-06-09 2:43 ` Masahiro Yamada
2020-06-09 2:52 ` Masahiro Yamada
1 sibling, 0 replies; 9+ messages in thread
From: Masahiro Yamada @ 2020-06-09 2:43 UTC (permalink / raw)
To: Jiping Ma; +Cc: Rob Herring, Frank Rowand, DTML, linux-kernel
On Tue, Jun 9, 2020 at 10:01 AM Jiping Ma <Jiping.Ma2@windriver.com> wrote:
>
>
>
> On 06/09/2020 03:09 AM, Rob Herring wrote:
> > On Mon, Jun 8, 2020 at 2:42 AM Jiping Ma <jiping.ma2@windriver.com> wrote:
> >> yamltree.c includes <yaml.h>, If /usr/include/yaml.h does not exist,
> >> it fails to build.
> > Does this patch fix your issue?:
> >
> > https://lore.kernel.org/linux-devicetree/20200505100319.741454-1-masahiroy@kernel.org/
> No, it did not fix the issue.
>
> $ pkg-config --cflags yaml-0.1
>
Then, this is a problem on your system.
> $ pkg-config yaml-0.1 --libs
> -L/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux/usr/lib64
> -lyaml
>
> >
> >
> >> Signed-off-by: Jiping Ma <jiping.ma2@windriver.com>
> >> ---
> >> scripts/dtc/Makefile | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
> >> index b5a5b1c..b49dfea 100644
> >> --- a/scripts/dtc/Makefile
> >> +++ b/scripts/dtc/Makefile
> >> @@ -18,9 +18,13 @@ $(error dtc needs libyaml for DT schema validation support. \
> >> endif
> >> HOST_EXTRACFLAGS += -DNO_YAML
> >> else
> >> +ifeq ($(wildcard /usr/include/yaml.h),)
> >> +HOST_EXTRACFLAGS += -DNO_YAML
> >> +else
> >> dtc-objs += yamltree.o
> >> HOSTLDLIBS_dtc := $(shell pkg-config yaml-0.1 --libs)
> >> endif
> >> +endif
> >>
> >> # Generated files need one more search path to include headers in source tree
> >> HOSTCFLAGS_dtc-lexer.lex.o := -I $(srctree)/$(src)
> >> --
> >> 1.9.1
> >>
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dtc: also check <yaml.h> for libyaml
2020-06-09 1:00 ` Jiping Ma
2020-06-09 2:43 ` Masahiro Yamada
@ 2020-06-09 2:52 ` Masahiro Yamada
2020-06-09 3:07 ` Jiping Ma
1 sibling, 1 reply; 9+ messages in thread
From: Masahiro Yamada @ 2020-06-09 2:52 UTC (permalink / raw)
To: Jiping Ma; +Cc: Rob Herring, Frank Rowand, DTML, linux-kernel
On Tue, Jun 9, 2020 at 10:01 AM Jiping Ma <Jiping.Ma2@windriver.com> wrote:
>
>
>
> On 06/09/2020 03:09 AM, Rob Herring wrote:
> > On Mon, Jun 8, 2020 at 2:42 AM Jiping Ma <jiping.ma2@windriver.com> wrote:
> >> yamltree.c includes <yaml.h>, If /usr/include/yaml.h does not exist,
> >> it fails to build.
> > Does this patch fix your issue?:
> >
> > https://lore.kernel.org/linux-devicetree/20200505100319.741454-1-masahiroy@kernel.org/
> No, it did not fix the issue.
>
> $ pkg-config --cflags yaml-0.1
>
> $ pkg-config yaml-0.1 --libs
> -L/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux/usr/lib64
> -lyaml
If I install libyaml to a non-standard location
(/home/masahiro/foo), my pkg-config shows as follows:
masahiro@oscar:~$ pkg-config --cflags yaml-0.1
-I/home/masahiro/foo/include
masahiro@oscar:~$ pkg-config --libs yaml-0.1
-L/home/masahiro/foo/lib -lyaml
> >
> >
> >> Signed-off-by: Jiping Ma <jiping.ma2@windriver.com>
> >> ---
> >> scripts/dtc/Makefile | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
> >> index b5a5b1c..b49dfea 100644
> >> --- a/scripts/dtc/Makefile
> >> +++ b/scripts/dtc/Makefile
> >> @@ -18,9 +18,13 @@ $(error dtc needs libyaml for DT schema validation support. \
> >> endif
> >> HOST_EXTRACFLAGS += -DNO_YAML
> >> else
> >> +ifeq ($(wildcard /usr/include/yaml.h),)
> >> +HOST_EXTRACFLAGS += -DNO_YAML
> >> +else
> >> dtc-objs += yamltree.o
> >> HOSTLDLIBS_dtc := $(shell pkg-config yaml-0.1 --libs)
> >> endif
> >> +endif
> >>
> >> # Generated files need one more search path to include headers in source tree
> >> HOSTCFLAGS_dtc-lexer.lex.o := -I $(srctree)/$(src)
> >> --
> >> 1.9.1
> >>
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dtc: also check <yaml.h> for libyaml
2020-06-09 2:52 ` Masahiro Yamada
@ 2020-06-09 3:07 ` Jiping Ma
2020-06-10 0:28 ` Masahiro Yamada
0 siblings, 1 reply; 9+ messages in thread
From: Jiping Ma @ 2020-06-09 3:07 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Rob Herring, Frank Rowand, DTML, linux-kernel
On 06/09/2020 10:52 AM, Masahiro Yamada wrote:
> On Tue, Jun 9, 2020 at 10:01 AM Jiping Ma <Jiping.Ma2@windriver.com> wrote:
>>
>>
>> On 06/09/2020 03:09 AM, Rob Herring wrote:
>>> On Mon, Jun 8, 2020 at 2:42 AM Jiping Ma <jiping.ma2@windriver.com> wrote:
>>>> yamltree.c includes <yaml.h>, If /usr/include/yaml.h does not exist,
>>>> it fails to build.
>>> Does this patch fix your issue?:
>>>
>>> https://lore.kernel.org/linux-devicetree/20200505100319.741454-1-masahiroy@kernel.org/
>> No, it did not fix the issue.
>>
>> $ pkg-config --cflags yaml-0.1
>>
>> $ pkg-config yaml-0.1 --libs
>> -L/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux/usr/lib64
>> -lyaml
This issue happened in Yocto, After completing the SDK build and
installing it, use a new shell to source the environment and try to
build the helper scripts.
export
SDKTARGETSYSROOT=/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux
export
PKG_CONFIG_PATH=$SDKTARGETSYSROOT/usr/lib64/pkgconfig:$SDKTARGETSYSROOT/usr/share/pkgconfig
>
>
>
> If I install libyaml to a non-standard location
> (/home/masahiro/foo), my pkg-config shows as follows:
>
>
>
> masahiro@oscar:~$ pkg-config --cflags yaml-0.1
> -I/home/masahiro/foo/include
> masahiro@oscar:~$ pkg-config --libs yaml-0.1
> -L/home/masahiro/foo/lib -lyaml
>
>
>
>
>
>
>
>>>
>>>> Signed-off-by: Jiping Ma <jiping.ma2@windriver.com>
>>>> ---
>>>> scripts/dtc/Makefile | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
>>>> index b5a5b1c..b49dfea 100644
>>>> --- a/scripts/dtc/Makefile
>>>> +++ b/scripts/dtc/Makefile
>>>> @@ -18,9 +18,13 @@ $(error dtc needs libyaml for DT schema validation support. \
>>>> endif
>>>> HOST_EXTRACFLAGS += -DNO_YAML
>>>> else
>>>> +ifeq ($(wildcard /usr/include/yaml.h),)
>>>> +HOST_EXTRACFLAGS += -DNO_YAML
>>>> +else
>>>> dtc-objs += yamltree.o
>>>> HOSTLDLIBS_dtc := $(shell pkg-config yaml-0.1 --libs)
>>>> endif
>>>> +endif
>>>>
>>>> # Generated files need one more search path to include headers in source tree
>>>> HOSTCFLAGS_dtc-lexer.lex.o := -I $(srctree)/$(src)
>>>> --
>>>> 1.9.1
>>>>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dtc: also check <yaml.h> for libyaml
2020-06-09 3:07 ` Jiping Ma
@ 2020-06-10 0:28 ` Masahiro Yamada
2020-06-10 1:12 ` Jiping Ma
0 siblings, 1 reply; 9+ messages in thread
From: Masahiro Yamada @ 2020-06-10 0:28 UTC (permalink / raw)
To: Jiping Ma; +Cc: Rob Herring, Frank Rowand, DTML, linux-kernel
On Tue, Jun 9, 2020 at 12:08 PM Jiping Ma <Jiping.Ma2@windriver.com> wrote:
>
>
>
> On 06/09/2020 10:52 AM, Masahiro Yamada wrote:
> > On Tue, Jun 9, 2020 at 10:01 AM Jiping Ma <Jiping.Ma2@windriver.com> wrote:
> >>
> >>
> >> On 06/09/2020 03:09 AM, Rob Herring wrote:
> >>> On Mon, Jun 8, 2020 at 2:42 AM Jiping Ma <jiping.ma2@windriver.com> wrote:
> >>>> yamltree.c includes <yaml.h>, If /usr/include/yaml.h does not exist,
> >>>> it fails to build.
> >>> Does this patch fix your issue?:
> >>>
> >>> https://lore.kernel.org/linux-devicetree/20200505100319.741454-1-masahiroy@kernel.org/
> >> No, it did not fix the issue.
> >>
> >> $ pkg-config --cflags yaml-0.1
> >>
> >> $ pkg-config yaml-0.1 --libs
> >> -L/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux/usr/lib64
> >> -lyaml
> This issue happened in Yocto, After completing the SDK build and
> installing it, use a new shell to source the environment and try to
> build the helper scripts.
> export
> SDKTARGETSYSROOT=/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux
> export
> PKG_CONFIG_PATH=$SDKTARGETSYSROOT/usr/lib64/pkgconfig:$SDKTARGETSYSROOT/usr/share/pkgconfig
> >
> >
Probably, this commit:
https://github.com/yaml/libyaml/commit/3c80be99fb18f3ee18af37221a3b0c4760e8df06
Use newer libyaml, and that's fine.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dtc: also check <yaml.h> for libyaml
2020-06-10 0:28 ` Masahiro Yamada
@ 2020-06-10 1:12 ` Jiping Ma
2020-06-10 1:31 ` Masahiro Yamada
0 siblings, 1 reply; 9+ messages in thread
From: Jiping Ma @ 2020-06-10 1:12 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Rob Herring, Frank Rowand, DTML, linux-kernel
On 06/10/2020 08:28 AM, Masahiro Yamada wrote:
> On Tue, Jun 9, 2020 at 12:08 PM Jiping Ma <Jiping.Ma2@windriver.com> wrote:
>>
>>
>> On 06/09/2020 10:52 AM, Masahiro Yamada wrote:
>>> On Tue, Jun 9, 2020 at 10:01 AM Jiping Ma <Jiping.Ma2@windriver.com> wrote:
>>>>
>>>> On 06/09/2020 03:09 AM, Rob Herring wrote:
>>>>> On Mon, Jun 8, 2020 at 2:42 AM Jiping Ma <jiping.ma2@windriver.com> wrote:
>>>>>> yamltree.c includes <yaml.h>, If /usr/include/yaml.h does not exist,
>>>>>> it fails to build.
>>>>> Does this patch fix your issue?:
>>>>>
>>>>> https://lore.kernel.org/linux-devicetree/20200505100319.741454-1-masahiroy@kernel.org/
>>>> No, it did not fix the issue.
>>>>
>>>> $ pkg-config --cflags yaml-0.1
>>>>
>>>> $ pkg-config yaml-0.1 --libs
>>>> -L/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux/usr/lib64
>>>> -lyaml
>> This issue happened in Yocto, After completing the SDK build and
>> installing it, use a new shell to source the environment and try to
>> build the helper scripts.
>> export
>> SDKTARGETSYSROOT=/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux
>> export
>> PKG_CONFIG_PATH=$SDKTARGETSYSROOT/usr/lib64/pkgconfig:$SDKTARGETSYSROOT/usr/share/pkgconfig
>>>
>
> Probably, this commit:
>
> https://github.com/yaml/libyaml/commit/3c80be99fb18f3ee18af37221a3b0c4760e8df06
>
>
> Use newer libyaml, and that's fine.
This commit already was included in our code.
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dtc: also check <yaml.h> for libyaml
2020-06-10 1:12 ` Jiping Ma
@ 2020-06-10 1:31 ` Masahiro Yamada
0 siblings, 0 replies; 9+ messages in thread
From: Masahiro Yamada @ 2020-06-10 1:31 UTC (permalink / raw)
To: Jiping Ma; +Cc: Rob Herring, Frank Rowand, DTML, linux-kernel
On Wed, Jun 10, 2020 at 10:12 AM Jiping Ma <Jiping.Ma2@windriver.com> wrote:
>
>
>
> On 06/10/2020 08:28 AM, Masahiro Yamada wrote:
> > On Tue, Jun 9, 2020 at 12:08 PM Jiping Ma <Jiping.Ma2@windriver.com> wrote:
> >>
> >>
> >> On 06/09/2020 10:52 AM, Masahiro Yamada wrote:
> >>> On Tue, Jun 9, 2020 at 10:01 AM Jiping Ma <Jiping.Ma2@windriver.com> wrote:
> >>>>
> >>>> On 06/09/2020 03:09 AM, Rob Herring wrote:
> >>>>> On Mon, Jun 8, 2020 at 2:42 AM Jiping Ma <jiping.ma2@windriver.com> wrote:
> >>>>>> yamltree.c includes <yaml.h>, If /usr/include/yaml.h does not exist,
> >>>>>> it fails to build.
> >>>>> Does this patch fix your issue?:
> >>>>>
> >>>>> https://lore.kernel.org/linux-devicetree/20200505100319.741454-1-masahiroy@kernel.org/
> >>>> No, it did not fix the issue.
> >>>>
> >>>> $ pkg-config --cflags yaml-0.1
> >>>>
> >>>> $ pkg-config yaml-0.1 --libs
> >>>> -L/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux/usr/lib64
> >>>> -lyaml
> >> This issue happened in Yocto, After completing the SDK build and
> >> installing it, use a new shell to source the environment and try to
> >> build the helper scripts.
> >> export
> >> SDKTARGETSYSROOT=/buildarea/jma1/wr-19-0518/19.45/sysroots/aarch64-wrs-linux
> >> export
> >> PKG_CONFIG_PATH=$SDKTARGETSYSROOT/usr/lib64/pkgconfig:$SDKTARGETSYSROOT/usr/share/pkgconfig
> >>>
> >
> > Probably, this commit:
> >
> > https://github.com/yaml/libyaml/commit/3c80be99fb18f3ee18af37221a3b0c4760e8df06
> >
> >
> > Use newer libyaml, and that's fine.
> This commit already was included in our code.
Then, I have no idea,
but this is not a problem in the kernel build.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-06-10 1:32 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-08 8:41 [PATCH] dtc: also check <yaml.h> for libyaml Jiping Ma
2020-06-08 19:09 ` Rob Herring
2020-06-09 1:00 ` Jiping Ma
2020-06-09 2:43 ` Masahiro Yamada
2020-06-09 2:52 ` Masahiro Yamada
2020-06-09 3:07 ` Jiping Ma
2020-06-10 0:28 ` Masahiro Yamada
2020-06-10 1:12 ` Jiping Ma
2020-06-10 1:31 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).