From: Alan Stern <stern@rowland.harvard.edu>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: ohci-sm501: Add missed iounmap() in remove
Date: Wed, 10 Jun 2020 10:09:32 -0400 [thread overview]
Message-ID: <20200610140932.GA11727@rowland.harvard.edu> (raw)
In-Reply-To: <20200610024844.3628408-1-hslester96@gmail.com>
On Wed, Jun 10, 2020 at 10:48:44AM +0800, Chuhong Yuan wrote:
> This driver misses calling iounmap() in remove to undo the ioremap()
> called in probe.
> Add the missed call to fix it.
>
> Fixes: f54aab6ebcec ("usb: ohci-sm501 driver")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> drivers/usb/host/ohci-sm501.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/ohci-sm501.c b/drivers/usb/host/ohci-sm501.c
> index cff965240327..b91d50da6127 100644
> --- a/drivers/usb/host/ohci-sm501.c
> +++ b/drivers/usb/host/ohci-sm501.c
> @@ -191,6 +191,7 @@ static int ohci_hcd_sm501_drv_remove(struct platform_device *pdev)
> struct resource *mem;
>
> usb_remove_hcd(hcd);
> + iounmap(hcd->regs);
> release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
> usb_put_hcd(hcd);
> mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> --
> 2.26.2
Acked-by: Alan Stern <stern@rowland.harvard.edu>
prev parent reply other threads:[~2020-06-10 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 2:48 [PATCH] USB: ohci-sm501: Add missed iounmap() in remove Chuhong Yuan
2020-06-10 14:09 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610140932.GA11727@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=hslester96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).