* [PATCH 1/2] dt-bindings: ASoc: Fix tdm-slot documentation spelling error @ 2020-06-02 19:35 Dan Murphy 2020-06-02 19:35 ` [PATCH 2/2] dt-bindings: tas2562: Convert the tas2562 binding to yaml Dan Murphy 2020-06-08 12:46 ` [PATCH 1/2] dt-bindings: ASoc: Fix tdm-slot documentation spelling error Mark Brown 0 siblings, 2 replies; 4+ messages in thread From: Dan Murphy @ 2020-06-02 19:35 UTC (permalink / raw) To: lgirdwood, broonie, perex, tiwai Cc: alsa-devel, linux-kernel, robh, devicetree, Dan Murphy Fix the spelling of 'specified'. Also fix grammarical issue with the use of 'a' over 'an' Signed-off-by: Dan Murphy <dmurphy@ti.com> --- Documentation/devicetree/bindings/sound/tdm-slot.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/tdm-slot.txt b/Documentation/devicetree/bindings/sound/tdm-slot.txt index 34cf70e2cbc4..4bb513ae62fc 100644 --- a/Documentation/devicetree/bindings/sound/tdm-slot.txt +++ b/Documentation/devicetree/bindings/sound/tdm-slot.txt @@ -14,8 +14,8 @@ For instance: dai-tdm-slot-tx-mask = <0 1>; dai-tdm-slot-rx-mask = <1 0>; -And for each spcified driver, there could be one .of_xlate_tdm_slot_mask() -to specify a explicit mapping of the channels and the slots. If it's absent +And for each specified driver, there could be one .of_xlate_tdm_slot_mask() +to specify an explicit mapping of the channels and the slots. If it's absent the default snd_soc_of_xlate_tdm_slot_mask() will be used to generating the tx and rx masks. -- 2.26.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] dt-bindings: tas2562: Convert the tas2562 binding to yaml 2020-06-02 19:35 [PATCH 1/2] dt-bindings: ASoc: Fix tdm-slot documentation spelling error Dan Murphy @ 2020-06-02 19:35 ` Dan Murphy 2020-06-10 20:07 ` Rob Herring 2020-06-08 12:46 ` [PATCH 1/2] dt-bindings: ASoc: Fix tdm-slot documentation spelling error Mark Brown 1 sibling, 1 reply; 4+ messages in thread From: Dan Murphy @ 2020-06-02 19:35 UTC (permalink / raw) To: lgirdwood, broonie, perex, tiwai Cc: alsa-devel, linux-kernel, robh, devicetree, Dan Murphy Convert the TAS2562 text file to yaml format. Signed-off-by: Dan Murphy <dmurphy@ti.com> --- .../devicetree/bindings/sound/tas2562.txt | 34 ---------- .../devicetree/bindings/sound/tas2562.yaml | 65 +++++++++++++++++++ 2 files changed, 65 insertions(+), 34 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/tas2562.txt create mode 100644 Documentation/devicetree/bindings/sound/tas2562.yaml diff --git a/Documentation/devicetree/bindings/sound/tas2562.txt b/Documentation/devicetree/bindings/sound/tas2562.txt deleted file mode 100644 index 94796b547184..000000000000 --- a/Documentation/devicetree/bindings/sound/tas2562.txt +++ /dev/null @@ -1,34 +0,0 @@ -Texas Instruments TAS2562 Smart PA - -The TAS2562 is a mono, digital input Class-D audio amplifier optimized for -efficiently driving high peak power into small loudspeakers. -Integrated speaker voltage and current sense provides for -real time monitoring of loudspeaker behavior. - -Required properties: - - #address-cells - Should be <1>. - - #size-cells - Should be <0>. - - compatible: - Should contain "ti,tas2562", "ti,tas2563". - - reg: - The i2c address. Should be 0x4c, 0x4d, 0x4e or 0x4f. - - ti,imon-slot-no:- TDM TX current sense time slot. - -Optional properties: -- interrupt-parent: phandle to the interrupt controller which provides - the interrupt. -- interrupts: (GPIO) interrupt to which the chip is connected. -- shut-down: GPIO used to control the state of the device. - -Examples: -tas2562@4c { - #address-cells = <1>; - #size-cells = <0>; - compatible = "ti,tas2562"; - reg = <0x4c>; - - interrupt-parent = <&gpio1>; - interrupts = <14>; - - shut-down = <&gpio1 15 0>; - ti,imon-slot-no = <0>; -}; - diff --git a/Documentation/devicetree/bindings/sound/tas2562.yaml b/Documentation/devicetree/bindings/sound/tas2562.yaml new file mode 100644 index 000000000000..11e0269d03b3 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/tas2562.yaml @@ -0,0 +1,65 @@ +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause) +# Copyright (C) 2019 Texas Instruments Incorporated +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/sound/tas2562.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Texas Instruments TAS2562 Smart PA + +maintainers: + - Dan Murphy <dmurphy@ti.com> + +description: | + The TAS2562 is a mono, digital input Class-D audio amplifier optimized for + efficiently driving high peak power into small loudspeakers. + Integrated speaker voltage and current sense provides for + real time monitoring of loudspeaker behavior. + +properties: + compatible: + enum: + - ti,tas2562 + - ti,tas2563 + + reg: + maxItems: 1 + description: | + I2C addresss of the device can be one of these 0x4c, 0x4d, 0x4e or 0x4f + + shut-down: + description: GPIO used to control the state of the device. + + interrupts: + maxItems: 1 + + ti,imon-slot-no: + $ref: /schemas/types.yaml#/definitions/uint32 + description: TDM TX current sense time slot. + + '#sound-dai-cells': + const: 1 + +required: + - compatible + - reg +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + codec: codec@4c { + compatible = "ti,tas2562"; + reg = <0x4c>; + #sound-dai-cells = <1>; + interrupt-parent = <&gpio1>; + interrupts = <14>; + + shut-down = <&gpio1 15 0>; + ti,imon-slot-no = <0>; + }; + }; + -- 2.26.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] dt-bindings: tas2562: Convert the tas2562 binding to yaml 2020-06-02 19:35 ` [PATCH 2/2] dt-bindings: tas2562: Convert the tas2562 binding to yaml Dan Murphy @ 2020-06-10 20:07 ` Rob Herring 0 siblings, 0 replies; 4+ messages in thread From: Rob Herring @ 2020-06-10 20:07 UTC (permalink / raw) To: Dan Murphy Cc: lgirdwood, broonie, perex, tiwai, alsa-devel, linux-kernel, devicetree On Tue, Jun 02, 2020 at 02:35:24PM -0500, Dan Murphy wrote: > Convert the TAS2562 text file to yaml format. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > .../devicetree/bindings/sound/tas2562.txt | 34 ---------- > .../devicetree/bindings/sound/tas2562.yaml | 65 +++++++++++++++++++ > 2 files changed, 65 insertions(+), 34 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/tas2562.txt > create mode 100644 Documentation/devicetree/bindings/sound/tas2562.yaml > > diff --git a/Documentation/devicetree/bindings/sound/tas2562.txt b/Documentation/devicetree/bindings/sound/tas2562.txt > deleted file mode 100644 > index 94796b547184..000000000000 > --- a/Documentation/devicetree/bindings/sound/tas2562.txt > +++ /dev/null > @@ -1,34 +0,0 @@ > -Texas Instruments TAS2562 Smart PA > - > -The TAS2562 is a mono, digital input Class-D audio amplifier optimized for > -efficiently driving high peak power into small loudspeakers. > -Integrated speaker voltage and current sense provides for > -real time monitoring of loudspeaker behavior. > - > -Required properties: > - - #address-cells - Should be <1>. > - - #size-cells - Should be <0>. > - - compatible: - Should contain "ti,tas2562", "ti,tas2563". > - - reg: - The i2c address. Should be 0x4c, 0x4d, 0x4e or 0x4f. > - - ti,imon-slot-no:- TDM TX current sense time slot. > - > -Optional properties: > -- interrupt-parent: phandle to the interrupt controller which provides > - the interrupt. > -- interrupts: (GPIO) interrupt to which the chip is connected. > -- shut-down: GPIO used to control the state of the device. > - > -Examples: > -tas2562@4c { > - #address-cells = <1>; > - #size-cells = <0>; > - compatible = "ti,tas2562"; > - reg = <0x4c>; > - > - interrupt-parent = <&gpio1>; > - interrupts = <14>; > - > - shut-down = <&gpio1 15 0>; > - ti,imon-slot-no = <0>; > -}; > - > diff --git a/Documentation/devicetree/bindings/sound/tas2562.yaml b/Documentation/devicetree/bindings/sound/tas2562.yaml > new file mode 100644 > index 000000000000..11e0269d03b3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/tas2562.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause) > +# Copyright (C) 2019 Texas Instruments Incorporated > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/sound/tas2562.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Texas Instruments TAS2562 Smart PA > + > +maintainers: > + - Dan Murphy <dmurphy@ti.com> > + > +description: | > + The TAS2562 is a mono, digital input Class-D audio amplifier optimized for > + efficiently driving high peak power into small loudspeakers. > + Integrated speaker voltage and current sense provides for > + real time monitoring of loudspeaker behavior. > + > +properties: > + compatible: > + enum: > + - ti,tas2562 > + - ti,tas2563 > + > + reg: > + maxItems: 1 > + description: | > + I2C addresss of the device can be one of these 0x4c, 0x4d, 0x4e or 0x4f > + > + shut-down: Hopefully, this is an error. It should be 'shut-down-gpios'. Looking at the driver, it is also broken. It's passing 'shut-down-gpio' which means the GPIO core is looking for 'shut-down-gpio-gpio' or 'shut-down-gpio-gpios'. Also the standardish naming here is 'shutdown-gpios'. Given this probably never worked, we should use that. > + description: GPIO used to control the state of the device. > + > + interrupts: > + maxItems: 1 > + > + ti,imon-slot-no: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: TDM TX current sense time slot. > + > + '#sound-dai-cells': > + const: 1 > + > +required: > + - compatible > + - reg > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + codec: codec@4c { > + compatible = "ti,tas2562"; > + reg = <0x4c>; > + #sound-dai-cells = <1>; > + interrupt-parent = <&gpio1>; > + interrupts = <14>; > + > + shut-down = <&gpio1 15 0>; > + ti,imon-slot-no = <0>; > + }; > + }; > + > -- > 2.26.2 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: ASoc: Fix tdm-slot documentation spelling error 2020-06-02 19:35 [PATCH 1/2] dt-bindings: ASoc: Fix tdm-slot documentation spelling error Dan Murphy 2020-06-02 19:35 ` [PATCH 2/2] dt-bindings: tas2562: Convert the tas2562 binding to yaml Dan Murphy @ 2020-06-08 12:46 ` Mark Brown 1 sibling, 0 replies; 4+ messages in thread From: Mark Brown @ 2020-06-08 12:46 UTC (permalink / raw) To: lgirdwood, tiwai, Dan Murphy, perex Cc: linux-kernel, alsa-devel, robh, devicetree On Tue, 2 Jun 2020 14:35:23 -0500, Dan Murphy wrote: > Fix the spelling of 'specified'. Also fix grammarical issue with the > use of 'a' over 'an' Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] dt-bindings: ASoc: Fix tdm-slot documentation spelling error commit: 8a9144c1cf523221b37dd3393827253c91fcbf54 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-10 20:07 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-06-02 19:35 [PATCH 1/2] dt-bindings: ASoc: Fix tdm-slot documentation spelling error Dan Murphy 2020-06-02 19:35 ` [PATCH 2/2] dt-bindings: tas2562: Convert the tas2562 binding to yaml Dan Murphy 2020-06-10 20:07 ` Rob Herring 2020-06-08 12:46 ` [PATCH 1/2] dt-bindings: ASoc: Fix tdm-slot documentation spelling error Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).