Re: [PATCH] mm: pgtable: add shortcuts for accessing kernel PMD and PTE

Re: [PATCH] mm: pgtable: add shortcuts for accessing kernel PMD and PTE

[Guenter Roeck]

On Mon, Jun 08, 2020 at 09:33:05PM -0700, Mike Rapoport wrote:
> The powerpc 32-bit implementation of pgtable has nice shortcuts for
> accessing kernel PMD and PTE for a given virtual address.  Make these
> helpers available for all architectures.
> 
> [rppt@linux.ibm.com: microblaze: fix page table traversal in setup_rt_frame()]
>   Link: http://lkml.kernel.org/r/20200518191511.GD1118872@kernel.org
> [akpm@linux-foundation.org: s/pmd_ptr_k/pmd_off_k/ in various powerpc places]
> 
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
[ ... ]
> Link: http://lkml.kernel.org/r/20200514170327.31389-9-rppt@kernel.org
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Building powerpc:tqm8xx_defconfig ... failed
--------------
Error log:
arch/powerpc/mm/pgtable.c: In function 'set_huge_pte_at':
arch/powerpc/mm/pgtable.c:267:15: error: implicit declaration of function 'pmd_ptr'

bisect log attached.

Guenter

---
# bad: [5b14671be58d0084e7e2d1cc9c2c36a94467f6e0] Merge tag 'fuse-update-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse
# good: [abfbb29297c27e3f101f348dc9e467b0fe70f919] Merge tag 'rproc-v5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc
git bisect start 'HEAD' 'abfbb29297c2'
# bad: [595a56ac1b0d5f0a16a89589ef55ffd35c1967a2] Merge tag 'linux-kselftest-kunit-5.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
git bisect bad 595a56ac1b0d5f0a16a89589ef55ffd35c1967a2
# bad: [d8ed45c5dcd455fc5848d47f86883a1b872ac0d0] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites
git bisect bad d8ed45c5dcd455fc5848d47f86883a1b872ac0d0
# good: [2deebe4d56d638269a4a728086d64de5734b460a] sh: add loglvl to printk_address()
git bisect good 2deebe4d56d638269a4a728086d64de5734b460a
# good: [77819daf247aad16beaeb537ae77d1d6d0697ca2] kdb: don't play with console_loglevel
git bisect good 77819daf247aad16beaeb537ae77d1d6d0697ca2
# good: [e73240be691e1b081190125da67cd38822b8d5f8] m68k/mm/motorola: move comment about page table allocation funcitons
git bisect good e73240be691e1b081190125da67cd38822b8d5f8
# bad: [974b9b2c68f3d35a65e80af9657fe378d2439b60] mm: consolidate pte_index() and pte_offset_*() definitions
git bisect bad 974b9b2c68f3d35a65e80af9657fe378d2439b60
# good: [88107d330de4f175705a3ea03147feb0d7e68499] x86/mm: simplify init_trampoline() and surrounding logic
git bisect good 88107d330de4f175705a3ea03147feb0d7e68499
# bad: [e05c7b1f2bc4b7b28199b9a7572f73436d97317e] mm: pgtable: add shortcuts for accessing kernel PMD and PTE
git bisect bad e05c7b1f2bc4b7b28199b9a7572f73436d97317e
# first bad commit: [e05c7b1f2bc4b7b28199b9a7572f73436d97317e] mm: pgtable: add shortcuts for accessing kernel PMD and PTE