* [PATCH 1/4] misc: rtsx_usb: Constify struct usb_device_id
2020-06-10 22:47 [PATCH 0/4] drivers/misc: Constify static structs Rikard Falkeborn
@ 2020-06-10 22:47 ` Rikard Falkeborn
2020-06-10 22:47 ` [PATCH 2/4] misc: genwqe: Constify struct pci_error_handlers Rikard Falkeborn
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Rikard Falkeborn @ 2020-06-10 22:47 UTC (permalink / raw)
To: linux-kernel; +Cc: arnd, gregkh, Rikard Falkeborn
rtsx_usb_usb_ids is never modified and can therefore be made const to
allow the compiler to put it in read-only memory.
Before:
text data bss dec hex filename
21513 4160 128 25801 64c9 drivers/misc/cardreader/rtsx_usb.o
After:
text data bss dec hex filename
21673 4000 128 25801 64c9 drivers/misc/cardreader/rtsx_usb.o
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/misc/cardreader/rtsx_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cardreader/rtsx_usb.c b/drivers/misc/cardreader/rtsx_usb.c
index a328cab11014..59eda55d92a3 100644
--- a/drivers/misc/cardreader/rtsx_usb.c
+++ b/drivers/misc/cardreader/rtsx_usb.c
@@ -759,7 +759,7 @@ static int rtsx_usb_post_reset(struct usb_interface *intf)
return 0;
}
-static struct usb_device_id rtsx_usb_usb_ids[] = {
+static const struct usb_device_id rtsx_usb_usb_ids[] = {
{ USB_DEVICE(0x0BDA, 0x0129) },
{ USB_DEVICE(0x0BDA, 0x0139) },
{ USB_DEVICE(0x0BDA, 0x0140) },
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/4] misc: genwqe: Constify struct pci_error_handlers
2020-06-10 22:47 [PATCH 0/4] drivers/misc: Constify static structs Rikard Falkeborn
2020-06-10 22:47 ` [PATCH 1/4] misc: rtsx_usb: Constify struct usb_device_id Rikard Falkeborn
@ 2020-06-10 22:47 ` Rikard Falkeborn
2020-06-30 7:13 ` haver
2020-06-10 22:47 ` [PATCH 3/4] mei: hdcp: Constify struct mei_cl_device_id Rikard Falkeborn
2020-06-10 22:47 ` [PATCH 4/4] mic: vop: Constify static structs Rikard Falkeborn
3 siblings, 1 reply; 6+ messages in thread
From: Rikard Falkeborn @ 2020-06-10 22:47 UTC (permalink / raw)
To: linux-kernel; +Cc: arnd, gregkh, Rikard Falkeborn, Frank Haverkamp
genwqe_err_handler is never modified, so it can be made const to allow
the compiler to put it in read-only memory.
Before:
text data bss dec hex filename
20174 6104 2464 28742 7046 drivers/misc/genwqe/card_base.o
After:
text data bss dec hex filename
20270 6008 2464 28742 7046 drivers/misc/genwqe/card_base.o
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/misc/genwqe/card_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
index 1dc6c7c5cbce..9969c0003f15 100644
--- a/drivers/misc/genwqe/card_base.c
+++ b/drivers/misc/genwqe/card_base.c
@@ -1324,7 +1324,7 @@ static int genwqe_sriov_configure(struct pci_dev *dev, int numvfs)
return 0;
}
-static struct pci_error_handlers genwqe_err_handler = {
+static const struct pci_error_handlers genwqe_err_handler = {
.error_detected = genwqe_err_error_detected,
.mmio_enabled = genwqe_err_result_none,
.slot_reset = genwqe_err_slot_reset,
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/4] misc: genwqe: Constify struct pci_error_handlers
2020-06-10 22:47 ` [PATCH 2/4] misc: genwqe: Constify struct pci_error_handlers Rikard Falkeborn
@ 2020-06-30 7:13 ` haver
0 siblings, 0 replies; 6+ messages in thread
From: haver @ 2020-06-30 7:13 UTC (permalink / raw)
To: Rikard Falkeborn; +Cc: linux-kernel, arnd, gregkh, Frank Haverkamp
On 2020-06-11 00:47, Rikard Falkeborn wrote:
> genwqe_err_handler is never modified, so it can be made const to allow
> the compiler to put it in read-only memory.
>
> Before:
> text data bss dec hex filename
> 20174 6104 2464 28742 7046 drivers/misc/genwqe/card_base.o
>
> After:
> text data bss dec hex filename
> 20270 6008 2464 28742 7046 drivers/misc/genwqe/card_base.o
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/misc/genwqe/card_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/genwqe/card_base.c
> b/drivers/misc/genwqe/card_base.c
> index 1dc6c7c5cbce..9969c0003f15 100644
> --- a/drivers/misc/genwqe/card_base.c
> +++ b/drivers/misc/genwqe/card_base.c
> @@ -1324,7 +1324,7 @@ static int genwqe_sriov_configure(struct pci_dev
> *dev, int numvfs)
> return 0;
> }
>
> -static struct pci_error_handlers genwqe_err_handler = {
> +static const struct pci_error_handlers genwqe_err_handler = {
> .error_detected = genwqe_err_error_detected,
> .mmio_enabled = genwqe_err_result_none,
> .slot_reset = genwqe_err_slot_reset,
Good idea. Thanks for the contribution.
Signed-off-by: Frank Haverkamp <haver@linux.ibm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/4] mei: hdcp: Constify struct mei_cl_device_id
2020-06-10 22:47 [PATCH 0/4] drivers/misc: Constify static structs Rikard Falkeborn
2020-06-10 22:47 ` [PATCH 1/4] misc: rtsx_usb: Constify struct usb_device_id Rikard Falkeborn
2020-06-10 22:47 ` [PATCH 2/4] misc: genwqe: Constify struct pci_error_handlers Rikard Falkeborn
@ 2020-06-10 22:47 ` Rikard Falkeborn
2020-06-10 22:47 ` [PATCH 4/4] mic: vop: Constify static structs Rikard Falkeborn
3 siblings, 0 replies; 6+ messages in thread
From: Rikard Falkeborn @ 2020-06-10 22:47 UTC (permalink / raw)
To: linux-kernel; +Cc: arnd, gregkh, Rikard Falkeborn
mei_hdcp_tbl[] is never modified and can be made const to allow the
compiler to put it in read-only memory.
Before:
text data bss dec hex filename
15844 5416 0 21260 530c drivers/misc/mei/hdcp/mei_hdcp.o
After:
text data bss dec hex filename
16004 5256 0 21260 530c drivers/misc/mei/hdcp/mei_hdcp.o
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/misc/mei/hdcp/mei_hdcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hdcp.c
index 4c596c646ac0..e6c3dc595617 100644
--- a/drivers/misc/mei/hdcp/mei_hdcp.c
+++ b/drivers/misc/mei/hdcp/mei_hdcp.c
@@ -852,7 +852,7 @@ static int mei_hdcp_remove(struct mei_cl_device *cldev)
#define MEI_UUID_HDCP GUID_INIT(0xB638AB7E, 0x94E2, 0x4EA2, 0xA5, \
0x52, 0xD1, 0xC5, 0x4B, 0x62, 0x7F, 0x04)
-static struct mei_cl_device_id mei_hdcp_tbl[] = {
+static const struct mei_cl_device_id mei_hdcp_tbl[] = {
{ .uuid = MEI_UUID_HDCP, .version = MEI_CL_VERSION_ANY },
{ }
};
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/4] mic: vop: Constify static structs
2020-06-10 22:47 [PATCH 0/4] drivers/misc: Constify static structs Rikard Falkeborn
` (2 preceding siblings ...)
2020-06-10 22:47 ` [PATCH 3/4] mei: hdcp: Constify struct mei_cl_device_id Rikard Falkeborn
@ 2020-06-10 22:47 ` Rikard Falkeborn
3 siblings, 0 replies; 6+ messages in thread
From: Rikard Falkeborn @ 2020-06-10 22:47 UTC (permalink / raw)
To: linux-kernel; +Cc: arnd, gregkh, Rikard Falkeborn, Sudeep Dutt, Ashutosh Dixit
vop_vq_config_ops and id_table[] are never modified so make them const
to allow the compiler to put them in read-only memory.
Before:
text data bss dec hex filename
14889 4065 192 19146 4aca drivers/misc/mic/vop/vop_main.o
After:
text data bss dec hex filename
15113 3841 192 19146 4aca drivers/misc/mic/vop/vop_main.o
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/misc/mic/vop/vop_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c
index 85942f6717c5..51a1ab83a630 100644
--- a/drivers/misc/mic/vop/vop_main.c
+++ b/drivers/misc/mic/vop/vop_main.c
@@ -438,7 +438,7 @@ static int vop_find_vqs(struct virtio_device *dev, unsigned nvqs,
/*
* The config ops structure as defined by virtio config
*/
-static struct virtio_config_ops vop_vq_config_ops = {
+static const struct virtio_config_ops vop_vq_config_ops = {
.get_features = vop_get_features,
.finalize_features = vop_finalize_features,
.get = vop_get,
@@ -763,7 +763,7 @@ static void vop_driver_remove(struct vop_device *vpdev)
kfree(vi);
}
-static struct vop_device_id id_table[] = {
+static const struct vop_device_id id_table[] = {
{ VOP_DEV_TRNSP, VOP_DEV_ANY_ID },
{ 0 },
};
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread