* [PATCH] kthread: remove incorrect comment in kthread_create_on_cpu()
@ 2020-06-11 13:59 Ilias Stamatis
2020-06-12 9:29 ` Petr Mladek
0 siblings, 1 reply; 3+ messages in thread
From: Ilias Stamatis @ 2020-06-11 13:59 UTC (permalink / raw)
To: tglx, pmladek, peterz; +Cc: linux-kernel, Ilias Stamatis
Originally kthread_create_on_cpu() parked and woke up the new thread.
However, since commit a65d40961dc7 ("kthread/smpboot: do not park in
kthread_create_on_cpu()") this is no longer the case. This patch removes
the comment that has been left behind and is now incorrect / stale.
Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com>
---
kernel/kthread.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/kthread.c b/kernel/kthread.c
index bfbfa481be3a..38fa07ae59f6 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -455,7 +455,6 @@ EXPORT_SYMBOL(kthread_bind);
* to "name.*%u". Code fills in cpu number.
*
* Description: This helper function creates and names a kernel thread
- * The thread will be woken and put into park mode.
*/
struct task_struct *kthread_create_on_cpu(int (*threadfn)(void *data),
void *data, unsigned int cpu,
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kthread: remove incorrect comment in kthread_create_on_cpu()
2020-06-11 13:59 [PATCH] kthread: remove incorrect comment in kthread_create_on_cpu() Ilias Stamatis
@ 2020-06-12 9:29 ` Petr Mladek
2020-07-07 11:27 ` Ilias Stamatis
0 siblings, 1 reply; 3+ messages in thread
From: Petr Mladek @ 2020-06-12 9:29 UTC (permalink / raw)
To: Ilias Stamatis; +Cc: tglx, peterz, linux-kernel
On Thu 2020-06-11 16:59:21, Ilias Stamatis wrote:
> Originally kthread_create_on_cpu() parked and woke up the new thread.
> However, since commit a65d40961dc7 ("kthread/smpboot: do not park in
> kthread_create_on_cpu()") this is no longer the case. This patch removes
> the comment that has been left behind and is now incorrect / stale.
>
> Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com>
Good catch!
Fixes: a65d40961dc7 ("kthread/smpboot: do not park in kthread_create_on_cpu()")
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kthread: remove incorrect comment in kthread_create_on_cpu()
2020-06-12 9:29 ` Petr Mladek
@ 2020-07-07 11:27 ` Ilias Stamatis
0 siblings, 0 replies; 3+ messages in thread
From: Ilias Stamatis @ 2020-07-07 11:27 UTC (permalink / raw)
To: Petr Mladek; +Cc: tglx, peterz, linux-kernel, akpm, hch
On Fri, Jun 12, 2020 at 11:30 AM Petr Mladek <pmladek@suse.com> wrote:
>
> On Thu 2020-06-11 16:59:21, Ilias Stamatis wrote:
> > Originally kthread_create_on_cpu() parked and woke up the new thread.
> > However, since commit a65d40961dc7 ("kthread/smpboot: do not park in
> > kthread_create_on_cpu()") this is no longer the case. This patch removes
> > the comment that has been left behind and is now incorrect / stale.
> >
> > Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com>
>
> Good catch!
>
> Fixes: a65d40961dc7 ("kthread/smpboot: do not park in kthread_create_on_cpu()")
> Reviewed-by: Petr Mladek <pmladek@suse.com>
>
> Best Regards,
> Petr
Hi,
Thanks for the review!
Will somebody pick this up from the list for merging or should I
forward it somewhere else?
I'm new so I'm not sure exactly how the process works.
Best,
Ilias
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-07 11:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11 13:59 [PATCH] kthread: remove incorrect comment in kthread_create_on_cpu() Ilias Stamatis
2020-06-12 9:29 ` Petr Mladek
2020-07-07 11:27 ` Ilias Stamatis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).