* [PATCH] drivers\block: Use kobj_to_dev() API
@ 2020-06-12 7:10 Wang Qing
2020-06-12 14:27 ` Michael S. Tsirkin
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Wang Qing @ 2020-06-12 7:10 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, Paolo Bonzini, Stefan Hajnoczi,
Jens Axboe, virtualization, linux-block, linux-kernel
Cc: Wang Qing
Use kobj_to_dev() API instead of container_of().
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
drivers/block/virtio_blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
mode change 100644 => 100755 drivers/block/virtio_blk.c
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 9d21bf0..c808405
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -630,7 +630,7 @@ static struct attribute *virtblk_attrs[] = {
static umode_t virtblk_attrs_are_visible(struct kobject *kobj,
struct attribute *a, int n)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct gendisk *disk = dev_to_disk(dev);
struct virtio_blk *vblk = disk->private_data;
struct virtio_device *vdev = vblk->vdev;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers\block: Use kobj_to_dev() API
2020-06-12 7:10 [PATCH] drivers\block: Use kobj_to_dev() API Wang Qing
@ 2020-06-12 14:27 ` Michael S. Tsirkin
2020-06-15 7:18 ` 王擎
2020-06-19 12:49 ` Stefan Hajnoczi
2020-08-04 8:40 ` Ming Lei
2 siblings, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2020-06-12 14:27 UTC (permalink / raw)
To: Wang Qing
Cc: Jason Wang, Paolo Bonzini, Stefan Hajnoczi, Jens Axboe,
virtualization, linux-block, linux-kernel
On Fri, Jun 12, 2020 at 03:10:56PM +0800, Wang Qing wrote:
> Use kobj_to_dev() API instead of container_of().
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> drivers/block/virtio_blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> mode change 100644 => 100755 drivers/block/virtio_blk.c
Subject should probably use "/". Besides that - trivial tree?
>
> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> index 9d21bf0..c808405
> --- a/drivers/block/virtio_blk.c
> +++ b/drivers/block/virtio_blk.c
> @@ -630,7 +630,7 @@ static struct attribute *virtblk_attrs[] = {
> static umode_t virtblk_attrs_are_visible(struct kobject *kobj,
> struct attribute *a, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct gendisk *disk = dev_to_disk(dev);
> struct virtio_blk *vblk = disk->private_data;
> struct virtio_device *vdev = vblk->vdev;
> --
> 2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re:Re: [PATCH] drivers\block: Use kobj_to_dev() API
2020-06-12 14:27 ` Michael S. Tsirkin
@ 2020-06-15 7:18 ` 王擎
0 siblings, 0 replies; 5+ messages in thread
From: 王擎 @ 2020-06-15 7:18 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: virtualization, linux-block, linux-kernel
Subject: Re: [PATCH] drivers\block: Use kobj_to_dev() API>On Fri, Jun 12, 2020 at 03:10:56PM +0800, Wang Qing wrote:
>> Use kobj_to_dev() API instead of container_of().
>>
>> Signed-off-by: Wang Qing <wangqing@vivo.com>
>> ---
>> drivers/block/virtio_blk.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> mode change 100644 => 100755 drivers/block/virtio_blk.c
>
>
>Subject should probably use "/". Besides that - trivial tree?
Sorry, I will modify subject using "/". But what do you mean about trivial tree?
>
>>
>> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
>> index 9d21bf0..c808405
>> --- a/drivers/block/virtio_blk.c
>> +++ b/drivers/block/virtio_blk.c
>> @@ -630,7 +630,7 @@ static struct attribute *virtblk_attrs[] = {
>> static umode_t virtblk_attrs_are_visible(struct kobject *kobj,
>> struct attribute *a, int n)
>> {
>> - struct device *dev = container_of(kobj, struct device, kobj);
>> + struct device *dev = kobj_to_dev(kobj);
>> struct gendisk *disk = dev_to_disk(dev);
>> struct virtio_blk *vblk = disk->private_data;
>> struct virtio_device *vdev = vblk->vdev;
>> --
>> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers\block: Use kobj_to_dev() API
2020-06-12 7:10 [PATCH] drivers\block: Use kobj_to_dev() API Wang Qing
2020-06-12 14:27 ` Michael S. Tsirkin
@ 2020-06-19 12:49 ` Stefan Hajnoczi
2020-08-04 8:40 ` Ming Lei
2 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2020-06-19 12:49 UTC (permalink / raw)
To: Wang Qing
Cc: Michael S. Tsirkin, Jason Wang, Paolo Bonzini, Jens Axboe,
virtualization, linux-block, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
On Fri, Jun 12, 2020 at 03:10:56PM +0800, Wang Qing wrote:
> Use kobj_to_dev() API instead of container_of().
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> drivers/block/virtio_blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> mode change 100644 => 100755 drivers/block/virtio_blk.c
Please fix the '\' -> '/' in the commit message. Looks good otherwise:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers\block: Use kobj_to_dev() API
2020-06-12 7:10 [PATCH] drivers\block: Use kobj_to_dev() API Wang Qing
2020-06-12 14:27 ` Michael S. Tsirkin
2020-06-19 12:49 ` Stefan Hajnoczi
@ 2020-08-04 8:40 ` Ming Lei
2 siblings, 0 replies; 5+ messages in thread
From: Ming Lei @ 2020-08-04 8:40 UTC (permalink / raw)
To: Wang Qing
Cc: Michael S. Tsirkin, Jason Wang, Paolo Bonzini, Stefan Hajnoczi,
Jens Axboe, virtualization, linux-block, linux-kernel
On Fri, Jun 12, 2020 at 03:10:56PM +0800, Wang Qing wrote:
> Use kobj_to_dev() API instead of container_of().
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> drivers/block/virtio_blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> mode change 100644 => 100755 drivers/block/virtio_blk.c
>
> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> index 9d21bf0..c808405
> --- a/drivers/block/virtio_blk.c
> +++ b/drivers/block/virtio_blk.c
> @@ -630,7 +630,7 @@ static struct attribute *virtblk_attrs[] = {
> static umode_t virtblk_attrs_are_visible(struct kobject *kobj,
> struct attribute *a, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct gendisk *disk = dev_to_disk(dev);
> struct virtio_blk *vblk = disk->private_data;
> struct virtio_device *vdev = vblk->vdev;
> --
> 2.7.4
>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-04 8:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-12 7:10 [PATCH] drivers\block: Use kobj_to_dev() API Wang Qing
2020-06-12 14:27 ` Michael S. Tsirkin
2020-06-15 7:18 ` 王擎
2020-06-19 12:49 ` Stefan Hajnoczi
2020-08-04 8:40 ` Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).