* [PATCH] media: mtk-jpeg: Fix a reference count leak.
@ 2020-06-13 23:08 wu000273
2020-09-17 11:42 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: wu000273 @ 2020-06-13 23:08 UTC (permalink / raw)
To: kjlu
Cc: wu000273, Rick Chang, Bin Liu, Mauro Carvalho Chehab,
Matthias Brugger, Ricky Liang, Hans Verkuil, Minghsiu Tsai,
linux-media, linux-arm-kernel, linux-mediatek, linux-kernel
From: Qiushi Wu <wu000273@umn.edu>
pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus call pm_runtime_put_noidle()
if pm_runtime_get_sync() fails.
Fixes: b2f0d2724ba4 ("[media] vcodec: mediatek: Add Mediatek JPEG Decoder Driver")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index f82a81a3bdee..097f0b050f67 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -710,8 +710,10 @@ static int mtk_jpeg_start_streaming(struct vb2_queue *q, unsigned int count)
int ret = 0;
ret = pm_runtime_get_sync(ctx->jpeg->dev);
- if (ret < 0)
+ if (ret < 0) {
+ pm_runtime_put_noidle(ctx->jpeg->dev);
goto err;
+ }
return 0;
err:
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: mtk-jpeg: Fix a reference count leak.
2020-06-13 23:08 [PATCH] media: mtk-jpeg: Fix a reference count leak wu000273
@ 2020-09-17 11:42 ` Hans Verkuil
2021-04-21 13:28 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2020-09-17 11:42 UTC (permalink / raw)
To: wu000273, kjlu
Cc: Rick Chang, Bin Liu, Mauro Carvalho Chehab, Matthias Brugger,
Ricky Liang, Hans Verkuil, Minghsiu Tsai, linux-media,
linux-arm-kernel, linux-mediatek, linux-kernel
On 14/06/2020 01:08, wu000273@umn.edu wrote:
> From: Qiushi Wu <wu000273@umn.edu>
>
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus call pm_runtime_put_noidle()
> if pm_runtime_get_sync() fails.
>
> Fixes: b2f0d2724ba4 ("[media] vcodec: mediatek: Add Mediatek JPEG Decoder Driver")
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index f82a81a3bdee..097f0b050f67 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -710,8 +710,10 @@ static int mtk_jpeg_start_streaming(struct vb2_queue *q, unsigned int count)
> int ret = 0;
>
> ret = pm_runtime_get_sync(ctx->jpeg->dev);
> - if (ret < 0)
> + if (ret < 0) {
> + pm_runtime_put_noidle(ctx->jpeg->dev);
> goto err;
> + }
>
> return 0;
> err:
>
This patch no longer applies, can you rebase this?
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: mtk-jpeg: Fix a reference count leak.
2020-09-17 11:42 ` Hans Verkuil
@ 2021-04-21 13:28 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-04-21 13:28 UTC (permalink / raw)
To: Hans Verkuil
Cc: wu000273, kjlu, Rick Chang, Bin Liu, Mauro Carvalho Chehab,
Matthias Brugger, Ricky Liang, Hans Verkuil, Minghsiu Tsai,
linux-media, linux-arm-kernel, linux-mediatek, linux-kernel
On Thu, 17 Sept 2020 at 13:48, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> On 14/06/2020 01:08, wu000273@umn.edu wrote:
> > From: Qiushi Wu <wu000273@umn.edu>
> >
> > pm_runtime_get_sync() increments the runtime PM usage counter even
> > when it returns an error code. Thus call pm_runtime_put_noidle()
> > if pm_runtime_get_sync() fails.
> >
> > Fixes: b2f0d2724ba4 ("[media] vcodec: mediatek: Add Mediatek JPEG Decoder Driver")
> > Signed-off-by: Qiushi Wu <wu000273@umn.edu>
> > ---
> > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> > index f82a81a3bdee..097f0b050f67 100644
> > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> > @@ -710,8 +710,10 @@ static int mtk_jpeg_start_streaming(struct vb2_queue *q, unsigned int count)
> > int ret = 0;
> >
> > ret = pm_runtime_get_sync(ctx->jpeg->dev);
> > - if (ret < 0)
> > + if (ret < 0) {
> > + pm_runtime_put_noidle(ctx->jpeg->dev);
> > goto err;
> > + }
> >
> > return 0;
> > err:
> >
>
> This patch no longer applies, can you rebase this?
This patch might be harmful, might be not. Probably should be skipped
due to uncertain intentions:
https://lore.kernel.org/linux-nfs/YH+7ZydHv4+Y1hlx@kroah.com/
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-21 13:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-13 23:08 [PATCH] media: mtk-jpeg: Fix a reference count leak wu000273
2020-09-17 11:42 ` Hans Verkuil
2021-04-21 13:28 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).