linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] Fix code style in css_task_iter_next_css_set()
@ 2020-06-12 19:56 Markus Elfring
  2020-06-14  7:13 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2020-06-12 19:56 UTC (permalink / raw)
  To: weifenghai, cgroups; +Cc: linux-kernel, Johannes Weiner, Li Zefan, Tejun Heo

> One line similar code before in this function

I suggest to improve the commit message.
How do you think about a wording variant like the following?

   Combine two assignments for the variable “l” into one statement.

Regards,
Markus

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] Fix code style in css_task_iter_next_css_set()
  2020-06-12 19:56 [PATCH] Fix code style in css_task_iter_next_css_set() Markus Elfring
@ 2020-06-14  7:13 ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-06-14  7:13 UTC (permalink / raw)
  To: Markus Elfring
  Cc: weifenghai, cgroups, linux-kernel, Johannes Weiner, Li Zefan, Tejun Heo

On Fri, Jun 12, 2020 at 09:56:26PM +0200, Markus Elfring wrote:
> > One line similar code before in this function
> 
> I suggest to improve the commit message.
> How do you think about a wording variant like the following?
> 
>    Combine two assignments for the variable “l” into one statement.
> 
> Regards,
> Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] Fix code style in css_task_iter_next_css_set()
  2020-06-13  0:53 [PATCH v2] Fix code style same in one function zzuedu2000
@ 2020-06-14  2:14 ` zzuedu2000
  0 siblings, 0 replies; 3+ messages in thread
From: zzuedu2000 @ 2020-06-14  2:14 UTC (permalink / raw)
  To: tj, lizefan, hannes; +Cc: cgroups, linux-kernel

Please ignore this patch, I will send a updated one later.

Regards,
Wei Fenghai


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-14  7:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-12 19:56 [PATCH] Fix code style in css_task_iter_next_css_set() Markus Elfring
2020-06-14  7:13 ` Greg KH
2020-06-13  0:53 [PATCH v2] Fix code style same in one function zzuedu2000
2020-06-14  2:14 ` [PATCH] Fix code style in css_task_iter_next_css_set() zzuedu2000

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).