[PATCH v5 3/3] counter: 104-quad-8: Add lock guards

* [PATCH v5 3/3] counter: 104-quad-8: Add lock guards - filter clock prescaler
@ 2020-03-16 12:50 Syed Nayyar Waris
  2020-03-18  2:18 ` William Breathitt Gray
  0 siblings, 1 reply; 4+ messages in thread
From: Syed Nayyar Waris @ 2020-03-16 12:50 UTC (permalink / raw)
  To: vilhelm.gray; +Cc: jic23, linux-iio, linux-kernel

Add lock protection from race conditions to the 104-quad-8 counter
driver for filter clock prescaler code changes. Mutex calls used for
protection.

Signed-off-by: Syed Nayyar Waris <syednwaris@gmail.com>
---
Changes in v5:
 - Change spin lock calls to mutex lock calls.
 - Modify the title description.

 drivers/counter/104-quad-8.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
index 9dab190..b268165 100644
--- a/drivers/counter/104-quad-8.c
+++ b/drivers/counter/104-quad-8.c
@@ -1230,6 +1230,8 @@ static ssize_t quad8_signal_fck_prescaler_write(struct counter_device *counter,
 	if (ret)
 		return ret;
 
+	mutex_lock(&priv->lock);
+
 	priv->fck_prescaler[channel_id] = prescaler;
 
 	/* Reset Byte Pointer */
@@ -1240,6 +1242,8 @@ static ssize_t quad8_signal_fck_prescaler_write(struct counter_device *counter,
 	outb(QUAD8_CTR_RLD | QUAD8_RLD_RESET_BP | QUAD8_RLD_PRESET_PSC,
 	     base_offset + 1);
 
+	mutex_unlock(&priv->lock);
+
 	return len;
 }
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread