* [PATCH net v2] mptcp: drop MPTCP_PM_MAX_ADDR
@ 2020-06-15 8:28 Geliang Tang
2020-06-15 10:29 ` Matthieu Baerts
2020-06-15 20:01 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Geliang Tang @ 2020-06-15 8:28 UTC (permalink / raw)
To: Mat Martineau, Matthieu Baerts, David S. Miller, Jakub Kicinski
Cc: Geliang Tang, netdev, mptcp, linux-kernel
We have defined MPTCP_PM_ADDR_MAX in pm_netlink.c, so drop this duplicate macro.
Fixes: 1b1c7a0ef7f3 ("mptcp: Add path manager interface")
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
Changes in v2:
- change Subject from "mptcp: unify MPTCP_PM_MAX_ADDR and MPTCP_PM_ADDR_MAX"
---
net/mptcp/protocol.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
index 809687d3f410..70ed698bd206 100644
--- a/net/mptcp/protocol.h
+++ b/net/mptcp/protocol.h
@@ -135,8 +135,6 @@ static inline __be32 mptcp_option(u8 subopt, u8 len, u8 nib, u8 field)
((nib & 0xF) << 8) | field);
}
-#define MPTCP_PM_MAX_ADDR 4
-
struct mptcp_addr_info {
sa_family_t family;
__be16 port;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] mptcp: drop MPTCP_PM_MAX_ADDR
2020-06-15 8:28 [PATCH net v2] mptcp: drop MPTCP_PM_MAX_ADDR Geliang Tang
@ 2020-06-15 10:29 ` Matthieu Baerts
2020-06-15 20:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Matthieu Baerts @ 2020-06-15 10:29 UTC (permalink / raw)
To: Geliang Tang, Mat Martineau, David S. Miller, Jakub Kicinski
Cc: netdev, mptcp, linux-kernel
Hi Geliang,
On 15/06/2020 10:28, Geliang Tang wrote:
> We have defined MPTCP_PM_ADDR_MAX in pm_netlink.c, so drop this duplicate macro.
>
> Fixes: 1b1c7a0ef7f3 ("mptcp: Add path manager interface")
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> Changes in v2:
> - change Subject from "mptcp: unify MPTCP_PM_MAX_ADDR and MPTCP_PM_ADDR_MAX"
Thank you for this v2, it looks good to me!
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] mptcp: drop MPTCP_PM_MAX_ADDR
2020-06-15 8:28 [PATCH net v2] mptcp: drop MPTCP_PM_MAX_ADDR Geliang Tang
2020-06-15 10:29 ` Matthieu Baerts
@ 2020-06-15 20:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-06-15 20:01 UTC (permalink / raw)
To: geliangtang
Cc: mathew.j.martineau, matthieu.baerts, kuba, netdev, mptcp, linux-kernel
From: Geliang Tang <geliangtang@gmail.com>
Date: Mon, 15 Jun 2020 16:28:03 +0800
> We have defined MPTCP_PM_ADDR_MAX in pm_netlink.c, so drop this duplicate macro.
>
> Fixes: 1b1c7a0ef7f3 ("mptcp: Add path manager interface")
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> Changes in v2:
> - change Subject from "mptcp: unify MPTCP_PM_MAX_ADDR and MPTCP_PM_ADDR_MAX"
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-15 20:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15 8:28 [PATCH net v2] mptcp: drop MPTCP_PM_MAX_ADDR Geliang Tang
2020-06-15 10:29 ` Matthieu Baerts
2020-06-15 20:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).