linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] test_objagg: Fix potential memory leak in error handling
@ 2020-06-12 20:01 Aditya Pakki
  2020-06-15 20:32 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Aditya Pakki @ 2020-06-12 20:01 UTC (permalink / raw)
  To: pakki001; +Cc: kjlu, wu000273, Jiri Pirko, netdev, linux-kernel

In case of failure of check_expect_hints_stats(), the resources
allocated by objagg_hints_get should be freed. The patch fixes
this issue.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
 lib/test_objagg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/test_objagg.c b/lib/test_objagg.c
index 72c1abfa154d..da137939a410 100644
--- a/lib/test_objagg.c
+++ b/lib/test_objagg.c
@@ -979,10 +979,10 @@ static int test_hints_case(const struct hints_case *hints_case)
 err_world2_obj_get:
 	for (i--; i >= 0; i--)
 		world_obj_put(&world2, objagg, hints_case->key_ids[i]);
-	objagg_hints_put(hints);
-	objagg_destroy(objagg2);
 	i = hints_case->key_ids_count;
+	objagg_destroy(objagg2);
 err_check_expect_hints_stats:
+	objagg_hints_put(hints);
 err_hints_get:
 err_check_expect_stats:
 err_world_obj_get:
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] test_objagg: Fix potential memory leak in error handling
  2020-06-12 20:01 [PATCH] test_objagg: Fix potential memory leak in error handling Aditya Pakki
@ 2020-06-15 20:32 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-06-15 20:32 UTC (permalink / raw)
  To: pakki001; +Cc: kjlu, wu000273, jiri, netdev, linux-kernel

From: Aditya Pakki <pakki001@umn.edu>
Date: Fri, 12 Jun 2020 15:01:54 -0500

> In case of failure of check_expect_hints_stats(), the resources
> allocated by objagg_hints_get should be freed. The patch fixes
> this issue.
> 
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-15 20:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-12 20:01 [PATCH] test_objagg: Fix potential memory leak in error handling Aditya Pakki
2020-06-15 20:32 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).