* [PATCH] blk-mq: Remove redundant 'return' statement
@ 2020-06-15 9:12 Baolin Wang
2020-06-15 10:42 ` Ming Lei
2020-06-15 14:34 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Baolin Wang @ 2020-06-15 9:12 UTC (permalink / raw)
To: axboe; +Cc: ming.lei, baolin.wang, linux-block, linux-kernel
The blk_mq_all_tag_iter() is a void function, thus remove
the redundant 'return' statement in this function.
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
---
block/blk-mq-tag.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index 44f3d09..ae722f8 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -376,7 +376,7 @@ static void __blk_mq_all_tag_iter(struct blk_mq_tags *tags,
void blk_mq_all_tag_iter(struct blk_mq_tags *tags, busy_tag_iter_fn *fn,
void *priv)
{
- return __blk_mq_all_tag_iter(tags, fn, priv, BT_TAG_ITER_STATIC_RQS);
+ __blk_mq_all_tag_iter(tags, fn, priv, BT_TAG_ITER_STATIC_RQS);
}
/**
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-mq: Remove redundant 'return' statement
2020-06-15 9:12 [PATCH] blk-mq: Remove redundant 'return' statement Baolin Wang
@ 2020-06-15 10:42 ` Ming Lei
2020-06-15 14:34 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Ming Lei @ 2020-06-15 10:42 UTC (permalink / raw)
To: Baolin Wang; +Cc: axboe, linux-block, linux-kernel
On Mon, Jun 15, 2020 at 05:12:23PM +0800, Baolin Wang wrote:
> The blk_mq_all_tag_iter() is a void function, thus remove
> the redundant 'return' statement in this function.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> block/blk-mq-tag.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
> index 44f3d09..ae722f8 100644
> --- a/block/blk-mq-tag.c
> +++ b/block/blk-mq-tag.c
> @@ -376,7 +376,7 @@ static void __blk_mq_all_tag_iter(struct blk_mq_tags *tags,
> void blk_mq_all_tag_iter(struct blk_mq_tags *tags, busy_tag_iter_fn *fn,
> void *priv)
> {
> - return __blk_mq_all_tag_iter(tags, fn, priv, BT_TAG_ITER_STATIC_RQS);
> + __blk_mq_all_tag_iter(tags, fn, priv, BT_TAG_ITER_STATIC_RQS);
> }
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-mq: Remove redundant 'return' statement
2020-06-15 9:12 [PATCH] blk-mq: Remove redundant 'return' statement Baolin Wang
2020-06-15 10:42 ` Ming Lei
@ 2020-06-15 14:34 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2020-06-15 14:34 UTC (permalink / raw)
To: Baolin Wang; +Cc: ming.lei, linux-block, linux-kernel
On 6/15/20 3:12 AM, Baolin Wang wrote:
> The blk_mq_all_tag_iter() is a void function, thus remove
> the redundant 'return' statement in this function.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-15 14:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15 9:12 [PATCH] blk-mq: Remove redundant 'return' statement Baolin Wang
2020-06-15 10:42 ` Ming Lei
2020-06-15 14:34 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).