* [PATCH V2] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode
@ 2020-06-15 15:57 Drew Fustini
2020-06-16 16:12 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Drew Fustini @ 2020-06-15 15:57 UTC (permalink / raw)
To: Tony Lindgren, Rob Herring, Linux-OMAP, devicetree, linux-kernel,
Grygorii Strashko
Cc: Jason Kridner, Robert Nelson, Vinod Koul
Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for
RGMII mode") the networking is broken on the BeagleBone AI which has
the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from
phy-mode = "rgmii" to phy-mode = "rgmii-rxid".
Note: Grygorii made a similar DT fix for other AM57xx boards with a
different phy in commit 820f8a870f65 ("ARM: dts: am57xx: fix networking
on boards with ksz9031 phy").
[0] https://git.io/Jf7PX
Fixes: 520557d4854b ("ARM: dts: am5729: beaglebone-ai: adding device tree")
Cc: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Drew Fustini <drew@beagleboard.org>
---
V2:
- fix formatting of commit reference
- add Review-by: from Grygorii
arch/arm/boot/dts/am5729-beagleboneai.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts
index 9877d7709d41..4c51c6b05e64 100644
--- a/arch/arm/boot/dts/am5729-beagleboneai.dts
+++ b/arch/arm/boot/dts/am5729-beagleboneai.dts
@@ -505,7 +505,7 @@ &mac {
&cpsw_emac0 {
phy-handle = <&phy0>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-rxid";
};
&ocp {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode
2020-06-15 15:57 [PATCH V2] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode Drew Fustini
@ 2020-06-16 16:12 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2020-06-16 16:12 UTC (permalink / raw)
To: Drew Fustini
Cc: Rob Herring, Linux-OMAP, devicetree, linux-kernel,
Grygorii Strashko, Jason Kridner, Robert Nelson, Vinod Koul
* Drew Fustini <drew@beagleboard.org> [200615 08:58]:
> Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for
> RGMII mode") the networking is broken on the BeagleBone AI which has
> the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from
> phy-mode = "rgmii" to phy-mode = "rgmii-rxid".
>
> Note: Grygorii made a similar DT fix for other AM57xx boards with a
> different phy in commit 820f8a870f65 ("ARM: dts: am57xx: fix networking
> on boards with ksz9031 phy").
>
> [0] https://git.io/Jf7PX
>
> Fixes: 520557d4854b ("ARM: dts: am5729: beaglebone-ai: adding device tree")
> Cc: Vinod Koul <vkoul@kernel.org>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> V2:
> - fix formatting of commit reference
> - add Review-by: from Grygorii
Thanks applying into fixes.
Regards,
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-16 16:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15 15:57 [PATCH V2] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode Drew Fustini
2020-06-16 16:12 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).