* [PATCH] btrfs: Use kfree() in btrfs_ioctl_get_subvol_info()
@ 2020-06-16 15:31 Waiman Long
2020-06-16 17:11 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Waiman Long @ 2020-06-16 15:31 UTC (permalink / raw)
To: Chris Mason, Josef Bacik, David Sterba
Cc: linux-kernel, linux-btrfs, Waiman Long
In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc()
was incorrectly paired with kzfree(). According to David Sterba, there
isn't any sensitive information in the subvol_info that needs to be
cleared before freeing. So kzfree() isn't really needed, use kfree()
instead.
Reported-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Waiman Long <longman@redhat.com>
---
fs/btrfs/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 168deb8ef68a..e8f7c5f00894 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -2692,7 +2692,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
btrfs_put_root(root);
out_free:
btrfs_free_path(path);
- kzfree(subvol_info);
+ kfree(subvol_info);
return ret;
}
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: Use kfree() in btrfs_ioctl_get_subvol_info()
2020-06-16 15:31 [PATCH] btrfs: Use kfree() in btrfs_ioctl_get_subvol_info() Waiman Long
@ 2020-06-16 17:11 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2020-06-16 17:11 UTC (permalink / raw)
To: Waiman Long
Cc: Chris Mason, Josef Bacik, David Sterba, linux-kernel, linux-btrfs
On Tue, Jun 16, 2020 at 11:31:59AM -0400, Waiman Long wrote:
> In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc()
> was incorrectly paired with kzfree(). According to David Sterba, there
> isn't any sensitive information in the subvol_info that needs to be
> cleared before freeing. So kzfree() isn't really needed, use kfree()
> instead.
>
> Reported-by: David Sterba <dsterba@suse.cz>
> Signed-off-by: Waiman Long <longman@redhat.com>
Added to the devel patch queue, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-16 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-16 15:31 [PATCH] btrfs: Use kfree() in btrfs_ioctl_get_subvol_info() Waiman Long
2020-06-16 17:11 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).