[PATCH v3] tools build: Check libasan and libubsan in Makefile.feature

* [PATCH v3] tools build: Check libasan and libubsan in Makefile.feature
@ 2020-06-17  2:27 Tiezhu Yang
  2020-06-17 10:27 ` Jiri Olsa
  0 siblings, 1 reply; 2+ messages in thread
From: Tiezhu Yang @ 2020-06-17  2:27 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo, Peter Zijlstra, Ingo Molnar,
	Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim
  Cc: linux-kernel, Xuefeng Li, Tiezhu Yang

When build perf with ASan or UBSan, if libasan or libubsan can not find,
the feature-glibc is 0 and there exists the following error log which is
wrong, because we can find gnu/libc-version.h in /usr/include, glibc-devel
is also installed.

[yangtiezhu@linux perf]$ make DEBUG=1 EXTRA_CFLAGS='-fno-omit-frame-pointer -fsanitize=address'
  BUILD:   Doing 'make -j4' parallel build
  HOSTCC   fixdep.o
  HOSTLD   fixdep-in.o
  LINK     fixdep
<stdin>:1:0: warning: -fsanitize=address and -fsanitize=kernel-address are not supported for this target
<stdin>:1:0: warning: -fsanitize=address not supported for this target

Auto-detecting system features:
...                         dwarf: [ OFF ]
...            dwarf_getlocations: [ OFF ]
...                         glibc: [ OFF ]
...                          gtk2: [ OFF ]
...                      libaudit: [ OFF ]
...                        libbfd: [ OFF ]
...                        libcap: [ OFF ]
...                        libelf: [ OFF ]
...                       libnuma: [ OFF ]
...        numa_num_possible_cpus: [ OFF ]
...                       libperl: [ OFF ]
...                     libpython: [ OFF ]
...                     libcrypto: [ OFF ]
...                     libunwind: [ OFF ]
...            libdw-dwarf-unwind: [ OFF ]
...                          zlib: [ OFF ]
...                          lzma: [ OFF ]
...                     get_cpuid: [ OFF ]
...                           bpf: [ OFF ]
...                        libaio: [ OFF ]
...                       libzstd: [ OFF ]
...        disassembler-four-args: [ OFF ]

Makefile.config:393: *** No gnu/libc-version.h found, please install glibc-dev[el].  Stop.
Makefile.perf:224: recipe for target 'sub-make' failed
make[1]: *** [sub-make] Error 2
Makefile:69: recipe for target 'all' failed
make: *** [all] Error 2
[yangtiezhu@linux perf]$ ls /usr/include/gnu/libc-version.h
/usr/include/gnu/libc-version.h

After install libasan and libubsan, the feature-glibc is 1 and the build
process is success, so the cause is related with libasan or libubsan, we
should check them and print an error log to reflect the reality.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---

v2:
  - Check libasan and libubsan in tools/build/Makefile.feature
  - Modify the patch subject

v3:
  - Check EXTRA_CFLAGS first

 tools/build/Makefile.feature | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
index cb15237..bc28dc9 100644
--- a/tools/build/Makefile.feature
+++ b/tools/build/Makefile.feature
@@ -250,3 +250,15 @@ ifeq ($(feature_verbose),1)
   $(foreach feat,$(TMP),$(call feature_print_status,$(feat),))
   $(info )
 endif
+
+ifneq ($(filter s% -fsanitize=address%,$(EXTRA_CFLAGS),),)
+  ifneq ($(shell ldconfig -p | grep libasan >/dev/null 2>&1; echo $$?), 0)
+    msg := $(error No libasan found, please install libasan);
+  endif
+endif
+
+ifneq ($(filter s% -fsanitize=undefined%,$(EXTRA_CFLAGS),),)
+  ifneq ($(shell ldconfig -p | grep libubsan >/dev/null 2>&1; echo $$?), 0)
+    msg := $(error No libubsan found, please install libubsan);
+  endif
+endif
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread