linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* drivers/irqchip/irq-bcm7038-l1.c:312:13: error: implicit declaration of function 'cpu_logical_map'
@ 2020-06-17  9:29 kernel test robot
  0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2020-06-17  9:29 UTC (permalink / raw)
  To: Justin Chen; +Cc: kbuild-all, linux-kernel, Marc Zyngier, Florian Fainelli

[-- Attachment #1: Type: text/plain, Size: 2355 bytes --]

Hi Justin,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   69119673bd50b176ded34032fadd41530fb5af21
commit: 6468fc18b00685c82408f40e9569c0d3527862b8 irqchip/irq-bcm7038-l1: Add PM support
date:   7 months ago
config: mips-randconfig-r002-20200617 (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 6468fc18b00685c82408f40e9569c0d3527862b8
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>, old ones prefixed by <<):

drivers/irqchip/irq-bcm7038-l1.c: In function 'bcm7038_l1_suspend':
>> drivers/irqchip/irq-bcm7038-l1.c:312:13: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration]
312 |  boot_cpu = cpu_logical_map(0);
|             ^~~~~~~~~~~~~~~
drivers/irqchip/irq-bcm7038-l1.c: At top level:
drivers/irqchip/irq-bcm7038-l1.c:393:12: warning: no previous prototype for 'bcm7038_l1_of_init' [-Wmissing-prototypes]
393 | int __init bcm7038_l1_of_init(struct device_node *dn,
|            ^~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/cpu_logical_map +312 drivers/irqchip/irq-bcm7038-l1.c

   305	
   306	static int bcm7038_l1_suspend(void)
   307	{
   308		struct bcm7038_l1_chip *intc;
   309		int boot_cpu, word;
   310	
   311		/* Wakeup interrupt should only come from the boot cpu */
 > 312		boot_cpu = cpu_logical_map(0);
   313	
   314		list_for_each_entry(intc, &bcm7038_l1_intcs_list, list) {
   315			for (word = 0; word < intc->n_words; word++) {
   316				l1_writel(~intc->wake_mask[word],
   317					intc->cpus[boot_cpu]->map_base + reg_mask_set(intc, word));
   318				l1_writel(intc->wake_mask[word],
   319					intc->cpus[boot_cpu]->map_base + reg_mask_clr(intc, word));
   320			}
   321		}
   322	
   323		return 0;
   324	}
   325	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 22982 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: drivers/irqchip/irq-bcm7038-l1.c:312:13: error: implicit declaration of function 'cpu_logical_map'
  2020-07-24  4:07 kernel test robot
@ 2020-07-24  4:14 ` Florian Fainelli
  0 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2020-07-24  4:14 UTC (permalink / raw)
  To: kernel test robot, Justin Chen; +Cc: kbuild-all, linux-kernel, Marc Zyngier



On 7/23/2020 9:07 PM, kernel test robot wrote:
> Hi Justin,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   d15be546031cf65a0fc34879beca02fd90fe7ac7
> commit: 6468fc18b00685c82408f40e9569c0d3527862b8 irqchip/irq-bcm7038-l1: Add PM support
> date:   9 months ago
> config: mips-randconfig-r033-20200724 (attached as .config)
> compiler: mipsel-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 6468fc18b00685c82408f40e9569c0d3527862b8
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/irqchip/irq-bcm7038-l1.c: In function 'bcm7038_l1_suspend':
>>> drivers/irqchip/irq-bcm7038-l1.c:312:13: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration]
>      312 |  boot_cpu = cpu_logical_map(0);
>          |             ^~~~~~~~~~~~~~~
>    drivers/irqchip/irq-bcm7038-l1.c: At top level:
>    drivers/irqchip/irq-bcm7038-l1.c:393:12: warning: no previous prototype for 'bcm7038_l1_of_init' [-Wmissing-prototypes]
>      393 | int __init bcm7038_l1_of_init(struct device_node *dn,
>          |            ^~~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
> 
> vim +/cpu_logical_map +312 drivers/irqchip/irq-bcm7038-l1.c

Ah this needs to be guarded with CONFIG_SMP which this failing .config
did not enable, I will submit a fix for that first thing in the morning.
-- 
Florian

^ permalink raw reply	[flat|nested] 3+ messages in thread

* drivers/irqchip/irq-bcm7038-l1.c:312:13: error: implicit declaration of function 'cpu_logical_map'
@ 2020-07-24  4:07 kernel test robot
  2020-07-24  4:14 ` Florian Fainelli
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-07-24  4:07 UTC (permalink / raw)
  To: Justin Chen; +Cc: kbuild-all, linux-kernel, Marc Zyngier, Florian Fainelli

[-- Attachment #1: Type: text/plain, Size: 2372 bytes --]

Hi Justin,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d15be546031cf65a0fc34879beca02fd90fe7ac7
commit: 6468fc18b00685c82408f40e9569c0d3527862b8 irqchip/irq-bcm7038-l1: Add PM support
date:   9 months ago
config: mips-randconfig-r033-20200724 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 6468fc18b00685c82408f40e9569c0d3527862b8
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/irqchip/irq-bcm7038-l1.c: In function 'bcm7038_l1_suspend':
>> drivers/irqchip/irq-bcm7038-l1.c:312:13: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration]
     312 |  boot_cpu = cpu_logical_map(0);
         |             ^~~~~~~~~~~~~~~
   drivers/irqchip/irq-bcm7038-l1.c: At top level:
   drivers/irqchip/irq-bcm7038-l1.c:393:12: warning: no previous prototype for 'bcm7038_l1_of_init' [-Wmissing-prototypes]
     393 | int __init bcm7038_l1_of_init(struct device_node *dn,
         |            ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/cpu_logical_map +312 drivers/irqchip/irq-bcm7038-l1.c

   305	
   306	static int bcm7038_l1_suspend(void)
   307	{
   308		struct bcm7038_l1_chip *intc;
   309		int boot_cpu, word;
   310	
   311		/* Wakeup interrupt should only come from the boot cpu */
 > 312		boot_cpu = cpu_logical_map(0);
   313	
   314		list_for_each_entry(intc, &bcm7038_l1_intcs_list, list) {
   315			for (word = 0; word < intc->n_words; word++) {
   316				l1_writel(~intc->wake_mask[word],
   317					intc->cpus[boot_cpu]->map_base + reg_mask_set(intc, word));
   318				l1_writel(intc->wake_mask[word],
   319					intc->cpus[boot_cpu]->map_base + reg_mask_clr(intc, word));
   320			}
   321		}
   322	
   323		return 0;
   324	}
   325	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29516 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-24  4:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-17  9:29 drivers/irqchip/irq-bcm7038-l1.c:312:13: error: implicit declaration of function 'cpu_logical_map' kernel test robot
2020-07-24  4:07 kernel test robot
2020-07-24  4:14 ` Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).