* 2dd4d163cd9c ("drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()")
@ 2020-06-18 20:01 Borislav Petkov
2020-06-18 20:19 ` [Nouveau] " Ilia Mirkin
0 siblings, 1 reply; 4+ messages in thread
From: Borislav Petkov @ 2020-06-18 20:01 UTC (permalink / raw)
To: Ben Skeggs; +Cc: dri-devel, nouveau, lkml
Hi,
my test box won't boot 5.8-rc1 all the way but stops at
...
fb0: switching to nouveaufb from EFI VGA
<-- EOF
I've bisected it to the commit in $Subject, see below. Unfortunately, it
doesn't revert cleanly so I can't really do the final test of reverting
it ontop of 5.8-rc1 to confirm that this one is really causing it.
Any ideas?
GPU is:
[ 5.678614] fb0: switching to nouveaufb from EFI VGA
[ 5.685577] Console: switching to colour dummy device 80x25
[ 5.691865] nouveau 0000:03:00.0: NVIDIA GT218 (0a8c00b1)
[ 5.814409] nouveau 0000:03:00.0: bios: version 70.18.83.00.08
[ 5.823559] nouveau 0000:03:00.0: fb: 512 MiB DDR3
[ 6.096680] [TTM] Zone kernel: Available graphics memory: 8158364 KiB
[ 6.103327] [TTM] Zone dma32: Available graphics memory: 2097152 KiB
[ 6.109951] [TTM] Initializing pool allocator
[ 6.114405] [TTM] Initializing DMA pool allocator
[ 6.119256] nouveau 0000:03:00.0: DRM: VRAM: 512 MiB
[ 6.124285] nouveau 0000:03:00.0: DRM: GART: 1048576 MiB
[ 6.129677] nouveau 0000:03:00.0: DRM: TMDS table version 2.0
[ 6.135534] nouveau 0000:03:00.0: DRM: DCB version 4.0
[ 6.140755] nouveau 0000:03:00.0: DRM: DCB outp 00: 02000360 00000000
[ 6.147273] nouveau 0000:03:00.0: DRM: DCB outp 01: 02000362 00020010
[ 6.153782] nouveau 0000:03:00.0: DRM: DCB outp 02: 028003a6 0f220010
[ 6.160292] nouveau 0000:03:00.0: DRM: DCB outp 03: 01011380 00000000
[ 6.166810] nouveau 0000:03:00.0: DRM: DCB outp 04: 08011382 00020010
[ 6.173306] nouveau 0000:03:00.0: DRM: DCB outp 05: 088113c6 0f220010
[ 6.179829] nouveau 0000:03:00.0: DRM: DCB conn 00: 00101064
[ 6.185553] nouveau 0000:03:00.0: DRM: DCB conn 01: 00202165
[ 6.196145] nouveau 0000:03:00.0: DRM: MM: using COPY for buffer copies
[ 6.233659] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
[ 6.311939] nouveau 0000:03:00.0: DRM: allocated 1920x1080 fb: 0x70000, bo (____ptrval____)
[ 6.320736] fbcon: nouveaudrmfb (fb0) is primary device
[ 6.392722] tsc: Refined TSC clocksource calibration: 3591.346 MHz
[ 6.392788] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x33c46403b59, max_idle_ns: 440795293818 ns
[ 6.392930] clocksource: Switched to clocksource tsc
[ 6.509946] Console: switching to colour frame buffer device 240x67
[ 6.546287] nouveau 0000:03:00.0: fb0: nouveaudrmfb frame buffer device
[ 6.555021] [drm] Initialized nouveau 1.3.1 20120801 for 0000:03:00.0 on minor 0
Thx.
git bisect start
# good: [3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162] Linux 5.7
git bisect good 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
# bad: [b3a9e3b9622ae10064826dccb4f7a52bd88c7407] Linux 5.8-rc1
git bisect bad b3a9e3b9622ae10064826dccb4f7a52bd88c7407
# bad: [ee01c4d72adffb7d424535adf630f2955748fa8b] Merge branch 'akpm' (patches from Andrew)
git bisect bad ee01c4d72adffb7d424535adf630f2955748fa8b
# bad: [16d91548d1057691979de4686693f0ff92f46000] Merge tag 'xfs-5.8-merge-8' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
git bisect bad 16d91548d1057691979de4686693f0ff92f46000
# good: [cfa3b8068b09f25037146bfd5eed041b78878bee] Merge tag 'for-linus-hmm' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma
git bisect good cfa3b8068b09f25037146bfd5eed041b78878bee
# good: [3fd911b69b3117e03181262fc19ae6c3ef6962ce] Merge tag 'drm-misc-next-2020-05-07' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
git bisect good 3fd911b69b3117e03181262fc19ae6c3ef6962ce
# bad: [1966391fa576e1fb2701be8bcca197d8f72737b7] mm/migrate.c: attach_page_private already does the get_page
git bisect bad 1966391fa576e1fb2701be8bcca197d8f72737b7
# good: [43c8546bcd854806736d8a635a0d696504dd4c21] drm/amdgpu: Add a UAPI flag for user to call mem_sync
git bisect good 43c8546bcd854806736d8a635a0d696504dd4c21
# good: [6cf991611bc72c077f0cc64e23987341ad7ef41e] Merge tag 'drm-intel-next-2020-05-15' of git://anongit.freedesktop.org/drm/drm-intel into drm-next
git bisect good 6cf991611bc72c077f0cc64e23987341ad7ef41e
# bad: [dc455f4c888365595c0a13da445e092422d55b8d] drm/nouveau/dispnv50: fix runtime pm imbalance on error
git bisect bad dc455f4c888365595c0a13da445e092422d55b8d
# bad: [2dd4d163cd9c15432524aa9863155bc03a821361] drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()
git bisect bad 2dd4d163cd9c15432524aa9863155bc03a821361
# good: [c41219fda6e04255c44d37fd2c0d898c1c46abf1] Merge tag 'drm-intel-next-fixes-2020-05-20' of git://anongit.freedesktop.org/drm/drm-intel into drm-next
git bisect good c41219fda6e04255c44d37fd2c0d898c1c46abf1
# good: [fd44028ff145ffb2d03c877d74f479da04ac2c62] drm/nouveau/acr: ensure falcon providing acr functions is bootstrapped first
git bisect good fd44028ff145ffb2d03c877d74f479da04ac2c62
# good: [fa4f4c213f5f7807360c41f2501a3031a9940f3a] drm/nouveau/kms: Support NVIDIA format modifiers
git bisect good fa4f4c213f5f7807360c41f2501a3031a9940f3a
# good: [d2bcfce7f8a4ba8df28d3bebb81225bd7f9c046f] drm/nouveau/ibus: use nvkm_subdev_new_()
git bisect good d2bcfce7f8a4ba8df28d3bebb81225bd7f9c046f
# good: [fb172f5fe880cd0ddb4370b2fcc9ad4848c98bbb] drm/nouveau/gr/gk20a: move MODULE_FIRMWARE firmware definitions
git bisect good fb172f5fe880cd0ddb4370b2fcc9ad4848c98bbb
# first bad commit: [2dd4d163cd9c15432524aa9863155bc03a821361] drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Nouveau] 2dd4d163cd9c ("drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()")
2020-06-18 20:01 2dd4d163cd9c ("drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()") Borislav Petkov
@ 2020-06-18 20:19 ` Ilia Mirkin
2020-06-18 20:39 ` Borislav Petkov
0 siblings, 1 reply; 4+ messages in thread
From: Ilia Mirkin @ 2020-06-18 20:19 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Ben Skeggs, nouveau, lkml, dri-devel
Hi Boris,
There was a fixup to that patch that you'll also have to revert first
-- 7dbbdd37f2ae7dd4175ba3f86f4335c463b18403. I guess there's some
subtle difference between the old open-coded logic and the helper,
they were supposed to be identical.
Cheers,
-ilia
On Thu, Jun 18, 2020 at 4:09 PM Borislav Petkov <bp@alien8.de> wrote:
>
> Hi,
>
> my test box won't boot 5.8-rc1 all the way but stops at
>
> ...
> fb0: switching to nouveaufb from EFI VGA
> <-- EOF
>
> I've bisected it to the commit in $Subject, see below. Unfortunately, it
> doesn't revert cleanly so I can't really do the final test of reverting
> it ontop of 5.8-rc1 to confirm that this one is really causing it.
>
> Any ideas?
>
> GPU is:
>
> [ 5.678614] fb0: switching to nouveaufb from EFI VGA
> [ 5.685577] Console: switching to colour dummy device 80x25
> [ 5.691865] nouveau 0000:03:00.0: NVIDIA GT218 (0a8c00b1)
> [ 5.814409] nouveau 0000:03:00.0: bios: version 70.18.83.00.08
> [ 5.823559] nouveau 0000:03:00.0: fb: 512 MiB DDR3
> [ 6.096680] [TTM] Zone kernel: Available graphics memory: 8158364 KiB
> [ 6.103327] [TTM] Zone dma32: Available graphics memory: 2097152 KiB
> [ 6.109951] [TTM] Initializing pool allocator
> [ 6.114405] [TTM] Initializing DMA pool allocator
> [ 6.119256] nouveau 0000:03:00.0: DRM: VRAM: 512 MiB
> [ 6.124285] nouveau 0000:03:00.0: DRM: GART: 1048576 MiB
> [ 6.129677] nouveau 0000:03:00.0: DRM: TMDS table version 2.0
> [ 6.135534] nouveau 0000:03:00.0: DRM: DCB version 4.0
> [ 6.140755] nouveau 0000:03:00.0: DRM: DCB outp 00: 02000360 00000000
> [ 6.147273] nouveau 0000:03:00.0: DRM: DCB outp 01: 02000362 00020010
> [ 6.153782] nouveau 0000:03:00.0: DRM: DCB outp 02: 028003a6 0f220010
> [ 6.160292] nouveau 0000:03:00.0: DRM: DCB outp 03: 01011380 00000000
> [ 6.166810] nouveau 0000:03:00.0: DRM: DCB outp 04: 08011382 00020010
> [ 6.173306] nouveau 0000:03:00.0: DRM: DCB outp 05: 088113c6 0f220010
> [ 6.179829] nouveau 0000:03:00.0: DRM: DCB conn 00: 00101064
> [ 6.185553] nouveau 0000:03:00.0: DRM: DCB conn 01: 00202165
> [ 6.196145] nouveau 0000:03:00.0: DRM: MM: using COPY for buffer copies
> [ 6.233659] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
> [ 6.311939] nouveau 0000:03:00.0: DRM: allocated 1920x1080 fb: 0x70000, bo (____ptrval____)
> [ 6.320736] fbcon: nouveaudrmfb (fb0) is primary device
> [ 6.392722] tsc: Refined TSC clocksource calibration: 3591.346 MHz
> [ 6.392788] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x33c46403b59, max_idle_ns: 440795293818 ns
> [ 6.392930] clocksource: Switched to clocksource tsc
> [ 6.509946] Console: switching to colour frame buffer device 240x67
> [ 6.546287] nouveau 0000:03:00.0: fb0: nouveaudrmfb frame buffer device
> [ 6.555021] [drm] Initialized nouveau 1.3.1 20120801 for 0000:03:00.0 on minor 0
>
> Thx.
>
> git bisect start
> # good: [3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162] Linux 5.7
> git bisect good 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
> # bad: [b3a9e3b9622ae10064826dccb4f7a52bd88c7407] Linux 5.8-rc1
> git bisect bad b3a9e3b9622ae10064826dccb4f7a52bd88c7407
> # bad: [ee01c4d72adffb7d424535adf630f2955748fa8b] Merge branch 'akpm' (patches from Andrew)
> git bisect bad ee01c4d72adffb7d424535adf630f2955748fa8b
> # bad: [16d91548d1057691979de4686693f0ff92f46000] Merge tag 'xfs-5.8-merge-8' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
> git bisect bad 16d91548d1057691979de4686693f0ff92f46000
> # good: [cfa3b8068b09f25037146bfd5eed041b78878bee] Merge tag 'for-linus-hmm' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma
> git bisect good cfa3b8068b09f25037146bfd5eed041b78878bee
> # good: [3fd911b69b3117e03181262fc19ae6c3ef6962ce] Merge tag 'drm-misc-next-2020-05-07' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
> git bisect good 3fd911b69b3117e03181262fc19ae6c3ef6962ce
> # bad: [1966391fa576e1fb2701be8bcca197d8f72737b7] mm/migrate.c: attach_page_private already does the get_page
> git bisect bad 1966391fa576e1fb2701be8bcca197d8f72737b7
> # good: [43c8546bcd854806736d8a635a0d696504dd4c21] drm/amdgpu: Add a UAPI flag for user to call mem_sync
> git bisect good 43c8546bcd854806736d8a635a0d696504dd4c21
> # good: [6cf991611bc72c077f0cc64e23987341ad7ef41e] Merge tag 'drm-intel-next-2020-05-15' of git://anongit.freedesktop.org/drm/drm-intel into drm-next
> git bisect good 6cf991611bc72c077f0cc64e23987341ad7ef41e
> # bad: [dc455f4c888365595c0a13da445e092422d55b8d] drm/nouveau/dispnv50: fix runtime pm imbalance on error
> git bisect bad dc455f4c888365595c0a13da445e092422d55b8d
> # bad: [2dd4d163cd9c15432524aa9863155bc03a821361] drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()
> git bisect bad 2dd4d163cd9c15432524aa9863155bc03a821361
> # good: [c41219fda6e04255c44d37fd2c0d898c1c46abf1] Merge tag 'drm-intel-next-fixes-2020-05-20' of git://anongit.freedesktop.org/drm/drm-intel into drm-next
> git bisect good c41219fda6e04255c44d37fd2c0d898c1c46abf1
> # good: [fd44028ff145ffb2d03c877d74f479da04ac2c62] drm/nouveau/acr: ensure falcon providing acr functions is bootstrapped first
> git bisect good fd44028ff145ffb2d03c877d74f479da04ac2c62
> # good: [fa4f4c213f5f7807360c41f2501a3031a9940f3a] drm/nouveau/kms: Support NVIDIA format modifiers
> git bisect good fa4f4c213f5f7807360c41f2501a3031a9940f3a
> # good: [d2bcfce7f8a4ba8df28d3bebb81225bd7f9c046f] drm/nouveau/ibus: use nvkm_subdev_new_()
> git bisect good d2bcfce7f8a4ba8df28d3bebb81225bd7f9c046f
> # good: [fb172f5fe880cd0ddb4370b2fcc9ad4848c98bbb] drm/nouveau/gr/gk20a: move MODULE_FIRMWARE firmware definitions
> git bisect good fb172f5fe880cd0ddb4370b2fcc9ad4848c98bbb
> # first bad commit: [2dd4d163cd9c15432524aa9863155bc03a821361] drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()
>
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Nouveau] 2dd4d163cd9c ("drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()")
2020-06-18 20:19 ` [Nouveau] " Ilia Mirkin
@ 2020-06-18 20:39 ` Borislav Petkov
2020-06-19 13:34 ` Borislav Petkov
0 siblings, 1 reply; 4+ messages in thread
From: Borislav Petkov @ 2020-06-18 20:39 UTC (permalink / raw)
To: Ilia Mirkin; +Cc: Ben Skeggs, nouveau, lkml, dri-devel
Hi,
On Thu, Jun 18, 2020 at 04:19:02PM -0400, Ilia Mirkin wrote:
> Hi Boris,
>
> There was a fixup to that patch that you'll also have to revert first
> -- 7dbbdd37f2ae7dd4175ba3f86f4335c463b18403. I guess there's some
> subtle difference between the old open-coded logic and the helper,
> they were supposed to be identical.
Thanks, that's a good point. I reverted both but it still hangs. So
either my bisection is wrong or reverting those two is not enough due to
other changes.
I'll redo the bisection tomorrow, on a fresh head, to check.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Nouveau] 2dd4d163cd9c ("drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()")
2020-06-18 20:39 ` Borislav Petkov
@ 2020-06-19 13:34 ` Borislav Petkov
0 siblings, 0 replies; 4+ messages in thread
From: Borislav Petkov @ 2020-06-19 13:34 UTC (permalink / raw)
To: Ilia Mirkin; +Cc: Ben Skeggs, nouveau, lkml, dri-devel
On Thu, Jun 18, 2020 at 10:39:07PM +0200, Borislav Petkov wrote:
> I'll redo the bisection tomorrow, on a fresh head, to check.
Ok, just did it again, similar bisection log, points at the same commit.
The commit before it:
fb172f5fe880 ("drm/nouveau/gr/gk20a: move MODULE_FIRMWARE firmware definitions")
boots ok but
2dd4d163cd9c ("drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()")
doesn't.
Ideas?
git bisect start
# good: [3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162] Linux 5.7
git bisect good 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162
# bad: [5e857ce6eae7ca21b2055cca4885545e29228fe2] Merge branch 'hch' (maccess patches from Christoph Hellwig)
git bisect bad 5e857ce6eae7ca21b2055cca4885545e29228fe2
# bad: [a98f670e41a99f53acb1fb33cee9c6abbb2e6f23] Merge tag 'media/v5.8-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
git bisect bad a98f670e41a99f53acb1fb33cee9c6abbb2e6f23
# bad: [5be993432821750f382809df5e20bf4c129b24f7] mm/hugetlb: define a generic fallback for arch_clear_hugepage_flags()
git bisect bad 5be993432821750f382809df5e20bf4c129b24f7
# good: [cfa3b8068b09f25037146bfd5eed041b78878bee] Merge tag 'for-linus-hmm' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma
git bisect good cfa3b8068b09f25037146bfd5eed041b78878bee
# good: [a1fb548962397bb8609bb46e566809a9a1b30044] Merge tag 'drm-intel-next-2020-04-30' of git://anongit.freedesktop.org/drm/drm-intel into drm-next
git bisect good a1fb548962397bb8609bb46e566809a9a1b30044
# bad: [750a02ab8d3c49ca7d23102be90d3d1db19e2827] Merge tag 'for-5.8/block-2020-06-01' of git://git.kernel.dk/linux-block
git bisect bad 750a02ab8d3c49ca7d23102be90d3d1db19e2827
# good: [e20bb857dea2f620ff37ae541ed8aee70e3c89f1] Merge tag 'exynos-drm-next-for-v5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-next
git bisect good e20bb857dea2f620ff37ae541ed8aee70e3c89f1
# good: [e6e7abffe386b614a194ec32457a00c304c980f4] blk-mq: simplify the blk_mq_get_request calling convention
git bisect good e6e7abffe386b614a194ec32457a00c304c980f4
# bad: [7dbbdd37f2ae7dd4175ba3f86f4335c463b18403] drm/nouveau: use correct conflicting framebuffer API
git bisect bad 7dbbdd37f2ae7dd4175ba3f86f4335c463b18403
# bad: [0f85bbb6ae517d9a4308527188afe35c2012bbc9] drm/nouveau/device: use regular PRI accessors in chipset detection
git bisect bad 0f85bbb6ae517d9a4308527188afe35c2012bbc9
# good: [fa4f4c213f5f7807360c41f2501a3031a9940f3a] drm/nouveau/kms: Support NVIDIA format modifiers
git bisect good fa4f4c213f5f7807360c41f2501a3031a9940f3a
# bad: [e3d8b08904694e9ccae5163d0bb7d35fa66e5bdc] drm/nouveau/svm: map pages after migration
git bisect bad e3d8b08904694e9ccae5163d0bb7d35fa66e5bdc
# good: [fb172f5fe880cd0ddb4370b2fcc9ad4848c98bbb] drm/nouveau/gr/gk20a: move MODULE_FIRMWARE firmware definitions
git bisect good fb172f5fe880cd0ddb4370b2fcc9ad4848c98bbb
# bad: [b950c8c5d082d822b0134d1fc058101ab346e503] drm/nouveau/bios: move ACPI _ROM handling
git bisect bad b950c8c5d082d822b0134d1fc058101ab346e503
# bad: [2dd4d163cd9c15432524aa9863155bc03a821361] drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()
git bisect bad 2dd4d163cd9c15432524aa9863155bc03a821361
# first bad commit: [2dd4d163cd9c15432524aa9863155bc03a821361] drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-19 13:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-18 20:01 2dd4d163cd9c ("drm/nouveau: remove open-coded version of remove_conflicting_pci_framebuffers()") Borislav Petkov
2020-06-18 20:19 ` [Nouveau] " Ilia Mirkin
2020-06-18 20:39 ` Borislav Petkov
2020-06-19 13:34 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).