* [PATCH] docs: mm/gup: Minor documentation update
@ 2020-06-17 19:27 Souptick Joarder
2020-06-19 7:22 ` John Hubbard
2020-06-19 19:26 ` Jonathan Corbet
0 siblings, 2 replies; 3+ messages in thread
From: Souptick Joarder @ 2020-06-17 19:27 UTC (permalink / raw)
To: corbet, akpm, jack, kirill.shutemov
Cc: linux-doc, linux-kernel, Souptick Joarder, John Hubbard
Now there are 5 cases. Updated the same.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Cc: John Hubbard <jhubbard@nvidia.com>
---
Documentation/core-api/pin_user_pages.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/core-api/pin_user_pages.rst b/Documentation/core-api/pin_user_pages.rst
index 6068266..7ca8c7b 100644
--- a/Documentation/core-api/pin_user_pages.rst
+++ b/Documentation/core-api/pin_user_pages.rst
@@ -33,7 +33,7 @@ all combinations of get*(), pin*(), FOLL_LONGTERM, and more. Also, the
pin_user_pages*() APIs are clearly distinct from the get_user_pages*() APIs, so
that's a natural dividing line, and a good point to make separate wrapper calls.
In other words, use pin_user_pages*() for DMA-pinned pages, and
-get_user_pages*() for other cases. There are four cases described later on in
+get_user_pages*() for other cases. There are five cases described later on in
this document, to further clarify that concept.
FOLL_PIN and FOLL_GET are mutually exclusive for a given gup call. However,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: mm/gup: Minor documentation update
2020-06-17 19:27 [PATCH] docs: mm/gup: Minor documentation update Souptick Joarder
@ 2020-06-19 7:22 ` John Hubbard
2020-06-19 19:26 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: John Hubbard @ 2020-06-19 7:22 UTC (permalink / raw)
To: Souptick Joarder, corbet, akpm, jack, kirill.shutemov
Cc: linux-doc, linux-kernel
On 2020-06-17 12:27, Souptick Joarder wrote:
> Now there are 5 cases. Updated the same.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Cc: John Hubbard <jhubbard@nvidia.com>
> ---
> Documentation/core-api/pin_user_pages.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/core-api/pin_user_pages.rst b/Documentation/core-api/pin_user_pages.rst
> index 6068266..7ca8c7b 100644
> --- a/Documentation/core-api/pin_user_pages.rst
> +++ b/Documentation/core-api/pin_user_pages.rst
> @@ -33,7 +33,7 @@ all combinations of get*(), pin*(), FOLL_LONGTERM, and more. Also, the
> pin_user_pages*() APIs are clearly distinct from the get_user_pages*() APIs, so
> that's a natural dividing line, and a good point to make separate wrapper calls.
> In other words, use pin_user_pages*() for DMA-pinned pages, and
> -get_user_pages*() for other cases. There are four cases described later on in
> +get_user_pages*() for other cases. There are five cases described later on in
Probably better to just say "several" instead of "five", but either way is fine.
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
thanks,
--
John Hubbard
NVIDIA
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: mm/gup: Minor documentation update
2020-06-17 19:27 [PATCH] docs: mm/gup: Minor documentation update Souptick Joarder
2020-06-19 7:22 ` John Hubbard
@ 2020-06-19 19:26 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2020-06-19 19:26 UTC (permalink / raw)
To: Souptick Joarder
Cc: akpm, jack, kirill.shutemov, linux-doc, linux-kernel, John Hubbard
On Thu, 18 Jun 2020 00:57:03 +0530
Souptick Joarder <jrdr.linux@gmail.com> wrote:
> Now there are 5 cases. Updated the same.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Cc: John Hubbard <jhubbard@nvidia.com>
> ---
> Documentation/core-api/pin_user_pages.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/core-api/pin_user_pages.rst b/Documentation/core-api/pin_user_pages.rst
> index 6068266..7ca8c7b 100644
> --- a/Documentation/core-api/pin_user_pages.rst
> +++ b/Documentation/core-api/pin_user_pages.rst
> @@ -33,7 +33,7 @@ all combinations of get*(), pin*(), FOLL_LONGTERM, and more. Also, the
> pin_user_pages*() APIs are clearly distinct from the get_user_pages*() APIs, so
> that's a natural dividing line, and a good point to make separate wrapper calls.
> In other words, use pin_user_pages*() for DMA-pinned pages, and
> -get_user_pages*() for other cases. There are four cases described later on in
> +get_user_pages*() for other cases. There are five cases described later on in
> this document, to further clarify that concept.
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-19 19:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-17 19:27 [PATCH] docs: mm/gup: Minor documentation update Souptick Joarder
2020-06-19 7:22 ` John Hubbard
2020-06-19 19:26 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).