* [PATCH] drm/panel: otm8009a: Drop unnessary backlight_device_unregister()
@ 2020-06-18 13:46 Wei Yongjun
2020-06-20 11:20 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-06-18 13:46 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
Philippe CORNU
Cc: Wei Yongjun, dri-devel, linux-kernel, kernel-janitors, Hulk Robot
It's not necessary to unregister backlight device which
registered with devm_backlight_device_register().
Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
index 895ee3d1371e..d956522f32ee 100644
--- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
+++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
@@ -479,7 +479,6 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
if (ret < 0) {
dev_err(dev, "mipi_dsi_attach failed. Is host ready?\n");
drm_panel_remove(&ctx->panel);
- backlight_device_unregister(ctx->bl_dev);
return ret;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/panel: otm8009a: Drop unnessary backlight_device_unregister()
2020-06-18 13:46 [PATCH] drm/panel: otm8009a: Drop unnessary backlight_device_unregister() Wei Yongjun
@ 2020-06-20 11:20 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2020-06-20 11:20 UTC (permalink / raw)
To: Wei Yongjun
Cc: Thierry Reding, David Airlie, Daniel Vetter, Philippe CORNU,
kernel-janitors, linux-kernel, dri-devel, Hulk Robot
Hi Wei.
On Thu, Jun 18, 2020 at 01:46:50PM +0000, Wei Yongjun wrote:
> It's not necessary to unregister backlight device which
> registered with devm_backlight_device_register().
>
> Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks, pushed to drm-misc-next.
Sam
> ---
> drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> index 895ee3d1371e..d956522f32ee 100644
> --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> @@ -479,7 +479,6 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
> if (ret < 0) {
> dev_err(dev, "mipi_dsi_attach failed. Is host ready?\n");
> drm_panel_remove(&ctx->panel);
> - backlight_device_unregister(ctx->bl_dev);
> return ret;
> }
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-20 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-18 13:46 [PATCH] drm/panel: otm8009a: Drop unnessary backlight_device_unregister() Wei Yongjun
2020-06-20 11:20 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).