linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] scsi: ufs: allow exynos ufs driver to build as module
       [not found] <CGME20200620175104epcas5p25068bb07029c9d6aff56623e4ecb0a26@epcas5p2.samsung.com>
@ 2020-06-20 17:32 ` Alim Akhtar
  2020-06-24  4:30   ` Martin K. Petersen
  2020-06-25  5:48   ` Avri Altman
  0 siblings, 2 replies; 3+ messages in thread
From: Alim Akhtar @ 2020-06-20 17:32 UTC (permalink / raw)
  To: linux-scsi
  Cc: avri.altman, martin.petersen, kwmad.kim, stanley.chu, cang,
	linux-kernel, jejb, Alim Akhtar

Allow Exynos UFS driver to build as a module.
This patch fix the below build issue reported by
kernel build robot.

drivers/scsi/ufs/ufs-exynos.o: in function `exynos_ufs_probe':
drivers/scsi/ufs/ufs-exynos.c:1231: undefined reference to `ufshcd_pltfrm_init'
drivers/scsi/ufs/ufs-exynos.o: in function `exynos_ufs_pre_pwr_mode':
drivers/scsi/ufs/ufs-exynos.c:635: undefined reference to `ufshcd_get_pwr_dev_param'
drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_shutdown'
drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_suspend'
drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_resume'
drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_runtime_suspend'
drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_runtime_resume'
drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_runtime_idle'

Fixes: 55f4b1f73631 ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos SoCs")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
 drivers/scsi/ufs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index 8cd90262784d..3188a50dfb51 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers/scsi/ufs/Kconfig
@@ -162,7 +162,7 @@ config SCSI_UFS_BSG
 	  If unsure, say N.
 
 config SCSI_UFS_EXYNOS
-	bool "EXYNOS specific hooks to UFS controller platform driver"
+	tristate "EXYNOS specific hooks to UFS controller platform driver"
 	depends on SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS || COMPILE_TEST)
 	select PHY_SAMSUNG_UFS
 	help

base-commit: ce2cc8efd7a40cbd17841add878cb691d0ce0bba
prerequisite-patch-id: c12207f678b32e29496ec7e324425c8f49422a2c
prerequisite-patch-id: 8263330366e8c180c0ab9f76fbd4dbbcf0bee427
prerequisite-patch-id: 7456972c04fc1a76c922196aecd98e9ed17cc6eb
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] scsi: ufs: allow exynos ufs driver to build as module
  2020-06-20 17:32 ` [PATCH -next] scsi: ufs: allow exynos ufs driver to build as module Alim Akhtar
@ 2020-06-24  4:30   ` Martin K. Petersen
  2020-06-25  5:48   ` Avri Altman
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-06-24  4:30 UTC (permalink / raw)
  To: linux-scsi, Alim Akhtar
  Cc: Martin K . Petersen, linux-kernel, cang, stanley.chu, kwmad.kim,
	avri.altman, jejb

On Sat, 20 Jun 2020 23:02:32 +0530, Alim Akhtar wrote:

> Allow Exynos UFS driver to build as a module.
> This patch fix the below build issue reported by
> kernel build robot.
> 
> drivers/scsi/ufs/ufs-exynos.o: in function `exynos_ufs_probe':
> drivers/scsi/ufs/ufs-exynos.c:1231: undefined reference to `ufshcd_pltfrm_init'
> drivers/scsi/ufs/ufs-exynos.o: in function `exynos_ufs_pre_pwr_mode':
> drivers/scsi/ufs/ufs-exynos.c:635: undefined reference to `ufshcd_get_pwr_dev_param'
> drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_shutdown'
> drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_suspend'
> drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_resume'
> drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_runtime_suspend'
> drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_runtime_resume'
> drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_runtime_idle'

Applied to 5.9/scsi-queue, thanks!

[1/1] scsi: ufs: Allow exynos ufs driver to build as module
      https://git.kernel.org/mkp/scsi/c/d31503fe395d

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH -next] scsi: ufs: allow exynos ufs driver to build as module
  2020-06-20 17:32 ` [PATCH -next] scsi: ufs: allow exynos ufs driver to build as module Alim Akhtar
  2020-06-24  4:30   ` Martin K. Petersen
@ 2020-06-25  5:48   ` Avri Altman
  1 sibling, 0 replies; 3+ messages in thread
From: Avri Altman @ 2020-06-25  5:48 UTC (permalink / raw)
  To: Alim Akhtar, linux-scsi
  Cc: martin.petersen, kwmad.kim, stanley.chu, cang, linux-kernel, jejb

 
> 
> Allow Exynos UFS driver to build as a module.
> This patch fix the below build issue reported by
> kernel build robot.
> 
> drivers/scsi/ufs/ufs-exynos.o: in function `exynos_ufs_probe':
> drivers/scsi/ufs/ufs-exynos.c:1231: undefined reference to `ufshcd_pltfrm_init'
> drivers/scsi/ufs/ufs-exynos.o: in function `exynos_ufs_pre_pwr_mode':
> drivers/scsi/ufs/ufs-exynos.c:635: undefined reference to
> `ufshcd_get_pwr_dev_param'
> drivers/scsi/ufs/ufs-exynos.o:undefined reference to
> `ufshcd_pltfrm_shutdown'
> drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_suspend'
> drivers/scsi/ufs/ufs-exynos.o:undefined reference to `ufshcd_pltfrm_resume'
> drivers/scsi/ufs/ufs-exynos.o:undefined reference to
> `ufshcd_pltfrm_runtime_suspend'
> drivers/scsi/ufs/ufs-exynos.o:undefined reference to
> `ufshcd_pltfrm_runtime_resume'
> drivers/scsi/ufs/ufs-exynos.o:undefined reference to
> `ufshcd_pltfrm_runtime_idle'
> 
> Fixes: 55f4b1f73631 ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos
> SoCs")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-25  5:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20200620175104epcas5p25068bb07029c9d6aff56623e4ecb0a26@epcas5p2.samsung.com>
2020-06-20 17:32 ` [PATCH -next] scsi: ufs: allow exynos ufs driver to build as module Alim Akhtar
2020-06-24  4:30   ` Martin K. Petersen
2020-06-25  5:48   ` Avri Altman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).