linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix check in ethtool_rx_flow_rule_create
@ 2020-06-21 15:30 Gaurav Singh
  2020-06-23  3:49 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Gaurav Singh @ 2020-06-21 15:30 UTC (permalink / raw)
  To: gaurav1086, David S. Miller, Jakub Kicinski, Michal Kubecek,
	Florian Fainelli, Andrew Lunn, Leon Romanovsky,
	open list:NETWORKING [GENERAL],
	open list

Fix check in ethtool_rx_flow_rule_create

Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
---
 net/ethtool/ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
index b5df90c981c2..21d5fc0f6bb3 100644
--- a/net/ethtool/ioctl.c
+++ b/net/ethtool/ioctl.c
@@ -2978,7 +2978,7 @@ ethtool_rx_flow_rule_create(const struct ethtool_rx_flow_spec_input *input)
 			       sizeof(match->mask.ipv6.dst));
 		}
 		if (memcmp(v6_m_spec->ip6src, &zero_addr, sizeof(zero_addr)) ||
-		    memcmp(v6_m_spec->ip6src, &zero_addr, sizeof(zero_addr))) {
+		    memcmp(v6_m_spec->ip6dst, &zero_addr, sizeof(zero_addr))) {
 			match->dissector.used_keys |=
 				BIT(FLOW_DISSECTOR_KEY_IPV6_ADDRS);
 			match->dissector.offset[FLOW_DISSECTOR_KEY_IPV6_ADDRS] =
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix check in ethtool_rx_flow_rule_create
  2020-06-21 15:30 [PATCH] Fix check in ethtool_rx_flow_rule_create Gaurav Singh
@ 2020-06-23  3:49 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-06-23  3:49 UTC (permalink / raw)
  To: gaurav1086; +Cc: kuba, mkubecek, f.fainelli, andrew, leon, netdev, linux-kernel

From: Gaurav Singh <gaurav1086@gmail.com>
Date: Sun, 21 Jun 2020 11:30:17 -0400

> Fix check in ethtool_rx_flow_rule_create
> 
> Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>

Applied and queued up for -stable with the following Fixes: tag added:

Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator")

Thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-23  3:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-21 15:30 [PATCH] Fix check in ethtool_rx_flow_rule_create Gaurav Singh
2020-06-23  3:49 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).