* [PATCH 2/2] xfs: Couple of typo fixes in comments
@ 2020-06-07 7:39 Keyur Patel
2020-06-07 7:44 ` [PATCH] " Keyur Patel
0 siblings, 1 reply; 3+ messages in thread
From: Keyur Patel @ 2020-06-07 7:39 UTC (permalink / raw)
Cc: Keyur Patel, Darrick J. Wong, linux-xfs, Brian Foster,
Chandan Babu R, Dave Chinner, Allison Collins, linux-kernel
./xfs/libxfs/xfs_inode_buf.c:56: unnecssary ==> unnecessary
./xfs/libxfs/xfs_inode_buf.c:59: behavour ==> behaviour
./xfs/libxfs/xfs_inode_buf.c:206: unitialized ==> uninitialized
Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
---
fs/xfs/libxfs/xfs_inode_buf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
index 6f84ea85fdd8..5c93e8e6de74 100644
--- a/fs/xfs/libxfs/xfs_inode_buf.c
+++ b/fs/xfs/libxfs/xfs_inode_buf.c
@@ -53,10 +53,10 @@ xfs_inobp_check(
* If the readahead buffer is invalid, we need to mark it with an error and
* clear the DONE status of the buffer so that a followup read will re-read it
* from disk. We don't report the error otherwise to avoid warnings during log
- * recovery and we don't get unnecssary panics on debug kernels. We use EIO here
+ * recovery and we don't get unnecessary panics on debug kernels. We use EIO here
* because all we want to do is say readahead failed; there is no-one to report
* the error to, so this will distinguish it from a non-ra verifier failure.
- * Changes to this readahead error behavour also need to be reflected in
+ * Changes to this readahead error behaviour also need to be reflected in
* xfs_dquot_buf_readahead_verify().
*/
static void
@@ -203,7 +203,7 @@ xfs_inode_from_disk(
/*
* First get the permanent information that is needed to allocate an
* inode. If the inode is unused, mode is zero and we shouldn't mess
- * with the unitialized part of it.
+ * with the uninitialized part of it.
*/
to->di_flushiter = be16_to_cpu(from->di_flushiter);
inode->i_generation = be32_to_cpu(from->di_gen);
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] xfs: Couple of typo fixes in comments
2020-06-07 7:39 [PATCH 2/2] xfs: Couple of typo fixes in comments Keyur Patel
@ 2020-06-07 7:44 ` Keyur Patel
2020-06-22 17:29 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Keyur Patel @ 2020-06-07 7:44 UTC (permalink / raw)
To: iamkeyur96
Cc: allison.henderson, bfoster, chandanrlinux, darrick.wong,
dchinner, linux-kernel, linux-xfs
./xfs/libxfs/xfs_inode_buf.c:56: unnecssary ==> unnecessary
./xfs/libxfs/xfs_inode_buf.c:59: behavour ==> behaviour
./xfs/libxfs/xfs_inode_buf.c:206: unitialized ==> uninitialized
Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
---
fs/xfs/libxfs/xfs_inode_buf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
index 6f84ea85fdd8..5c93e8e6de74 100644
--- a/fs/xfs/libxfs/xfs_inode_buf.c
+++ b/fs/xfs/libxfs/xfs_inode_buf.c
@@ -53,10 +53,10 @@ xfs_inobp_check(
* If the readahead buffer is invalid, we need to mark it with an error and
* clear the DONE status of the buffer so that a followup read will re-read it
* from disk. We don't report the error otherwise to avoid warnings during log
- * recovery and we don't get unnecssary panics on debug kernels. We use EIO here
+ * recovery and we don't get unnecessary panics on debug kernels. We use EIO here
* because all we want to do is say readahead failed; there is no-one to report
* the error to, so this will distinguish it from a non-ra verifier failure.
- * Changes to this readahead error behavour also need to be reflected in
+ * Changes to this readahead error behaviour also need to be reflected in
* xfs_dquot_buf_readahead_verify().
*/
static void
@@ -203,7 +203,7 @@ xfs_inode_from_disk(
/*
* First get the permanent information that is needed to allocate an
* inode. If the inode is unused, mode is zero and we shouldn't mess
- * with the unitialized part of it.
+ * with the uninitialized part of it.
*/
to->di_flushiter = be16_to_cpu(from->di_flushiter);
inode->i_generation = be32_to_cpu(from->di_gen);
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: Couple of typo fixes in comments
2020-06-07 7:44 ` [PATCH] " Keyur Patel
@ 2020-06-22 17:29 ` Darrick J. Wong
0 siblings, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2020-06-22 17:29 UTC (permalink / raw)
To: Keyur Patel
Cc: allison.henderson, bfoster, chandanrlinux, dchinner,
linux-kernel, linux-xfs
On Sun, Jun 07, 2020 at 03:44:59AM -0400, Keyur Patel wrote:
> ./xfs/libxfs/xfs_inode_buf.c:56: unnecssary ==> unnecessary
> ./xfs/libxfs/xfs_inode_buf.c:59: behavour ==> behaviour
> ./xfs/libxfs/xfs_inode_buf.c:206: unitialized ==> uninitialized
>
> Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
Looks simple enough, though I bet this will have to be rebased against
5.8...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/libxfs/xfs_inode_buf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
> index 6f84ea85fdd8..5c93e8e6de74 100644
> --- a/fs/xfs/libxfs/xfs_inode_buf.c
> +++ b/fs/xfs/libxfs/xfs_inode_buf.c
> @@ -53,10 +53,10 @@ xfs_inobp_check(
> * If the readahead buffer is invalid, we need to mark it with an error and
> * clear the DONE status of the buffer so that a followup read will re-read it
> * from disk. We don't report the error otherwise to avoid warnings during log
> - * recovery and we don't get unnecssary panics on debug kernels. We use EIO here
> + * recovery and we don't get unnecessary panics on debug kernels. We use EIO here
> * because all we want to do is say readahead failed; there is no-one to report
> * the error to, so this will distinguish it from a non-ra verifier failure.
> - * Changes to this readahead error behavour also need to be reflected in
> + * Changes to this readahead error behaviour also need to be reflected in
> * xfs_dquot_buf_readahead_verify().
> */
> static void
> @@ -203,7 +203,7 @@ xfs_inode_from_disk(
> /*
> * First get the permanent information that is needed to allocate an
> * inode. If the inode is unused, mode is zero and we shouldn't mess
> - * with the unitialized part of it.
> + * with the uninitialized part of it.
> */
> to->di_flushiter = be16_to_cpu(from->di_flushiter);
> inode->i_generation = be32_to_cpu(from->di_gen);
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-22 17:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-07 7:39 [PATCH 2/2] xfs: Couple of typo fixes in comments Keyur Patel
2020-06-07 7:44 ` [PATCH] " Keyur Patel
2020-06-22 17:29 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).