linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] initrd: Remove erroneous comment
@ 2020-06-19 14:30 Tom Rini
  2020-06-19 17:49 ` [tip: x86/cleanups] " tip-bot2 for Tom Rini
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Tom Rini @ 2020-06-19 14:30 UTC (permalink / raw)
  To: linux-kernel
  Cc: Andrew Morton, Borislav Petkov, Dominik Brodowski,
	H . Peter Anvin, Ronald G . Minnich

Most architectures have been passing the location of an initrd via the
initrd= option since their inception.  Remove the comment as it's both
wrong and unrelated to the commit that introduced it.

Fixes: 694cfd87b0c8 ("x86/setup: Add an initrdmem= option to specify initrd physical address")
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Borislav Petkov <bp@suse.de>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: H. Peter Anvin (Intel) <hpa@zytor.com>
Cc: Ronald G. Minnich <rminnich@gmail.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
For a bit more context, I assume there's been some confusion between
"initrd" being a keyword in things like extlinux.conf and also that for
quite a long time now initrd information is passed via device tree and
not the command line on relevant architectures.  But it's still true
that it's been a valid command line option to the kernel since the 90s.
It's just the case that in 2018 the code was consolidated from under
arch/ and in to this file.
---
 init/do_mounts_initrd.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/init/do_mounts_initrd.c b/init/do_mounts_initrd.c
index d72beda824aa..53314d7da4be 100644
--- a/init/do_mounts_initrd.c
+++ b/init/do_mounts_initrd.c
@@ -45,11 +45,6 @@ static int __init early_initrdmem(char *p)
 }
 early_param("initrdmem", early_initrdmem);
 
-/*
- * This is here as the initrd keyword has been in use since 11/2018
- * on ARM, PowerPC, and MIPS.
- * It should not be; it is reserved for bootloaders.
- */
 static int __init early_initrd(char *p)
 {
 	return early_initrdmem(p);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2020-06-22 21:07 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-19 14:30 [PATCH] initrd: Remove erroneous comment Tom Rini
2020-06-19 17:49 ` [tip: x86/cleanups] " tip-bot2 for Tom Rini
2020-06-20  0:03 ` [PATCH] " ron minnich
2020-06-22 20:23   ` hpa
2020-06-22 20:02 ` ron minnich
2020-06-22 20:40   ` Tom Rini
2020-06-22 20:48     ` H. Peter Anvin
2020-06-22 21:06       ` Tom Rini
2020-06-22 20:56     ` ron minnich
2020-06-22 21:01       ` Tom Rini
2020-06-22 21:03         ` H. Peter Anvin
2020-06-22 21:07           ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).