From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 03/13] perf evlist: implement control command handling functions
Date: Tue, 23 Jun 2020 16:54:50 +0200 [thread overview]
Message-ID: <20200623145450.GF2619137@krava> (raw)
In-Reply-To: <88988ce1-52d3-21e7-f0dc-bac5fde63cb2@linux.intel.com>
On Wed, Jun 03, 2020 at 06:54:47PM +0300, Alexey Budankov wrote:
SNIP
> + case EVLIST_CTL_CMD_ACK:
> + case EVLIST_CTL_CMD_UNSUPPORTED:
> + default:
> + pr_debug("ctlfd: unsupported %d\n", *cmd);
> + break;
> + }
> + if (!(*cmd == EVLIST_CTL_CMD_ACK || *cmd == EVLIST_CTL_CMD_UNSUPPORTED))
> + evlist__ctlfd_ack(evlist);
> + }
> + }
> +
> + if (stat_entries[ctlfd_pos].revents & (POLLHUP | POLLERR))
> + evlist__finalize_ctlfd(evlist);
> + else
> + stat_entries[ctlfd_pos].revents = 0;
> +
> + return err;
> +}
> diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
> index 0d8b361f1c8e..bccf0a970371 100644
> --- a/tools/perf/util/evlist.h
> +++ b/tools/perf/util/evlist.h
> @@ -360,4 +360,21 @@ void perf_evlist__force_leader(struct evlist *evlist);
> struct evsel *perf_evlist__reset_weak_group(struct evlist *evlist,
> struct evsel *evsel,
> bool close);
> +#define EVLIST_CTL_CMD_ENABLE_TAG "enable"
> +#define EVLIST_CTL_CMD_DISABLE_TAG "disable"
> +#define EVLIST_CTL_CMD_ACK_TAG "ack\n"
why the \n at the end of ack?
jirka
next prev parent reply other threads:[~2020-06-23 14:55 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 15:47 [PATCH v7 00/13] perf: support enable and disable commands in stat and record modes Alexey Budankov
2020-06-03 15:52 ` [PATCH v7 01/13] tools/libperf: introduce notion of static polled file descriptors Alexey Budankov
2020-06-05 10:50 ` Jiri Olsa
2020-06-05 11:38 ` Jiri Olsa
2020-06-05 16:15 ` Alexey Budankov
2020-06-08 8:08 ` Alexey Budankov
2020-06-08 8:43 ` Jiri Olsa
2020-06-08 9:54 ` Alexey Budankov
2020-06-08 15:05 ` Alexey Budankov
2020-06-08 16:07 ` Jiri Olsa
2020-06-08 16:43 ` Alexey Budankov
2020-06-08 17:18 ` Alexey Budankov
2020-06-09 14:56 ` Jiri Olsa
2020-06-09 18:51 ` Alexey Budankov
2020-06-15 13:13 ` Alexey Budankov
2020-06-15 17:38 ` Alexey Budankov
2020-06-15 5:20 ` Alexey Budankov
2020-06-15 12:30 ` Jiri Olsa
2020-06-15 14:37 ` Alexey Budankov
2020-06-15 16:58 ` Jiri Olsa
2020-06-17 9:27 ` Jiri Olsa
2020-06-17 9:39 ` Alexey Budankov
2020-06-22 9:47 ` Alexey Budankov
2020-06-22 10:21 ` Jiri Olsa
2020-06-22 10:50 ` Alexey Budankov
2020-06-22 12:11 ` Jiri Olsa
2020-06-22 14:04 ` Alexey Budankov
2020-06-23 14:54 ` Jiri Olsa
2020-06-05 11:50 ` Alexey Budankov
2020-06-03 15:53 ` [PATCH v7 02/13] perf evlist: introduce control " Alexey Budankov
2020-06-03 15:54 ` [PATCH v7 03/13] perf evlist: implement control command handling functions Alexey Budankov
2020-06-23 14:54 ` Jiri Olsa [this message]
2020-06-24 11:48 ` Alexey Budankov
2020-06-03 15:55 ` [PATCH v7 04/13] perf stat: factor out body of event handling loop for system wide Alexey Budankov
2020-06-03 15:56 ` [PATCH v7 05/13] perf stat: move target check to loop control statement Alexey Budankov
2020-06-03 15:57 ` [PATCH v7 06/13] perf stat: factor out body of event handling loop for fork case Alexey Budankov
2020-06-03 15:57 ` [PATCH v7 07/13] perf stat: factor out event handling loop into dispatch_events() Alexey Budankov
2020-06-03 15:58 ` [PATCH v7 08/13] perf stat: extend -D,--delay option with -1 value Alexey Budankov
2020-06-03 15:59 ` [PATCH v7 09/13] perf stat: implement control commands handling Alexey Budankov
2020-06-03 15:59 ` [PATCH v7 10/13] perf stat: introduce --ctl-fd[-ack] options Alexey Budankov
2020-06-03 16:00 ` [PATCH v7 11/13] perf record: extend -D,--delay option with -1 value Alexey Budankov
2020-06-03 16:01 ` [PATCH v7 12/13] perf record: implement control commands handling Alexey Budankov
2020-06-03 16:02 ` [PATCH v7 13/13] perf record: introduce --ctl-fd[-ack] options Alexey Budankov
2020-06-05 7:47 ` [PATCH v7 00/13] perf: support enable and disable commands in stat and record modes Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623145450.GF2619137@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).