* [PATCH] MIPS: ingenic: gcw0: Fix HP detection GPIO.
@ 2020-06-23 21:19 João H. Spies
2020-06-24 12:03 ` Paul Cercueil
2020-06-25 8:23 ` Thomas Bogendoerfer
0 siblings, 2 replies; 3+ messages in thread
From: João H. Spies @ 2020-06-23 21:19 UTC (permalink / raw)
To: Paul Cercueil, Thomas Bogendoerfer
Cc: devicetree, linux-mips, linux-kernel, João H. Spies, stable
Previously marked as active high, but is in reality active low.
Cc: stable@vger.kernel.org
Fixes: b1bfdb660516 ("MIPS: ingenic: DTS: Update GCW0 support")
Signed-off-by: João H. Spies <jhlspies@gmail.com>
---
arch/mips/boot/dts/ingenic/gcw0.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/boot/dts/ingenic/gcw0.dts b/arch/mips/boot/dts/ingenic/gcw0.dts
index 8d22828787d8..bc72304a2440 100644
--- a/arch/mips/boot/dts/ingenic/gcw0.dts
+++ b/arch/mips/boot/dts/ingenic/gcw0.dts
@@ -92,7 +92,7 @@
"MIC1N", "Built-in Mic";
simple-audio-card,pin-switches = "Speaker", "Headphones";
- simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_HIGH>;
+ simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_LOW>;
simple-audio-card,aux-devs = <&speaker_amp>, <&headphones_amp>;
simple-audio-card,bitclock-master = <&dai_codec>;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: ingenic: gcw0: Fix HP detection GPIO.
2020-06-23 21:19 [PATCH] MIPS: ingenic: gcw0: Fix HP detection GPIO João H. Spies
@ 2020-06-24 12:03 ` Paul Cercueil
2020-06-25 8:23 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Paul Cercueil @ 2020-06-24 12:03 UTC (permalink / raw)
To: João H. Spies
Cc: Thomas Bogendoerfer, devicetree, linux-mips, linux-kernel, stable
Hi João,
Le mar. 23 juin 2020 à 18:19, João H. Spies <jhlspies@gmail.com> a
écrit :
> Previously marked as active high, but is in reality active low.
>
> Cc: stable@vger.kernel.org
> Fixes: b1bfdb660516 ("MIPS: ingenic: DTS: Update GCW0 support")
> Signed-off-by: João H. Spies <jhlspies@gmail.com>
Good catch.
Tested-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
> arch/mips/boot/dts/ingenic/gcw0.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ingenic/gcw0.dts
> b/arch/mips/boot/dts/ingenic/gcw0.dts
> index 8d22828787d8..bc72304a2440 100644
> --- a/arch/mips/boot/dts/ingenic/gcw0.dts
> +++ b/arch/mips/boot/dts/ingenic/gcw0.dts
> @@ -92,7 +92,7 @@
> "MIC1N", "Built-in Mic";
> simple-audio-card,pin-switches = "Speaker", "Headphones";
>
> - simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_HIGH>;
> + simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_LOW>;
> simple-audio-card,aux-devs = <&speaker_amp>, <&headphones_amp>;
>
> simple-audio-card,bitclock-master = <&dai_codec>;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: ingenic: gcw0: Fix HP detection GPIO.
2020-06-23 21:19 [PATCH] MIPS: ingenic: gcw0: Fix HP detection GPIO João H. Spies
2020-06-24 12:03 ` Paul Cercueil
@ 2020-06-25 8:23 ` Thomas Bogendoerfer
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2020-06-25 8:23 UTC (permalink / raw)
To: João H. Spies
Cc: Paul Cercueil, devicetree, linux-mips, linux-kernel, stable
On Tue, Jun 23, 2020 at 06:19:45PM -0300, João H. Spies wrote:
> Previously marked as active high, but is in reality active low.
>
> Cc: stable@vger.kernel.org
> Fixes: b1bfdb660516 ("MIPS: ingenic: DTS: Update GCW0 support")
> Signed-off-by: João H. Spies <jhlspies@gmail.com>
> ---
> arch/mips/boot/dts/ingenic/gcw0.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-25 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-23 21:19 [PATCH] MIPS: ingenic: gcw0: Fix HP detection GPIO João H. Spies
2020-06-24 12:03 ` Paul Cercueil
2020-06-25 8:23 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).