[PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

[PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

[Phu Luu]

From: Brant Merryman <brant.merryman@silabs.com>

Assign the .throttle and .unthrottle functions to be generic function
in the driver structure to prevent data loss that can otherwise occur
if the host does not enable USB throttling.

Signed-off-by: Phu Luu <phu.luu@silabs.com>
Signed-off-by: Brant Merryman <brant.merryman@silabs.com>
---
06/09/2020: Patch v3 1/2 Modified based on feedback from Johan Hovold <johan@kernel.org>
12/18/2019: Patch v2 Broken into two patches and modified based on feedback from Johan Hovold <johan@kernel.org>
12/09/2019: Initial submission of patch "Proper RTS control when buffers fill"

 drivers/usb/serial/cp210x.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index f5143eedbc48..bcceb4ad8be0 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -272,6 +272,8 @@ static struct usb_serial_driver cp210x_device = {
 	.break_ctl		= cp210x_break_ctl,
 	.set_termios		= cp210x_set_termios,
 	.tx_empty		= cp210x_tx_empty,
+	.throttle		= usb_serial_generic_throttle,
+	.unthrottle		= usb_serial_generic_unthrottle,
 	.tiocmget		= cp210x_tiocmget,
 	.tiocmset		= cp210x_tiocmset,
 	.attach			= cp210x_attach,
-- 
2.17.0

Re: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

[Johan Hovold]

On Fri, Jun 26, 2020 at 04:22:58AM +0000, Phu Luu wrote:
> From: Brant Merryman <brant.merryman@silabs.com>
> 
> Assign the .throttle and .unthrottle functions to be generic function
> in the driver structure to prevent data loss that can otherwise occur
> if the host does not enable USB throttling.
> 
> Signed-off-by: Phu Luu <phu.luu@silabs.com>
> Signed-off-by: Brant Merryman <brant.merryman@silabs.com>

Almost there. As I mentioned, the authori's SOB goes first and the
following SOB lines indicates who forwarded the patch (e.g. you in this
case).

If you also contributed to the patch you (e.g. you added the missing
changelog text) you should also add a Co-developed-by tag as described
in the process document I referred to:

	Co-developed-by: states that the patch was co-created by
	multiple developers; it is a used to give attribution to
	co-authors (in addition to the author attributed by the From:
	tag) when several people work on a single patch.  Since
	Co-developed-by: denotes authorship, every Co-developed-by: must
	be immediately followed by a Signed-off-by: of the associated
	co-author.  Standard sign-off procedure applies, i.e. the
	ordering of Signed-off-by: tags should reflect the chronological
	history of the patch insofar as possible, regardless of whether
	the author is attributed via From: or Co-developed-by:.
	Notably, the last Signed-off-by: must always be that of the
	developer submitting the patch.

	- Documentation/process/submitting-patches.rst

So in this case the tags should probably be:

	SOB: Brant
	CDB: Phu
	SOB: Phu

Care to fix that up in a v4 (yes, please increment the patch revision
every time you resubmit)?

Johan

[PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

[Phu Luu]

Assign the .throttle and .unthrottle functions to be generic function
in the driver structure to prevent data loss that can otherwise occur
if the host does not enable USB throttling.

Signed-off-by: Phu Luu <phu.luu@silabs.com>
Signed-off-by: Brant Merryman <brant.merryman@silabs.com>
---
06/09/2020: Patch v3 1/2 Modified based on feedback from Johan Hovold <johan@kernel.org>
12/18/2019: Patch v2 Broken into two patches and modified based on feedback from Johan Hovold <johan@kernel.org>
12/09/2019: Initial submission of patch "Proper RTS control when buffers fill"

 drivers/usb/serial/cp210x.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index f5143eedbc48..bcceb4ad8be0 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -272,6 +272,8 @@ static struct usb_serial_driver cp210x_device = {
 	.break_ctl		= cp210x_break_ctl,
 	.set_termios		= cp210x_set_termios,
 	.tx_empty		= cp210x_tx_empty,
+	.throttle		= usb_serial_generic_throttle,
+	.unthrottle		= usb_serial_generic_unthrottle,
 	.tiocmget		= cp210x_tiocmget,
 	.tiocmset		= cp210x_tiocmset,
 	.attach			= cp210x_attach,
-- 
2.17.0

Re: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

[Johan Hovold]

On Wed, Jun 24, 2020 at 07:01:33AM +0000, Phu Luu wrote:
> Assign the .throttle and .unthrottle functions to be generic function
> in the driver structure to prevent data loss that can otherwise occur
> if the host does not enable USB throttling.
> 
> Signed-off-by: Phu Luu <phu.luu@silabs.com>
> Signed-off-by: Brant Merryman <brant.merryman@silabs.com>

One last form issue (besides the whitespace corrupted patch 2/2 that
Greg pointed out): The SOB tags records how a patch got into the
kernel (e.g. who forwarded it) and the first SOB should generally be the
author's.

In this case, I guess Brant is the primary author as he submitted these
patches last time around. If so, you need to manually add From line at
the beginning of the mail (i.e. before the commit message). If you use
git-format-patch, git would handle that for you.

You can also use the newish "Co-developed-by" tag to indicate joint
authorship. More details can be found in 

	Documentation/process/submitting-patches.rst

Johan