[PATCH] platform/chrome: Clarify SPDX license with GPL-2.0-only

[PATCH] platform/chrome: Clarify SPDX license with GPL-2.0-only

[Enric Balletbo i Serra]

Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
tag.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---

 drivers/platform/chrome/Makefile                 | 2 +-
 drivers/platform/chrome/chromeos_pstore.c        | 2 +-
 drivers/platform/chrome/chromeos_tbmc.c          | 2 +-
 drivers/platform/chrome/cros_ec_chardev.c        | 2 +-
 drivers/platform/chrome/cros_ec_i2c.c            | 2 +-
 drivers/platform/chrome/cros_ec_ishtp.c          | 2 +-
 drivers/platform/chrome/cros_ec_lpc.c            | 2 +-
 drivers/platform/chrome/cros_ec_lpc_mec.c        | 2 +-
 drivers/platform/chrome/cros_ec_lpc_mec.h        | 2 +-
 drivers/platform/chrome/cros_ec_proto.c          | 2 +-
 drivers/platform/chrome/cros_ec_rpmsg.c          | 2 +-
 drivers/platform/chrome/cros_ec_sensorhub.c      | 2 +-
 drivers/platform/chrome/cros_ec_spi.c            | 2 +-
 drivers/platform/chrome/cros_ec_trace.c          | 2 +-
 drivers/platform/chrome/cros_ec_trace.h          | 2 +-
 drivers/platform/chrome/cros_usbpd_logger.c      | 2 +-
 drivers/platform/chrome/wilco_ec/Makefile        | 2 +-
 drivers/platform/chrome/wilco_ec/core.c          | 2 +-
 drivers/platform/chrome/wilco_ec/debugfs.c       | 2 +-
 drivers/platform/chrome/wilco_ec/event.c         | 2 +-
 drivers/platform/chrome/wilco_ec/keyboard_leds.c | 2 +-
 drivers/platform/chrome/wilco_ec/mailbox.c       | 2 +-
 drivers/platform/chrome/wilco_ec/properties.c    | 2 +-
 drivers/platform/chrome/wilco_ec/sysfs.c         | 2 +-
 drivers/platform/chrome/wilco_ec/telemetry.c     | 2 +-
 include/linux/platform_data/cros_ec_chardev.h    | 2 +-
 include/linux/platform_data/cros_ec_proto.h      | 2 +-
 include/linux/platform_data/cros_ec_sensorhub.h  | 2 +-
 28 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/drivers/platform/chrome/Makefile b/drivers/platform/chrome/Makefile
index 41baccba033f7..b3242f7007886 100644
--- a/drivers/platform/chrome/Makefile
+++ b/drivers/platform/chrome/Makefile
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0
+# SPDX-License-Identifier: GPL-2.0-only
 
 # tell define_trace.h where to find the cros ec trace header
 CFLAGS_cros_ec_trace.o:=		-I$(src)
diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c
index f37c0ef4af1fd..664ffda570386 100644
--- a/drivers/platform/chrome/chromeos_pstore.c
+++ b/drivers/platform/chrome/chromeos_pstore.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 // Driver to instantiate Chromebook ramoops device.
 //
 // Copyright (C) 2013 Google, Inc.
diff --git a/drivers/platform/chrome/chromeos_tbmc.c b/drivers/platform/chrome/chromeos_tbmc.c
index d1cf8f3463ce3..8b3583814cffd 100644
--- a/drivers/platform/chrome/chromeos_tbmc.c
+++ b/drivers/platform/chrome/chromeos_tbmc.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 // Driver to detect Tablet Mode for ChromeOS convertible.
 //
 // Copyright (C) 2017 Google, Inc.
diff --git a/drivers/platform/chrome/cros_ec_chardev.c b/drivers/platform/chrome/cros_ec_chardev.c
index e0bce869c49a9..a92c4f4ff4a5b 100644
--- a/drivers/platform/chrome/cros_ec_chardev.c
+++ b/drivers/platform/chrome/cros_ec_chardev.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Miscellaneous character driver for ChromeOS Embedded Controller
  *
diff --git a/drivers/platform/chrome/cros_ec_i2c.c b/drivers/platform/chrome/cros_ec_i2c.c
index 30c8938c27d54..89316cfb45463 100644
--- a/drivers/platform/chrome/cros_ec_i2c.c
+++ b/drivers/platform/chrome/cros_ec_i2c.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 // I2C interface for ChromeOS Embedded Controller
 //
 // Copyright (C) 2012 Google, Inc
diff --git a/drivers/platform/chrome/cros_ec_ishtp.c b/drivers/platform/chrome/cros_ec_ishtp.c
index ed794a7ddba9b..bbb1e17abd6c9 100644
--- a/drivers/platform/chrome/cros_ec_ishtp.c
+++ b/drivers/platform/chrome/cros_ec_ishtp.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 // ISHTP interface for ChromeOS Embedded Controller
 //
 // Copyright (c) 2019, Intel Corporation.
diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
index 1f78619440448..67b17333acd04 100644
--- a/drivers/platform/chrome/cros_ec_lpc.c
+++ b/drivers/platform/chrome/cros_ec_lpc.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 // LPC interface for ChromeOS Embedded Controller
 //
 // Copyright (C) 2012-2015 Google, Inc
diff --git a/drivers/platform/chrome/cros_ec_lpc_mec.c b/drivers/platform/chrome/cros_ec_lpc_mec.c
index 9035b17e8c869..fe364e224a533 100644
--- a/drivers/platform/chrome/cros_ec_lpc_mec.c
+++ b/drivers/platform/chrome/cros_ec_lpc_mec.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 // LPC variant I/O for Microchip EC
 //
 // Copyright (C) 2016 Google, Inc
diff --git a/drivers/platform/chrome/cros_ec_lpc_mec.h b/drivers/platform/chrome/cros_ec_lpc_mec.h
index aa1018f6b0f24..09dc6c6385d2b 100644
--- a/drivers/platform/chrome/cros_ec_lpc_mec.h
+++ b/drivers/platform/chrome/cros_ec_lpc_mec.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: GPL-2.0-only */
 /*
  * LPC variant I/O for Microchip EC
  *
diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
index 3e745e0fe092c..a7c94500624ee 100644
--- a/drivers/platform/chrome/cros_ec_proto.c
+++ b/drivers/platform/chrome/cros_ec_proto.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 // ChromeOS EC communication protocol helper functions
 //
 // Copyright (C) 2015 Google, Inc
diff --git a/drivers/platform/chrome/cros_ec_rpmsg.c b/drivers/platform/chrome/cros_ec_rpmsg.c
index 7e8629e3db746..ff08c3d12873a 100644
--- a/drivers/platform/chrome/cros_ec_rpmsg.c
+++ b/drivers/platform/chrome/cros_ec_rpmsg.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 //
 // Copyright 2018 Google LLC.
 
diff --git a/drivers/platform/chrome/cros_ec_sensorhub.c b/drivers/platform/chrome/cros_ec_sensorhub.c
index 9c4af76a9956e..d627b3f967d12 100644
--- a/drivers/platform/chrome/cros_ec_sensorhub.c
+++ b/drivers/platform/chrome/cros_ec_sensorhub.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Sensor HUB driver that discovers sensors behind a ChromeOS Embedded
  * Controller.
diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c
index debea5c4c8293..f7cf7c6a04507 100644
--- a/drivers/platform/chrome/cros_ec_spi.c
+++ b/drivers/platform/chrome/cros_ec_spi.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 // SPI interface for ChromeOS Embedded Controller
 //
 // Copyright (C) 2012 Google, Inc
diff --git a/drivers/platform/chrome/cros_ec_trace.c b/drivers/platform/chrome/cros_ec_trace.c
index 523a39bd0ff67..ad88542b2e252 100644
--- a/drivers/platform/chrome/cros_ec_trace.c
+++ b/drivers/platform/chrome/cros_ec_trace.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 // Trace events for the ChromeOS Embedded Controller
 //
 // Copyright 2019 Google LLC.
diff --git a/drivers/platform/chrome/cros_ec_trace.h b/drivers/platform/chrome/cros_ec_trace.h
index e9fb05f89ef07..6c2e23d88502b 100644
--- a/drivers/platform/chrome/cros_ec_trace.h
+++ b/drivers/platform/chrome/cros_ec_trace.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: GPL-2.0-only */
 /*
  * Trace events for the ChromeOS Embedded Controller
  *
diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c
index d16931203d821..53639f9d9bfd5 100644
--- a/drivers/platform/chrome/cros_usbpd_logger.c
+++ b/drivers/platform/chrome/cros_usbpd_logger.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Logging driver for ChromeOS EC based USBPD Charger.
  *
diff --git a/drivers/platform/chrome/wilco_ec/Makefile b/drivers/platform/chrome/wilco_ec/Makefile
index ecb3145cab187..ea483068a907e 100644
--- a/drivers/platform/chrome/wilco_ec/Makefile
+++ b/drivers/platform/chrome/wilco_ec/Makefile
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0
+# SPDX-License-Identifier: GPL-2.0-only
 
 wilco_ec-objs				:= core.o keyboard_leds.o mailbox.o \
 					   properties.o sysfs.o
diff --git a/drivers/platform/chrome/wilco_ec/core.c b/drivers/platform/chrome/wilco_ec/core.c
index 5b42992bff386..a0ac1268018f1 100644
--- a/drivers/platform/chrome/wilco_ec/core.c
+++ b/drivers/platform/chrome/wilco_ec/core.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Core driver for Wilco Embedded Controller
  *
diff --git a/drivers/platform/chrome/wilco_ec/debugfs.c b/drivers/platform/chrome/wilco_ec/debugfs.c
index a812788a0bdcc..c7a69fadf336e 100644
--- a/drivers/platform/chrome/wilco_ec/debugfs.c
+++ b/drivers/platform/chrome/wilco_ec/debugfs.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * debugfs attributes for Wilco EC
  *
diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c
index 814518509739d..0b6aa67ed7ab5 100644
--- a/drivers/platform/chrome/wilco_ec/event.c
+++ b/drivers/platform/chrome/wilco_ec/event.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * ACPI event handling for Wilco Embedded Controller
  *
diff --git a/drivers/platform/chrome/wilco_ec/keyboard_leds.c b/drivers/platform/chrome/wilco_ec/keyboard_leds.c
index 6ce9c67820652..4fe80daf7eb45 100644
--- a/drivers/platform/chrome/wilco_ec/keyboard_leds.c
+++ b/drivers/platform/chrome/wilco_ec/keyboard_leds.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Keyboard backlight LED driver for the Wilco Embedded Controller
  *
diff --git a/drivers/platform/chrome/wilco_ec/mailbox.c b/drivers/platform/chrome/wilco_ec/mailbox.c
index 0f98358ea824c..094de754fa4d3 100644
--- a/drivers/platform/chrome/wilco_ec/mailbox.c
+++ b/drivers/platform/chrome/wilco_ec/mailbox.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Mailbox interface for Wilco Embedded Controller
  *
diff --git a/drivers/platform/chrome/wilco_ec/properties.c b/drivers/platform/chrome/wilco_ec/properties.c
index c2bf4c95c5d2c..9f7e7083a240c 100644
--- a/drivers/platform/chrome/wilco_ec/properties.c
+++ b/drivers/platform/chrome/wilco_ec/properties.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Copyright 2019 Google LLC
  */
diff --git a/drivers/platform/chrome/wilco_ec/sysfs.c b/drivers/platform/chrome/wilco_ec/sysfs.c
index 3c587b4054a54..488671644f010 100644
--- a/drivers/platform/chrome/wilco_ec/sysfs.c
+++ b/drivers/platform/chrome/wilco_ec/sysfs.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Copyright 2019 Google LLC
  *
diff --git a/drivers/platform/chrome/wilco_ec/telemetry.c b/drivers/platform/chrome/wilco_ec/telemetry.c
index e06d96fb94265..b7a2d6101fc9b 100644
--- a/drivers/platform/chrome/wilco_ec/telemetry.c
+++ b/drivers/platform/chrome/wilco_ec/telemetry.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Telemetry communication for Wilco EC
  *
diff --git a/include/linux/platform_data/cros_ec_chardev.h b/include/linux/platform_data/cros_ec_chardev.h
index 7de8faaf77df8..0284cde753bee 100644
--- a/include/linux/platform_data/cros_ec_chardev.h
+++ b/include/linux/platform_data/cros_ec_chardev.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: GPL-2.0-only */
 /*
  * ChromeOS EC device interface.
  *
diff --git a/include/linux/platform_data/cros_ec_proto.h b/include/linux/platform_data/cros_ec_proto.h
index 3832433266762..95427b03ddb5e 100644
--- a/include/linux/platform_data/cros_ec_proto.h
+++ b/include/linux/platform_data/cros_ec_proto.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: GPL-2.0-only */
 /*
  * ChromeOS Embedded Controller protocol interface.
  *
diff --git a/include/linux/platform_data/cros_ec_sensorhub.h b/include/linux/platform_data/cros_ec_sensorhub.h
index 0ecce6aa69d5e..7d00138c1e292 100644
--- a/include/linux/platform_data/cros_ec_sensorhub.h
+++ b/include/linux/platform_data/cros_ec_sensorhub.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: GPL-2.0-only */
 /*
  * Chrome OS EC MEMS Sensor Hub driver.
  *
-- 
2.27.0

Re: [PATCH] platform/chrome: Clarify SPDX license with GPL-2.0-only

[Andy Shevchenko]

On Thu, Jun 25, 2020 at 9:25 PM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
> tag.

Is there any? Last time IIRC Greg told me that in the kernel the old
and new variants are okay.

...

>  28 files changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/platform/chrome/Makefile b/drivers/platform/chrome/Makefile
> index 41baccba033f7..b3242f7007886 100644
> --- a/drivers/platform/chrome/Makefile
> +++ b/drivers/platform/chrome/Makefile
> @@ -1,4 +1,4 @@
> -# SPDX-License-Identifier: GPL-2.0
> +# SPDX-License-Identifier: GPL-2.0-only

...

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/chrome: Clarify SPDX license with GPL-2.0-only

[Joe Perches]

On Thu, 2020-06-25 at 22:06 +0300, Andy Shevchenko wrote:
> On Thu, Jun 25, 2020 at 9:25 PM Enric Balletbo i Serra
> <enric.balletbo@collabora.com> wrote:
> > Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
> > tag.
> 
> Is there any? Last time IIRC Greg told me that in the kernel the old
> and new variants are okay.

If there wasn't any ambiguity, the older license
style wouldn't be deprecated by SPDX.org.

https://spdx.org/licenses/GPL-2.0.html

Deprecated
This license has been deprecated since license list version 3.0.
Full name

GNU General Public License v2.0 only
Short identifier

GPL-2.0

Re: [PATCH] platform/chrome: Clarify SPDX license with GPL-2.0-only

[Andy Shevchenko]

On Thu, Jun 25, 2020 at 10:29 PM Joe Perches <joe@perches.com> wrote:
>
> On Thu, 2020-06-25 at 22:06 +0300, Andy Shevchenko wrote:
> > On Thu, Jun 25, 2020 at 9:25 PM Enric Balletbo i Serra
> > <enric.balletbo@collabora.com> wrote:
> > > Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
> > > tag.
> >
> > Is there any? Last time IIRC Greg told me that in the kernel the old
> > and new variants are okay.
>
> If there wasn't any ambiguity, the older license
> style wouldn't be deprecated by SPDX.org.

They are _not_ deprecated according to kernel documentation:
https://elixir.bootlin.com/linux/latest/source/LICENSES/preferred/GPL-2.0

So, fix documentation in the kernel then.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/chrome: Clarify SPDX license with GPL-2.0-only

[Andy Shevchenko]

On Thu, Jun 25, 2020 at 10:33 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Jun 25, 2020 at 10:29 PM Joe Perches <joe@perches.com> wrote:
> > On Thu, 2020-06-25 at 22:06 +0300, Andy Shevchenko wrote:
> > > On Thu, Jun 25, 2020 at 9:25 PM Enric Balletbo i Serra
> > > <enric.balletbo@collabora.com> wrote:
> > > > Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
> > > > tag.
> > >
> > > Is there any? Last time IIRC Greg told me that in the kernel the old
> > > and new variants are okay.
> >
> > If there wasn't any ambiguity, the older license
> > style wouldn't be deprecated by SPDX.org.
>
> They are _not_ deprecated according to kernel documentation:
> https://elixir.bootlin.com/linux/latest/source/LICENSES/preferred/GPL-2.0
>
> So, fix documentation in the kernel then.

That said, NAK to the patch as long as in-kernel documentation says it's valid.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/chrome: Clarify SPDX license with GPL-2.0-only

[Joe Perches]

On Thu, 2020-06-25 at 22:33 +0300, Andy Shevchenko wrote:
> On Thu, Jun 25, 2020 at 10:29 PM Joe Perches <joe@perches.com> wrote:
> > On Thu, 2020-06-25 at 22:06 +0300, Andy Shevchenko wrote:
> > > On Thu, Jun 25, 2020 at 9:25 PM Enric Balletbo i Serra
> > > <enric.balletbo@collabora.com> wrote:
> > > > Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
> > > > tag.
> > > 
> > > Is there any? Last time IIRC Greg told me that in the kernel the old
> > > and new variants are okay.
> > 
> > If there wasn't any ambiguity, the older license
> > style wouldn't be deprecated by SPDX.org.
> 
> They are _not_ deprecated according to kernel documentation:
> https://elixir.bootlin.com/linux/latest/source/LICENSES/preferred/GPL-2.0
> 
> So, fix documentation in the kernel then.

Been there, tried that. Linus is out to lunch IMO.

https://lore.kernel.org/lkml/515362d10c06567f35f0d5b7c3f2e121769fb04b.camel@perches.com/

Re: [PATCH] platform/chrome: Clarify SPDX license with GPL-2.0-only

[Joe Perches]

On Thu, 2020-06-25 at 22:35 +0300, Andy Shevchenko wrote:
> On Thu, Jun 25, 2020 at 10:33 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Thu, Jun 25, 2020 at 10:29 PM Joe Perches <joe@perches.com> wrote:
> > > On Thu, 2020-06-25 at 22:06 +0300, Andy Shevchenko wrote:
> > > > On Thu, Jun 25, 2020 at 9:25 PM Enric Balletbo i Serra
> > > > <enric.balletbo@collabora.com> wrote:
> > > > > Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
> > > > > tag.
> > > > 
> > > > Is there any? Last time IIRC Greg told me that in the kernel the old
> > > > and new variants are okay.
> > > 
> > > If there wasn't any ambiguity, the older license
> > > style wouldn't be deprecated by SPDX.org.
> > 
> > They are _not_ deprecated according to kernel documentation:
> > https://elixir.bootlin.com/linux/latest/source/LICENSES/preferred/GPL-2.0
> > 
> > So, fix documentation in the kernel then.
> 
> That said, NAK to the patch as long as in-kernel documentation says it's valid.

Maintainers and authors should get to chose whatever
license text they prefer with the assent of the licensors.

A NAK here by you doesn't make much sense to me.

$ ./scripts/get_maintainer.pl  drivers/platform/chrome/
Benson Leung <bleung@chromium.org> (maintainer:CHROME HARDWARE PLATFORM SUPPORT)
Enric Balletbo i Serra <enric.balletbo@collabora.com> (maintainer:CHROME HARDWARE PLATFORM SUPPORT)
linux-kernel@vger.kernel.org (open list)

$ git log --no-merges --format="%an <%ae>" drivers/platform/chrome | sort | uniq -c | sort -rn
     53 Enric Balletbo i Serra <enric.balletbo@collabora.com>
     23 Gwendal Grignou <gwendal@chromium.org>
     16 Nick Crews <ncrews@chromium.org>
     15 Dmitry Torokhov <dmitry.torokhov@gmail.com>
      9 Prashant Malani <pmalani@chromium.org>
      9 Benson Leung <bleung@chromium.org>
      8 Javier Martinez Canillas <javier.martinez@collabora.co.uk>
      6 Shawn Nematbakhsh <shawnn@chromium.org>
      5 Nick Dyer <nick.dyer@itdev.co.uk>
      5 Daniel Campello <campello@chromium.org>
      4 Tzung-Bi Shih <tzungbi@google.com>
      4 Thierry Escande <thierry.escande@collabora.com>
      4 Stephen Boyd <swboyd@chromium.org>
      4 Pi-Hsun Shih <pihsun@chromium.org>
      4 Olof Johansson <olof@lixom.net>
      4 Eric Caruso <ejcaruso@chromium.org>
      4 Douglas Anderson <dianders@chromium.org>
      4 Bill Richardson <wfrichar@chromium.org>
      4 Arnd Bergmann <arnd@arndb.de>
      3 Wolfram Sang <wsa+renesas@sang-engineering.com>
      3 Stephen Barber <smbarber@chromium.org>
      3 Raul E Rangel <rrangel@chromium.org>
      3 Peter Zijlstra <peterz@infradead.org>
      3 Olof Johansson <olofj@chromium.org>
      3 Evan Green <evgreen@chromium.org>
      3 Enrico Granata <egranata@chromium.org>
      3 Brian Norris <briannorris@chromium.org>
      2 Jett Rink <jettrink@chromium.org>
      2 Javier Martinez Canillas <javier@osg.samsung.com>
      2 Gustavo A. R. Silva <gustavo@embeddedor.com>
      2 Guenter Roeck <linux@roeck-us.net>
      2 Gene Chen <gene.chen@intel.com>
      2 Dan Carpenter <dan.carpenter@oracle.com>
      2 Christian Engelmayer <cengelma@gmx.at>
      2 Aaron Durbin <adurbin@chromium.org>
      1 YueHaibing <yuehaibing@huawei.com>
      1 Yilun Lin <yllin@chromium.org>
      1 Yicheng Li <yichengli@chromium.org>
      1 Wolfram Sang <wsa@the-dreams.de>
      1 Wen Yang <wenyang@linux.alibaba.com>
      1 Wenkai Du <wenkai.du@intel.com>
      1 Wei Yongjun <yongjun_wei@trendmicro.com.cn>
      1 Vincent Palatin <vpalatin@chromium.org>
      1 Vic Yang <victoryang@google.com>
      1 Tomeu Vizoso <tomeu.vizoso@collabora.com>
      1 Tim Wawrzynczak <twawrzynczak@chromium.org>
      1 Thomas Gleixner <tglx@linutronix.de>
      1 Thierry Reding <treding@nvidia.com>
      1 Simon Que <sque@chromium.org>
      1 Sergiu Cuciurean <sergiu.cuciurean@analog.com>
      1 Sarthak Kukreti <sarthakkukreti@chromium.org>
      1 Salvatore Bellizzi <lkml@seppia.net>
      1 Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
      1 Robin Schroer <sulamiification@gmail.com>
      1 Ravi Chandra Sadineni <ravisadineni@chromium.org>
      1 Rajat Jain <rajatja@google.com>
      1 Nicolas Boichat <drinkcat@chromium.org>
      1 Neil Armstrong <narmstrong@baylibre.com>
      1 Navid Emamdoost <navid.emamdoost@gmail.com>
      1 Nathan Chancellor <natechancellor@gmail.com>
      1 Mohammed Habibulla <moch@chromium.org>
      1 Mika Westerberg <mika.westerberg@linux.intel.com>
      1 Michael Mullin <masmullin@gmail.com>
      1 Masahiro Yamada <masahiroy@kernel.org>
      1 Logan Gunthorpe <logang@deltatee.com>
      1 Linus Torvalds <torvalds@linux-foundation.org>
      1 Krzysztof Kozlowski <krzk@kernel.org>
      1 Kirill Smelkov <kirr@nexedi.com>
      1 Kees Cook <keescook@chromium.org>
      1 kbuild test robot <lkp@intel.com>
      1 kbuild test robot <fengguang.wu@intel.com>
      1 Joseph Lo <josephl@nvidia.com>
      1 Jon Flatley <jflat@chromium.org>
      1 Jeffery Yu <jefferyy@nvidia.com>
      1 Jarkko Nikula <jarkko.nikula@linux.intel.com>
      1 Hyungwoo Yang <hyungwoo.yang@intel.com>
      1 Heiner Kallweit <hkallweit1@gmail.com>
      1 Guenter Roeck <groeck@chromium.org>
      1 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      1 Geliang Tang <geliangtang@163.com>
      1 Emil Karlson <jekarlson@gmail.com>
      1 Emilio López <emilio.lopez@collabora.co.uk>
      1 Colin Ian King <colin.king@canonical.com>
      1 Clinton Sprain <clintonsprain@gmail.com>
      1 Chuhong Yuan <hslester96@gmail.com>
      1 Christoph Hellwig <hch@lst.de>
      1 Christophe JAILLET <christophe.jaillet@wanadoo.fr>
      1 Charlie Mooney <charliemooney@chromium.org>
      1 Bhumika Goyal <bhumirks@gmail.com>
      1 Bernardo Perez Priego <bernardo.perez.priego@intel.com>
      1 Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
      1 Archana Patni <archana.patni@intel.com>
      1 Andy Shevchenko <andriy.shevchenko@linux.intel.com>
      1 Al Viro <viro@zeniv.linux.org.uk>

Re: [PATCH] platform/chrome: Clarify SPDX license with GPL-2.0-only

[Greg Kroah-Hartman]

On Thu, Jun 25, 2020 at 10:06:03PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 25, 2020 at 9:25 PM Enric Balletbo i Serra
> <enric.balletbo@collabora.com> wrote:
> >
> > Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
> > tag.
> 
> Is there any? Last time IIRC Greg told me that in the kernel the old
> and new variants are okay.

They are just fine, leave it alone, the in-kernel LICENSES/ files show
the valid SPDX tags that the kernel allows at this point in time.

This is not worth the churn at all, once we get to complete coverage of
all kernel files, then you can worry about trivial things like this.

thanks,

greg k-h

Re: [PATCH] platform/chrome: Clarify SPDX license with GPL-2.0-only

[Enric Balletbo i Serra]

Hi,

On 26/6/20 6:33, Greg Kroah-Hartman wrote:
> On Thu, Jun 25, 2020 at 10:06:03PM +0300, Andy Shevchenko wrote:
>> On Thu, Jun 25, 2020 at 9:25 PM Enric Balletbo i Serra
>> <enric.balletbo@collabora.com> wrote:
>>>
>>> Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
>>> tag.
>>
>> Is there any? Last time IIRC Greg told me that in the kernel the old
>> and new variants are okay.
> 
> They are just fine, leave it alone, the in-kernel LICENSES/ files show
> the valid SPDX tags that the kernel allows at this point in time.
> 

I guess my confusion comes from seeing patch series doing this change in the ML
instead of really reading the documentation. If it's clear, and as per in-kernel
docs, it is, that a GPL-2.0 tag is a GPL-2.0 only license, that's fine with me.

> This is not worth the churn at all, once we get to complete coverage of
> all kernel files, then you can worry about trivial things like this.
> 

I don't have special interest on land this if it's clear (was not really clear
to me before the discussion). So, I'll drop that patch from my queue.

Thanks for the feedback,
 Enric

> thanks,
> 
> greg k-h
> 

Re: [PATCH] platform/chrome: Clarify SPDX license with GPL-2.0-only

[Andy Shevchenko]

On Thu, Jun 25, 2020 at 12:52:21PM -0700, Joe Perches wrote:
> On Thu, 2020-06-25 at 22:35 +0300, Andy Shevchenko wrote:
> > On Thu, Jun 25, 2020 at 10:33 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Thu, Jun 25, 2020 at 10:29 PM Joe Perches <joe@perches.com> wrote:
> > > > On Thu, 2020-06-25 at 22:06 +0300, Andy Shevchenko wrote:
> > > > > On Thu, Jun 25, 2020 at 9:25 PM Enric Balletbo i Serra
> > > > > <enric.balletbo@collabora.com> wrote:
> > > > > > Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
> > > > > > tag.
> > > > > 
> > > > > Is there any? Last time IIRC Greg told me that in the kernel the old
> > > > > and new variants are okay.
> > > > 
> > > > If there wasn't any ambiguity, the older license
> > > > style wouldn't be deprecated by SPDX.org.
> > > 
> > > They are _not_ deprecated according to kernel documentation:
> > > https://elixir.bootlin.com/linux/latest/source/LICENSES/preferred/GPL-2.0
> > > 
> > > So, fix documentation in the kernel then.
> > 
> > That said, NAK to the patch as long as in-kernel documentation says it's valid.
> 
> Maintainers and authors should get to chose whatever
> license text they prefer with the assent of the licensors.
> 
> A NAK here by you doesn't make much sense to me.

Yes, it's a private opinion from a PDx86 maintainer.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/chrome: Clarify SPDX license with GPL-2.0-only

[Greg Kroah-Hartman]

On Fri, Jun 26, 2020 at 10:32:55AM +0200, Enric Balletbo i Serra wrote:
> Hi,
> 
> On 26/6/20 6:33, Greg Kroah-Hartman wrote:
> > On Thu, Jun 25, 2020 at 10:06:03PM +0300, Andy Shevchenko wrote:
> >> On Thu, Jun 25, 2020 at 9:25 PM Enric Balletbo i Serra
> >> <enric.balletbo@collabora.com> wrote:
> >>>
> >>> Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
> >>> tag.
> >>
> >> Is there any? Last time IIRC Greg told me that in the kernel the old
> >> and new variants are okay.
> > 
> > They are just fine, leave it alone, the in-kernel LICENSES/ files show
> > the valid SPDX tags that the kernel allows at this point in time.
> > 
> 
> I guess my confusion comes from seeing patch series doing this change in the ML
> instead of really reading the documentation. If it's clear, and as per in-kernel
> docs, it is, that a GPL-2.0 tag is a GPL-2.0 only license, that's fine with me.

It is clear, no churn needed, thanks!

greg k-h