linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/6] ASoC: amd: acp-da7219-max98357a: fix 'defined but not used' warning
       [not found] <20200702164433.162815-1-pierre-louis.bossart@linux.intel.com>
@ 2020-07-02 16:44 ` Pierre-Louis Bossart
  2020-07-02 16:44 ` [PATCH 2/6] ASoC: amd: acp-rt5645: " Pierre-Louis Bossart
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-02 16:44 UTC (permalink / raw)
  To: alsa-devel
  Cc: tiwai, broonie, Pierre-Louis Bossart, Liam Girdwood,
	Jaroslav Kysela, Takashi Iwai, Kuninori Morimoto, Yu-Hsuan Hsu,
	Akshu Agrawal, open list

Fix W=1 warning

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/amd/acp-da7219-max98357a.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c
index 9414d7269c4f..7d8986379d80 100644
--- a/sound/soc/amd/acp-da7219-max98357a.c
+++ b/sound/soc/amd/acp-da7219-max98357a.c
@@ -450,11 +450,13 @@ static int cz_probe(struct platform_device *pdev)
 	return 0;
 }
 
+#ifdef CONFIG_ACPI
 static const struct acpi_device_id cz_audio_acpi_match[] = {
 	{ "AMD7219", 0 },
 	{},
 };
 MODULE_DEVICE_TABLE(acpi, cz_audio_acpi_match);
+#endif
 
 static struct platform_driver cz_pcm_driver = {
 	.driver = {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/6] ASoC: amd: acp-rt5645: fix 'defined but not used' warning
       [not found] <20200702164433.162815-1-pierre-louis.bossart@linux.intel.com>
  2020-07-02 16:44 ` [PATCH 1/6] ASoC: amd: acp-da7219-max98357a: fix 'defined but not used' warning Pierre-Louis Bossart
@ 2020-07-02 16:44 ` Pierre-Louis Bossart
  2020-07-02 16:44 ` [PATCH 3/6] ASoC: amd: raven: acp3x-pcm-dma: fix 'set " Pierre-Louis Bossart
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-02 16:44 UTC (permalink / raw)
  To: alsa-devel
  Cc: tiwai, broonie, Pierre-Louis Bossart, Liam Girdwood,
	Jaroslav Kysela, Takashi Iwai, Kuninori Morimoto, open list

Fix W=1 warning

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/amd/acp-rt5645.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/amd/acp-rt5645.c b/sound/soc/amd/acp-rt5645.c
index 73b31f88a6b5..87f0060e771f 100644
--- a/sound/soc/amd/acp-rt5645.c
+++ b/sound/soc/amd/acp-rt5645.c
@@ -182,11 +182,13 @@ static int cz_probe(struct platform_device *pdev)
 	return 0;
 }
 
+#ifdef CONFIG_ACPI
 static const struct acpi_device_id cz_audio_acpi_match[] = {
 	{ "AMDI1002", 0 },
 	{},
 };
 MODULE_DEVICE_TABLE(acpi, cz_audio_acpi_match);
+#endif
 
 static struct platform_driver cz_pcm_driver = {
 	.driver = {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/6] ASoC: amd: raven: acp3x-pcm-dma: fix 'set but not used' warning
       [not found] <20200702164433.162815-1-pierre-louis.bossart@linux.intel.com>
  2020-07-02 16:44 ` [PATCH 1/6] ASoC: amd: acp-da7219-max98357a: fix 'defined but not used' warning Pierre-Louis Bossart
  2020-07-02 16:44 ` [PATCH 2/6] ASoC: amd: acp-rt5645: " Pierre-Louis Bossart
@ 2020-07-02 16:44 ` Pierre-Louis Bossart
  2020-07-02 16:44 ` [PATCH 4/6] ASoC: amd: raven: acp3x-i2s: " Pierre-Louis Bossart
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 6+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-02 16:44 UTC (permalink / raw)
  To: alsa-devel
  Cc: tiwai, broonie, Pierre-Louis Bossart, Liam Girdwood,
	Jaroslav Kysela, Takashi Iwai, Ravulapati Vishnu vardhan rao,
	Akshu Agrawal, Vijendar Mukunda, Kuninori Morimoto, open list

Fix W=1 warning. the card variable is useless here.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/amd/raven/acp3x-pcm-dma.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c
index 5bd458e0fe31..1f0fe5aaab1d 100644
--- a/sound/soc/amd/raven/acp3x-pcm-dma.c
+++ b/sound/soc/amd/raven/acp3x-pcm-dma.c
@@ -302,14 +302,12 @@ static snd_pcm_uframes_t acp3x_dma_pointer(struct snd_soc_component *component,
 					   struct snd_pcm_substream *substream)
 {
 	struct snd_soc_pcm_runtime *prtd;
-	struct snd_soc_card *card;
 	struct i2s_stream_instance *rtd;
 	u32 pos;
 	u32 buffersize;
 	u64 bytescount;
 
 	prtd = substream->private_data;
-	card = prtd->card;
 	rtd = substream->runtime->private_data;
 
 	buffersize = frames_to_bytes(substream->runtime,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 4/6] ASoC: amd: raven: acp3x-i2s: fix 'set but not used' warning
       [not found] <20200702164433.162815-1-pierre-louis.bossart@linux.intel.com>
                   ` (2 preceding siblings ...)
  2020-07-02 16:44 ` [PATCH 3/6] ASoC: amd: raven: acp3x-pcm-dma: fix 'set " Pierre-Louis Bossart
@ 2020-07-02 16:44 ` Pierre-Louis Bossart
  2020-07-02 16:44 ` [PATCH 5/6] ASoC: amd: raven: acp3x-pcm-dma: remove unused-but-set variable Pierre-Louis Bossart
  2020-07-02 16:44 ` [PATCH 6/6] ASoC: amd: raven: acp3x-i2s: " Pierre-Louis Bossart
  5 siblings, 0 replies; 6+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-02 16:44 UTC (permalink / raw)
  To: alsa-devel
  Cc: tiwai, broonie, Pierre-Louis Bossart, Liam Girdwood,
	Jaroslav Kysela, Takashi Iwai, Ravulapati Vishnu vardhan rao,
	Akshu Agrawal, Wei Yongjun, open list

Fix W=1 warning. the card variable is useless here

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/amd/raven/acp3x-i2s.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/amd/raven/acp3x-i2s.c b/sound/soc/amd/raven/acp3x-i2s.c
index 14607563abd2..a0e14cc91d95 100644
--- a/sound/soc/amd/raven/acp3x-i2s.c
+++ b/sound/soc/amd/raven/acp3x-i2s.c
@@ -150,13 +150,11 @@ static int acp3x_i2s_trigger(struct snd_pcm_substream *substream,
 {
 	struct i2s_stream_instance *rtd;
 	struct snd_soc_pcm_runtime *prtd;
-	struct snd_soc_card *card;
 	u32 ret, val, period_bytes, reg_val, ier_val, water_val;
 	u32 buf_size, buf_reg;
 
 	prtd = substream->private_data;
 	rtd = substream->runtime->private_data;
-	card = prtd->card;
 	period_bytes = frames_to_bytes(substream->runtime,
 			substream->runtime->period_size);
 	buf_size = frames_to_bytes(substream->runtime,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 5/6] ASoC: amd: raven: acp3x-pcm-dma: remove unused-but-set variable
       [not found] <20200702164433.162815-1-pierre-louis.bossart@linux.intel.com>
                   ` (3 preceding siblings ...)
  2020-07-02 16:44 ` [PATCH 4/6] ASoC: amd: raven: acp3x-i2s: " Pierre-Louis Bossart
@ 2020-07-02 16:44 ` Pierre-Louis Bossart
  2020-07-02 16:44 ` [PATCH 6/6] ASoC: amd: raven: acp3x-i2s: " Pierre-Louis Bossart
  5 siblings, 0 replies; 6+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-02 16:44 UTC (permalink / raw)
  To: alsa-devel
  Cc: tiwai, broonie, Pierre-Louis Bossart, Liam Girdwood,
	Jaroslav Kysela, Takashi Iwai, Ravulapati Vishnu vardhan rao,
	Akshu Agrawal, Vijendar Mukunda, Kuninori Morimoto, open list

Fix W=1 warning. The variable prtd is not used, remove.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/amd/raven/acp3x-pcm-dma.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c
index 1f0fe5aaab1d..17290c829c4b 100644
--- a/sound/soc/amd/raven/acp3x-pcm-dma.c
+++ b/sound/soc/amd/raven/acp3x-pcm-dma.c
@@ -301,13 +301,11 @@ static int acp3x_dma_hw_params(struct snd_soc_component *component,
 static snd_pcm_uframes_t acp3x_dma_pointer(struct snd_soc_component *component,
 					   struct snd_pcm_substream *substream)
 {
-	struct snd_soc_pcm_runtime *prtd;
 	struct i2s_stream_instance *rtd;
 	u32 pos;
 	u32 buffersize;
 	u64 bytescount;
 
-	prtd = substream->private_data;
 	rtd = substream->runtime->private_data;
 
 	buffersize = frames_to_bytes(substream->runtime,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 6/6] ASoC: amd: raven: acp3x-i2s: remove unused-but-set variable
       [not found] <20200702164433.162815-1-pierre-louis.bossart@linux.intel.com>
                   ` (4 preceding siblings ...)
  2020-07-02 16:44 ` [PATCH 5/6] ASoC: amd: raven: acp3x-pcm-dma: remove unused-but-set variable Pierre-Louis Bossart
@ 2020-07-02 16:44 ` Pierre-Louis Bossart
  5 siblings, 0 replies; 6+ messages in thread
From: Pierre-Louis Bossart @ 2020-07-02 16:44 UTC (permalink / raw)
  To: alsa-devel
  Cc: tiwai, broonie, Pierre-Louis Bossart, Liam Girdwood,
	Jaroslav Kysela, Takashi Iwai, Ravulapati Vishnu vardhan rao,
	Akshu Agrawal, Wei Yongjun, open list

Fix W=1 warning. The variable prtd is set but not used.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/amd/raven/acp3x-i2s.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/amd/raven/acp3x-i2s.c b/sound/soc/amd/raven/acp3x-i2s.c
index a0e14cc91d95..c3eb9b347eaa 100644
--- a/sound/soc/amd/raven/acp3x-i2s.c
+++ b/sound/soc/amd/raven/acp3x-i2s.c
@@ -149,11 +149,9 @@ static int acp3x_i2s_trigger(struct snd_pcm_substream *substream,
 				int cmd, struct snd_soc_dai *dai)
 {
 	struct i2s_stream_instance *rtd;
-	struct snd_soc_pcm_runtime *prtd;
 	u32 ret, val, period_bytes, reg_val, ier_val, water_val;
 	u32 buf_size, buf_reg;
 
-	prtd = substream->private_data;
 	rtd = substream->runtime->private_data;
 	period_bytes = frames_to_bytes(substream->runtime,
 			substream->runtime->period_size);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-07-02 16:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200702164433.162815-1-pierre-louis.bossart@linux.intel.com>
2020-07-02 16:44 ` [PATCH 1/6] ASoC: amd: acp-da7219-max98357a: fix 'defined but not used' warning Pierre-Louis Bossart
2020-07-02 16:44 ` [PATCH 2/6] ASoC: amd: acp-rt5645: " Pierre-Louis Bossart
2020-07-02 16:44 ` [PATCH 3/6] ASoC: amd: raven: acp3x-pcm-dma: fix 'set " Pierre-Louis Bossart
2020-07-02 16:44 ` [PATCH 4/6] ASoC: amd: raven: acp3x-i2s: " Pierre-Louis Bossart
2020-07-02 16:44 ` [PATCH 5/6] ASoC: amd: raven: acp3x-pcm-dma: remove unused-but-set variable Pierre-Louis Bossart
2020-07-02 16:44 ` [PATCH 6/6] ASoC: amd: raven: acp3x-i2s: " Pierre-Louis Bossart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).