linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] soc: ixp4xx: List the whole directory in MAINTAINERS
@ 2020-07-03  8:26 Jean Delvare
  2020-07-03  8:27 ` [PATCH 2/2] soc: ixp4xx: Really select helper drivers automatically Jean Delvare
  0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2020-07-03  8:26 UTC (permalink / raw)
  To: Krzysztof Halasa; +Cc: LKML, Linus Walleij, Jakub Kicinski

Mention the whole directory containing the ixp4xx soc drivers in
MAINTAINERS instead of each driver separately. Otherwise changes
done to Makefile and Kconfig will fail to find a matching entry.
This will also let future drivers match without having to update
the entry each time.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Krzysztof Halasa <khalasa@piap.pl>
---
 MAINTAINERS |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- linux-5.7.orig/MAINTAINERS	2020-06-23 13:03:34.728650310 +0200
+++ linux-5.7/MAINTAINERS	2020-06-23 13:04:14.045055597 +0200
@@ -8654,10 +8654,8 @@ M:	Krzysztof Halasa <khalasa@piap.pl>
 S:	Maintained
 F:	drivers/net/ethernet/xscale/ixp4xx_eth.c
 F:	drivers/net/wan/ixp4xx_hss.c
-F:	drivers/soc/ixp4xx/ixp4xx-npe.c
-F:	drivers/soc/ixp4xx/ixp4xx-qmgr.c
-F:	include/linux/soc/ixp4xx/npe.h
-F:	include/linux/soc/ixp4xx/qmgr.h
+F:	drivers/soc/ixp4xx/
+F:	include/linux/soc/ixp4xx/
 
 INTEL IXP4XX RANDOM NUMBER GENERATOR SUPPORT
 M:	Deepak Saxena <dsaxena@plexity.net>


-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] soc: ixp4xx: Really select helper drivers automatically
  2020-07-03  8:26 [PATCH 1/2] soc: ixp4xx: List the whole directory in MAINTAINERS Jean Delvare
@ 2020-07-03  8:27 ` Jean Delvare
  0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2020-07-03  8:27 UTC (permalink / raw)
  To: Krzysztof Halasa; +Cc: LKML, Linus Walleij, Jakub Kicinski

Kconfig claims that the ixp4xx-qmgr and ixp4xx-npe helper drivers
are selected automatically as needed. However this is not what the
Kconfig entries are doing. Convert depends to select to match the
help texts.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Krzysztof Halasa <khalasa@piap.pl>
---
 drivers/crypto/Kconfig              |    4 +++-
 drivers/net/ethernet/xscale/Kconfig |    7 ++++---
 drivers/net/wan/Kconfig             |    4 +++-
 3 files changed, 10 insertions(+), 5 deletions(-)

--- linux-5.7.orig/drivers/net/ethernet/xscale/Kconfig	2020-06-01 01:49:15.000000000 +0200
+++ linux-5.7/drivers/net/ethernet/xscale/Kconfig	2020-06-23 13:05:23.071767146 +0200
@@ -6,8 +6,7 @@
 config NET_VENDOR_XSCALE
 	bool "Intel XScale IXP devices"
 	default y
-	depends on NET_VENDOR_INTEL && (ARM && ARCH_IXP4XX && \
-		   IXP4XX_NPE && IXP4XX_QMGR)
+	depends on NET_VENDOR_INTEL && (ARM && ARCH_IXP4XX)
 	---help---
 	  If you have a network (Ethernet) card belonging to this class, say Y.
 
@@ -20,9 +19,11 @@ if NET_VENDOR_XSCALE
 
 config IXP4XX_ETH
 	tristate "Intel IXP4xx Ethernet support"
-	depends on ARM && ARCH_IXP4XX && IXP4XX_NPE && IXP4XX_QMGR
+	depends on ARM && ARCH_IXP4XX
 	select PHYLIB
 	select NET_PTP_CLASSIFY
+	select IXP4XX_NPE
+	select IXP4XX_QMGR
 	---help---
 	  Say Y here if you want to use built-in Ethernet ports
 	  on IXP4xx processor.
--- linux-5.7.orig/drivers/net/wan/Kconfig	2020-06-01 01:49:15.000000000 +0200
+++ linux-5.7/drivers/net/wan/Kconfig	2020-06-23 13:05:23.072767157 +0200
@@ -315,8 +315,10 @@ config DSCC4_PCI_RST
 
 config IXP4XX_HSS
 	tristate "Intel IXP4xx HSS (synchronous serial port) support"
-	depends on HDLC && IXP4XX_NPE && IXP4XX_QMGR
+	depends on HDLC
 	depends on ARCH_IXP4XX
+	select IXP4XX_NPE
+	select IXP4XX_QMGR
 	help
 	  Say Y here if you want to use built-in HSS ports
 	  on IXP4xx processor.
--- linux-5.7.orig/drivers/crypto/Kconfig	2020-06-01 01:49:15.000000000 +0200
+++ linux-5.7/drivers/crypto/Kconfig	2020-06-25 00:04:11.570461001 +0200
@@ -308,11 +308,13 @@ config CRYPTO_DEV_TALITOS2
 
 config CRYPTO_DEV_IXP4XX
 	tristate "Driver for IXP4xx crypto hardware acceleration"
-	depends on ARCH_IXP4XX && IXP4XX_QMGR && IXP4XX_NPE
+	depends on ARCH_IXP4XX
 	select CRYPTO_LIB_DES
 	select CRYPTO_AEAD
 	select CRYPTO_AUTHENC
 	select CRYPTO_SKCIPHER
+	select IXP4XX_NPE
+	select IXP4XX_QMGR
 	help
 	  Driver for the IXP4xx NPE crypto engine.
 

-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] soc: ixp4xx: List the whole directory in MAINTAINERS
@ 2019-07-12 13:37 Jean Delvare
  0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2019-07-12 13:37 UTC (permalink / raw)
  To: Krzysztof Halasa; +Cc: LKML

Mention the whole directory containing the ixp4xx soc drivers in
MAINTAINERS instead of each driver separately. Otherwise changes
done to Makefile and Kconfig will fail to find a matching entry.
This will also let future drivers match without having to update
the entry each time.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Krzysztof Halasa <khalasa@piap.pl>
---
 MAINTAINERS |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- linux-5.2.orig/MAINTAINERS	2019-07-12 15:33:28.106852821 +0200
+++ linux-5.2/MAINTAINERS	2019-07-12 15:35:54.309067537 +0200
@@ -8023,10 +8023,8 @@ F:	Documentation/media/v4l-drivers/ipu3.
 INTEL IXP4XX QMGR, NPE, ETHERNET and HSS SUPPORT
 M:	Krzysztof Halasa <khalasa@piap.pl>
 S:	Maintained
-F:	include/linux/soc/ixp4xx/qmgr.h
-F:	include/linux/soc/ixp4xx/npe.h
-F:	drivers/soc/ixp4xx/ixp4xx-qmgr.c
-F:	drivers/soc/ixp4xx/ixp4xx-npe.c
+F:	include/linux/soc/ixp4xx/
+F:	drivers/soc/ixp4xx/
 F:	drivers/net/ethernet/xscale/ixp4xx_eth.c
 F:	drivers/net/wan/ixp4xx_hss.c
 

-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-03  8:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-03  8:26 [PATCH 1/2] soc: ixp4xx: List the whole directory in MAINTAINERS Jean Delvare
2020-07-03  8:27 ` [PATCH 2/2] soc: ixp4xx: Really select helper drivers automatically Jean Delvare
  -- strict thread matches above, loose matches on Subject: below --
2019-07-12 13:37 [PATCH 1/2] soc: ixp4xx: List the whole directory in MAINTAINERS Jean Delvare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).