* [PATCH] drivers/net/wan/lapbether: Fixed the value of hard_header_len
@ 2020-07-04 5:12 Xie He
2020-07-05 0:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Xie He @ 2020-07-04 5:12 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Madhuparna Bhowmik, Xie He,
netdev, linux-kernel, linux-x25
When transmitting data from upper layers or from AF_PACKET sockets,
this driver will first remove a pseudo header of 1 byte,
then the lapb module will prepend the LAPB header of 2 or 3 bytes,
then this driver will prepend a length field of 2 bytes,
then the underlying Ethernet device will prepend its own header.
So, the header length required should be:
-1 + 3 + 2 + "the header length needed by the underlying device".
This patch fixes kernel panic when this driver is used with AF_PACKET
SOCK_DGRAM sockets.
Signed-off-by: Xie He <xie.he.0141@gmail.com>
---
drivers/net/wan/lapbether.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index e30d91a38cfb..3b5ed0928a4c 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -303,7 +303,6 @@ static void lapbeth_setup(struct net_device *dev)
dev->netdev_ops = &lapbeth_netdev_ops;
dev->needs_free_netdev = true;
dev->type = ARPHRD_X25;
- dev->hard_header_len = 3;
dev->mtu = 1000;
dev->addr_len = 0;
}
@@ -324,6 +323,8 @@ static int lapbeth_new_device(struct net_device *dev)
if (!ndev)
goto out;
+ ndev->hard_header_len = -1 + 3 + 2 + dev->hard_header_len;
+
lapbeth = netdev_priv(ndev);
lapbeth->axdev = ndev;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/net/wan/lapbether: Fixed the value of hard_header_len
2020-07-04 5:12 [PATCH] drivers/net/wan/lapbether: Fixed the value of hard_header_len Xie He
@ 2020-07-05 0:52 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-07-05 0:52 UTC (permalink / raw)
To: xie.he.0141; +Cc: kuba, madhuparnabhowmik04, netdev, linux-kernel, linux-x25
From: Xie He <xie.he.0141@gmail.com>
Date: Fri, 3 Jul 2020 22:12:46 -0700
> When transmitting data from upper layers or from AF_PACKET sockets,
> this driver will first remove a pseudo header of 1 byte,
> then the lapb module will prepend the LAPB header of 2 or 3 bytes,
> then this driver will prepend a length field of 2 bytes,
> then the underlying Ethernet device will prepend its own header.
Please add something like this above text to a comment:
> @@ -324,6 +323,8 @@ static int lapbeth_new_device(struct net_device *dev)
> if (!ndev)
> goto out;
>
> + ndev->hard_header_len = -1 + 3 + 2 + dev->hard_header_len;
> +
Above this new line so that someone reading the code can understand
these magic numbers and what they mean.
Thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-05 0:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-04 5:12 [PATCH] drivers/net/wan/lapbether: Fixed the value of hard_header_len Xie He
2020-07-05 0:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).