Re: [PATCH v3 4/4] thermal: core: Add notifications call in the framework

From: kernel test robot <lkp@intel.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, rui.zhang@intel.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	srinivas.pandruvada@linux.intel.com, rkumbako@codeaurora.org,
	amit.kucheria@linaro.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 4/4] thermal: core: Add notifications call in the framework
Date: Sat, 4 Jul 2020 02:22:49 +0800	[thread overview]
Message-ID: <202007040241.6BPKbqtO%lkp@intel.com> (raw)
In-Reply-To: <20200703085309.32166-4-daniel.lezcano@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 2369 bytes --]

Hi Daniel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.8-rc3 next-20200703]
[cannot apply to thermal/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Daniel-Lezcano/thermal-core-Add-helpers-to-browse-the-cdev-tz-and-governor-list/20200703-165448
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 9ebcfadb0610322ac537dd7aa5d9cbc2b2894c68
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project ca464639a1c9dd3944eb055ffd2796e8c2e7639f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/thermal/thermal_helpers.c:178:6: warning: no previous prototype for function 'thermal_cdev_set_cur_state' [-Wmissing-prototypes]
   void thermal_cdev_set_cur_state(struct thermal_cooling_device *cdev, int target)
        ^
   drivers/thermal/thermal_helpers.c:178:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void thermal_cdev_set_cur_state(struct thermal_cooling_device *cdev, int target)
   ^
   static 
   1 warning generated.

vim +/thermal_cdev_set_cur_state +178 drivers/thermal/thermal_helpers.c

   177	
 > 178	void thermal_cdev_set_cur_state(struct thermal_cooling_device *cdev, int target)
   179	{
   180		if (cdev->ops->set_cur_state(cdev, target))
   181			return;
   182		thermal_notify_cdev_update(cdev->id, target);
   183		thermal_cooling_device_stats_update(cdev, target);
   184	}
   185	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 75344 bytes --]