* [PATCH v1] dmaengine: fsl-edma-common: correct DSIZE_32BYTE
@ 2020-06-29 16:59 Robin Gong
2020-07-02 11:15 ` Angelo Dureghello
2020-07-06 4:55 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Robin Gong @ 2020-06-29 16:59 UTC (permalink / raw)
To: vkoul, dan.j.williams, angelo; +Cc: dmaengine, linux-kernel, linux-imx
Correct EDMA_TCD_ATTR_DSIZE_32BYTE define since it's broken by the below:
'0x0005 --> BIT(3) | BIT(0))'
Fixes: 4d6d3a90e4ac ("dmaengine: fsl-edma: fix macros")
Cc: stable@vger.kernel.org
Signed-off-by: Robin Gong <yibin.gong@nxp.com>
---
drivers/dma/fsl-edma-common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/fsl-edma-common.h b/drivers/dma/fsl-edma-common.h
index 67e4225..ec11697 100644
--- a/drivers/dma/fsl-edma-common.h
+++ b/drivers/dma/fsl-edma-common.h
@@ -33,7 +33,7 @@
#define EDMA_TCD_ATTR_DSIZE_16BIT BIT(0)
#define EDMA_TCD_ATTR_DSIZE_32BIT BIT(1)
#define EDMA_TCD_ATTR_DSIZE_64BIT (BIT(0) | BIT(1))
-#define EDMA_TCD_ATTR_DSIZE_32BYTE (BIT(3) | BIT(0))
+#define EDMA_TCD_ATTR_DSIZE_32BYTE (BIT(2) | BIT(0))
#define EDMA_TCD_ATTR_SSIZE_8BIT 0
#define EDMA_TCD_ATTR_SSIZE_16BIT (EDMA_TCD_ATTR_DSIZE_16BIT << 8)
#define EDMA_TCD_ATTR_SSIZE_32BIT (EDMA_TCD_ATTR_DSIZE_32BIT << 8)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] dmaengine: fsl-edma-common: correct DSIZE_32BYTE
2020-06-29 16:59 [PATCH v1] dmaengine: fsl-edma-common: correct DSIZE_32BYTE Robin Gong
@ 2020-07-02 11:15 ` Angelo Dureghello
2020-07-06 4:55 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Angelo Dureghello @ 2020-07-02 11:15 UTC (permalink / raw)
To: Robin Gong, vkoul, dan.j.williams; +Cc: dmaengine, linux-kernel, linux-imx
Hi Robin,
29.06.2020, 10:53, "Robin Gong" <yibin.gong@nxp.com>:
> Correct EDMA_TCD_ATTR_DSIZE_32BYTE define since it's broken by the below:
> '0x0005 --> BIT(3) | BIT(0))'
>
> Fixes: 4d6d3a90e4ac ("dmaengine: fsl-edma: fix macros")
> Cc: stable@vger.kernel.org
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> ---
> drivers/dma/fsl-edma-common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/fsl-edma-common.h b/drivers/dma/fsl-edma-common.h
> index 67e4225..ec11697 100644
> --- a/drivers/dma/fsl-edma-common.h
> +++ b/drivers/dma/fsl-edma-common.h
> @@ -33,7 +33,7 @@
> #define EDMA_TCD_ATTR_DSIZE_16BIT BIT(0)
> #define EDMA_TCD_ATTR_DSIZE_32BIT BIT(1)
> #define EDMA_TCD_ATTR_DSIZE_64BIT (BIT(0) | BIT(1))
> -#define EDMA_TCD_ATTR_DSIZE_32BYTE (BIT(3) | BIT(0))
> +#define EDMA_TCD_ATTR_DSIZE_32BYTE (BIT(2) | BIT(0))
looks like i need some glasses. Thanks a lot for the fix.
I probably missed it since not using 16bytes transfers.
Tested-by: Angelo Dureghello <angelo@sysam.it>
Regards,
angelo
> #define EDMA_TCD_ATTR_SSIZE_8BIT 0
> #define EDMA_TCD_ATTR_SSIZE_16BIT (EDMA_TCD_ATTR_DSIZE_16BIT << 8)
> #define EDMA_TCD_ATTR_SSIZE_32BIT (EDMA_TCD_ATTR_DSIZE_32BIT << 8)
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] dmaengine: fsl-edma-common: correct DSIZE_32BYTE
2020-06-29 16:59 [PATCH v1] dmaengine: fsl-edma-common: correct DSIZE_32BYTE Robin Gong
2020-07-02 11:15 ` Angelo Dureghello
@ 2020-07-06 4:55 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2020-07-06 4:55 UTC (permalink / raw)
To: Robin Gong; +Cc: dan.j.williams, angelo, dmaengine, linux-kernel, linux-imx
On 30-06-20, 00:59, Robin Gong wrote:
> Correct EDMA_TCD_ATTR_DSIZE_32BYTE define since it's broken by the below:
> '0x0005 --> BIT(3) | BIT(0))'
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-06 4:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29 16:59 [PATCH v1] dmaengine: fsl-edma-common: correct DSIZE_32BYTE Robin Gong
2020-07-02 11:15 ` Angelo Dureghello
2020-07-06 4:55 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).