Re: [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding

Re: [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding

[Rohit Kumar]

On 5/16/2020 11:07 PM, Ajit Pandey wrote:
> On 5/14/2020 10:14 PM, Mark Brown wrote:
>> On Thu, May 14, 2020 at 10:08:12PM +0530, Ajit Pandey wrote:
>>> Done the required cleanups to update lpass-cpu binding with newer
>>> yaml formats.
>> Please do YAML conversions as the last thing in any patch series, there
>> is quite a big backlog of reviews of YAML conversions so they can slow
>> down the code development.  It's good to do them, just try to make sure
>> other patches don't depend on them.
>>
>> Please submit patches using subject lines reflecting the style for the
>> subsystem, this makes it easier for people to identify relevant patches.
>> Look at what existing commits in the area you're changing are doing and
>> make sure your subject lines visually resemble what they're doing.
>> There's no need to resubmit to fix this alone.
>
> Ok.. we'll do the yaml conversion as a separate patch chain so that it 
> won't block
>
> merging of this feature in ASoC core.

@Mark, I was planning to post v3 patchset series for this and keep yaml 
change as

last patch in the series as suggested. However, we have one update in 
the driver to

support another compatible string. If we keep Documentation change at 
the last, the

driver change will have checkpatch errors. Can you please suggest if 
should make

first Documentation change in text file itself before driver change and 
finally have a

patch to convert it to yaml at the end?


Thanks,

Rohit

-- 
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.

Re: [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

On Mon, Jul 06, 2020 at 04:59:39PM +0530, Rohit Kumar wrote:

> @Mark, I was planning to post v3 patchset series for this and keep yaml
> change as

My name is Mark.

> driver change will have checkpatch errors. Can you please suggest if should
> make

> first Documentation change in text file itself before driver change and
> finally have a

> patch to convert it to yaml at the end?

As ever make the YAML conversion the very last thing you do in your
series so it doesn't hold anything else up.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2 1/7] Documentation: device-tree: sound: Update lpass-cpu driver binding

[Ajit Pandey]

On 5/14/2020 10:14 PM, Mark Brown wrote:
> On Thu, May 14, 2020 at 10:08:12PM +0530, Ajit Pandey wrote:
>> Done the required cleanups to update lpass-cpu binding with newer
>> yaml formats.
> Please do YAML conversions as the last thing in any patch series, there
> is quite a big backlog of reviews of YAML conversions so they can slow
> down the code development.  It's good to do them, just try to make sure
> other patches don't depend on them.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

Ok.. we'll do the yaml conversion as a separate patch chain so that it 
won't block

merging of this feature in ASoC core.