From: Lee Jones <lee.jones@linaro.org>
To: gregkh@linuxfoundation.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>, Felipe Balbi <balbi@kernel.org>,
Bryan Wu <cooloney@kernel.org>
Subject: [PATCH 19/32] usb: gadget: function: u_uac1_legacy: Demote obvious misuse of kerneldoc to standard comment blocks
Date: Mon, 6 Jul 2020 14:33:28 +0100 [thread overview]
Message-ID: <20200706133341.476881-20-lee.jones@linaro.org> (raw)
In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org>
No attempt has been made to document any of the demoted functions here.
Fixes the following W=1 kernel build warning(s):
drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'i' not described in 'snd_interval_refine_set'
drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'val' not described in 'snd_interval_refine_set'
drivers/usb/gadget/function/u_uac1_legacy.c:93: warning: Function parameter or member 'snd' not described in 'playback_default_hw_params'
drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'card' not described in 'u_audio_playback'
drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'buf' not described in 'u_audio_playback'
drivers/usb/gadget/function/u_uac1_legacy.c:153: warning: Function parameter or member 'count' not described in 'u_audio_playback'
drivers/usb/gadget/function/u_uac1_legacy.c:197: warning: Function parameter or member 'card' not described in 'gaudio_open_snd_dev'
drivers/usb/gadget/function/u_uac1_legacy.c:257: warning: Function parameter or member 'gau' not described in 'gaudio_close_snd_dev'
drivers/usb/gadget/function/u_uac1_legacy.c:286: warning: Function parameter or member 'card' not described in 'gaudio_setup'
drivers/usb/gadget/function/u_uac1_legacy.c:303: warning: Function parameter or member 'the_card' not described in 'gaudio_cleanup'
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Bryan Wu <cooloney@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/usb/gadget/function/u_uac1_legacy.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/function/u_uac1_legacy.c b/drivers/usb/gadget/function/u_uac1_legacy.c
index 5393e5c37a4ba..60ae8b2d3f6a2 100644
--- a/drivers/usb/gadget/function/u_uac1_legacy.c
+++ b/drivers/usb/gadget/function/u_uac1_legacy.c
@@ -23,7 +23,7 @@
/*-------------------------------------------------------------------------*/
-/**
+/*
* Some ALSA internal helper functions
*/
static int snd_interval_refine_set(struct snd_interval *i, unsigned int val)
@@ -86,7 +86,7 @@ static int _snd_pcm_hw_param_set(struct snd_pcm_hw_params *params,
}
/*-------------------------------------------------------------------------*/
-/**
+/*
* Set default hardware params
*/
static int playback_default_hw_params(struct gaudio_snd_dev *snd)
@@ -146,7 +146,7 @@ static int playback_default_hw_params(struct gaudio_snd_dev *snd)
return 0;
}
-/**
+/*
* Playback audio buffer data by ALSA PCM device
*/
size_t u_audio_playback(struct gaudio *card, void *buf, size_t count)
@@ -189,7 +189,7 @@ int u_audio_get_playback_rate(struct gaudio *card)
return card->playback.rate;
}
-/**
+/*
* Open ALSA PCM and control device files
* Initial the PCM or control device
*/
@@ -250,7 +250,7 @@ static int gaudio_open_snd_dev(struct gaudio *card)
return 0;
}
-/**
+/*
* Close ALSA PCM and control device files
*/
static int gaudio_close_snd_dev(struct gaudio *gau)
@@ -275,7 +275,7 @@ static int gaudio_close_snd_dev(struct gaudio *gau)
return 0;
}
-/**
+/*
* gaudio_setup - setup ALSA interface and preparing for USB transfer
*
* This sets up PCM, mixer or MIDI ALSA devices fore USB gadget using.
@@ -294,7 +294,7 @@ int gaudio_setup(struct gaudio *card)
}
-/**
+/*
* gaudio_cleanup - remove ALSA device interface
*
* This is called to free all resources allocated by @gaudio_setup().
--
2.25.1
next prev parent reply other threads:[~2020-07-06 13:35 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 13:33 [PATCH 00/32] Fix the final bunch of W=1 issues in USB Lee Jones
2020-07-06 13:33 ` [PATCH 01/32] usb: misc: legousbtower: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-06 13:33 ` [PATCH 02/32] usb: chipidea: ci_hdrc_pci: Fix improper use of kerneldoc format Lee Jones
2020-07-06 13:33 ` [PATCH 03/32] usb: gadget: legacy: printer: Remove unused variable 'driver_desc' Lee Jones
2020-07-06 13:33 ` [PATCH 04/32] usb: gadget: udc: amd5536udc_pci: Remove unused variable 'mod_desc' Lee Jones
2020-07-06 13:33 ` [PATCH 05/32] usb: gadget: function: u_ether: Downgrade kerneldoc headers which to not make the mark Lee Jones
2020-07-06 13:33 ` [PATCH 06/32] usb: gadget: udc: pxa27x_udc: Fix a bunch of kerneldoc issues Lee Jones
2020-07-08 10:32 ` Robert Jarzmik
2020-07-06 13:33 ` [PATCH 07/32] usb: misc: legousbtower: Demote function header which is clearly not kerneldoc Lee Jones
2020-07-06 13:33 ` [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode_ops' Lee Jones
2020-07-06 14:00 ` Hans de Goede
2020-07-06 14:20 ` Lee Jones
2020-07-09 12:50 ` Hans de Goede
2020-07-09 13:04 ` Lee Jones
2020-07-14 12:01 ` Hans de Goede
2020-07-14 13:54 ` Lee Jones
2020-09-01 2:32 ` Badhri Jagan Sridharan
2020-09-01 7:20 ` Hans de Goede
2020-07-06 13:33 ` [PATCH 09/32] usb: gadget: udc: atmel_usba_udc: Remove set but unused variable 'pp' Lee Jones
2020-07-06 13:33 ` [PATCH 10/32] usb: gadget: legacy: nokia: Remove unused static variable 'product_nokia' Lee Jones
2020-07-06 13:33 ` [PATCH 11/32] usb: gadget: function: f_fs: Demote function header which is clearly not kerneldoc Lee Jones
2020-07-06 13:33 ` [PATCH 12/32] usb: gadget: udc: lpc32xx_udc: Staticify 2 local functions Lee Jones
2020-07-07 6:16 ` Vladimir Zapolskiy
2020-07-06 13:33 ` [PATCH 13/32] usb: host: r8a66597-hcd: Remove set, then over-written, but never used variable 'tmp' Lee Jones
2020-07-06 13:33 ` [PATCH 14/32] usb: gadget: udc: mv_udc_core: Remove unused static const variable 'driver_desc' Lee Jones
2020-07-06 13:33 ` [PATCH 15/32] usb: gadget: udc: pch_udc: Fix a plethora of function documentation related issues Lee Jones
2020-07-06 13:33 ` [PATCH 16/32] usb: host: imx21-hcd: Demote function header which is clearly not kerneldoc Lee Jones
2020-07-06 13:33 ` [PATCH 17/32] usb: host: ehci-fsl: Fix incorrectly named function argument Lee Jones
2020-07-06 13:33 ` [PATCH 18/32] usb: host: fotg210-hcd: Remove unused variable 'hcc_params' Lee Jones
2020-07-06 13:33 ` Lee Jones [this message]
2020-07-06 13:33 ` [PATCH 20/32] usb: host: bcma-hcd: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-06 13:33 ` [PATCH 21/32] usb: host: fotg210-hcd: " Lee Jones
2020-07-06 13:33 ` [PATCH 22/32] usb: gadget: udc: mv_u3d_core: Remove unused static const 'driver_desc' Lee Jones
2020-07-06 13:33 ` [PATCH 23/32] usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr' Lee Jones
2020-07-06 16:08 ` Jassi Brar
2020-07-06 13:33 ` [PATCH 24/32] usb: typec: ucsi: ucsi: Staticify and stop export of ucsi_init() Lee Jones
2020-07-06 13:33 ` [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret' Lee Jones
2020-07-06 16:56 ` Eric W. Biederman
2020-07-06 17:57 ` Lee Jones
2020-07-06 13:33 ` [PATCH 26/32] usb: early: xhci-dbc: Supply missing 'xhci-dbgp.h' headerfile Lee Jones
2020-07-06 13:50 ` Jann Horn
2020-07-06 13:33 ` [PATCH 27/32] usb: early: xhci-dbc: File headers are not good candidates for kerneldoc Lee Jones
2020-07-06 13:33 ` [PATCH 28/32] usb: host: ehci-platform: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Lee Jones
2020-07-06 13:33 ` [PATCH 29/32] usb: dwc3: dwc3-qcom: " Lee Jones
2020-07-06 13:33 ` [PATCH 30/32] usb: host: fhci-tds: Remove unused variables 'buf' and 'extra_data' Lee Jones
2020-07-06 13:33 ` [PATCH 31/32] usb: host: fhci-sched: Remove unused variable 'td' Lee Jones
2020-07-06 13:33 ` [PATCH 32/32] usb: host: xhci-plat: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706133341.476881-20-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=balbi@kernel.org \
--cc=cooloney@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).