From: Hans de Goede <hdegoede@redhat.com>
To: Lee Jones <lee.jones@linaro.org>, gregkh@linuxfoundation.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode_ops'
Date: Mon, 6 Jul 2020 16:00:56 +0200 [thread overview]
Message-ID: <ca14707c-7d40-07ac-da1d-ca27a2e93dcd@redhat.com> (raw)
In-Reply-To: <20200706133341.476881-9-lee.jones@linaro.org>
Hi,
On 7/6/20 3:33 PM, Lee Jones wrote:
> Looks as though a079973f462a3 ("usb: typec: tcpm: Remove tcpc_config
> configuration mechanism") pulled out the only use of 'tcpm_altmode_ops'
> last year. No need to keep it around.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/usb/typec/tcpm/tcpm.c:1551:39: warning: ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=]
> 1551 | static const struct typec_altmode_ops tcpm_altmode_ops = {
> | ^~~~~~~~~~~~~~~~
>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
This is necessary for adding Display port over Type-C support
on devices using the tcpm code, rather then firmware, to do
the Type-C alt-mode negotiation.
I have a local patch in my tree which adds support for this.
But Heikki did not like my approach, so that patch
(which needs the bits you are removing) never landed
upstream:
https://patchwork.kernel.org/patch/11199517/
Which is somewhat old now.
Heikki said he would look into an approach to this more to
his liking. Heikki an progress on this area?
Regards,
Hans
> ---
> drivers/usb/typec/tcpm/tcpm.c | 51 -----------------------------------
> 1 file changed, 51 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 82b19ebd7838e..d6913eb0ea54d 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -1503,57 +1503,6 @@ static int tcpm_validate_caps(struct tcpm_port *port, const u32 *pdo,
> return 0;
> }
>
> -static int tcpm_altmode_enter(struct typec_altmode *altmode, u32 *vdo)
> -{
> - struct tcpm_port *port = typec_altmode_get_drvdata(altmode);
> - u32 header;
> -
> - mutex_lock(&port->lock);
> - header = VDO(altmode->svid, vdo ? 2 : 1, CMD_ENTER_MODE);
> - header |= VDO_OPOS(altmode->mode);
> -
> - tcpm_queue_vdm(port, header, vdo, vdo ? 1 : 0);
> - mod_delayed_work(port->wq, &port->vdm_state_machine, 0);
> - mutex_unlock(&port->lock);
> -
> - return 0;
> -}
> -
> -static int tcpm_altmode_exit(struct typec_altmode *altmode)
> -{
> - struct tcpm_port *port = typec_altmode_get_drvdata(altmode);
> - u32 header;
> -
> - mutex_lock(&port->lock);
> - header = VDO(altmode->svid, 1, CMD_EXIT_MODE);
> - header |= VDO_OPOS(altmode->mode);
> -
> - tcpm_queue_vdm(port, header, NULL, 0);
> - mod_delayed_work(port->wq, &port->vdm_state_machine, 0);
> - mutex_unlock(&port->lock);
> -
> - return 0;
> -}
> -
> -static int tcpm_altmode_vdm(struct typec_altmode *altmode,
> - u32 header, const u32 *data, int count)
> -{
> - struct tcpm_port *port = typec_altmode_get_drvdata(altmode);
> -
> - mutex_lock(&port->lock);
> - tcpm_queue_vdm(port, header, data, count - 1);
> - mod_delayed_work(port->wq, &port->vdm_state_machine, 0);
> - mutex_unlock(&port->lock);
> -
> - return 0;
> -}
> -
> -static const struct typec_altmode_ops tcpm_altmode_ops = {
> - .enter = tcpm_altmode_enter,
> - .exit = tcpm_altmode_exit,
> - .vdm = tcpm_altmode_vdm,
> -};
> -
> /*
> * PD (data, control) command handling functions
> */
>
next prev parent reply other threads:[~2020-07-06 14:01 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 13:33 [PATCH 00/32] Fix the final bunch of W=1 issues in USB Lee Jones
2020-07-06 13:33 ` [PATCH 01/32] usb: misc: legousbtower: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-06 13:33 ` [PATCH 02/32] usb: chipidea: ci_hdrc_pci: Fix improper use of kerneldoc format Lee Jones
2020-07-06 13:33 ` [PATCH 03/32] usb: gadget: legacy: printer: Remove unused variable 'driver_desc' Lee Jones
2020-07-06 13:33 ` [PATCH 04/32] usb: gadget: udc: amd5536udc_pci: Remove unused variable 'mod_desc' Lee Jones
2020-07-06 13:33 ` [PATCH 05/32] usb: gadget: function: u_ether: Downgrade kerneldoc headers which to not make the mark Lee Jones
2020-07-06 13:33 ` [PATCH 06/32] usb: gadget: udc: pxa27x_udc: Fix a bunch of kerneldoc issues Lee Jones
2020-07-08 10:32 ` Robert Jarzmik
2020-07-06 13:33 ` [PATCH 07/32] usb: misc: legousbtower: Demote function header which is clearly not kerneldoc Lee Jones
2020-07-06 13:33 ` [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode_ops' Lee Jones
2020-07-06 14:00 ` Hans de Goede [this message]
2020-07-06 14:20 ` Lee Jones
2020-07-09 12:50 ` Hans de Goede
2020-07-09 13:04 ` Lee Jones
2020-07-14 12:01 ` Hans de Goede
2020-07-14 13:54 ` Lee Jones
2020-09-01 2:32 ` Badhri Jagan Sridharan
2020-09-01 7:20 ` Hans de Goede
2020-07-06 13:33 ` [PATCH 09/32] usb: gadget: udc: atmel_usba_udc: Remove set but unused variable 'pp' Lee Jones
2020-07-06 13:33 ` [PATCH 10/32] usb: gadget: legacy: nokia: Remove unused static variable 'product_nokia' Lee Jones
2020-07-06 13:33 ` [PATCH 11/32] usb: gadget: function: f_fs: Demote function header which is clearly not kerneldoc Lee Jones
2020-07-06 13:33 ` [PATCH 12/32] usb: gadget: udc: lpc32xx_udc: Staticify 2 local functions Lee Jones
2020-07-07 6:16 ` Vladimir Zapolskiy
2020-07-06 13:33 ` [PATCH 13/32] usb: host: r8a66597-hcd: Remove set, then over-written, but never used variable 'tmp' Lee Jones
2020-07-06 13:33 ` [PATCH 14/32] usb: gadget: udc: mv_udc_core: Remove unused static const variable 'driver_desc' Lee Jones
2020-07-06 13:33 ` [PATCH 15/32] usb: gadget: udc: pch_udc: Fix a plethora of function documentation related issues Lee Jones
2020-07-06 13:33 ` [PATCH 16/32] usb: host: imx21-hcd: Demote function header which is clearly not kerneldoc Lee Jones
2020-07-06 13:33 ` [PATCH 17/32] usb: host: ehci-fsl: Fix incorrectly named function argument Lee Jones
2020-07-06 13:33 ` [PATCH 18/32] usb: host: fotg210-hcd: Remove unused variable 'hcc_params' Lee Jones
2020-07-06 13:33 ` [PATCH 19/32] usb: gadget: function: u_uac1_legacy: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-06 13:33 ` [PATCH 20/32] usb: host: bcma-hcd: " Lee Jones
2020-07-06 13:33 ` [PATCH 21/32] usb: host: fotg210-hcd: " Lee Jones
2020-07-06 13:33 ` [PATCH 22/32] usb: gadget: udc: mv_u3d_core: Remove unused static const 'driver_desc' Lee Jones
2020-07-06 13:33 ` [PATCH 23/32] usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr' Lee Jones
2020-07-06 16:08 ` Jassi Brar
2020-07-06 13:33 ` [PATCH 24/32] usb: typec: ucsi: ucsi: Staticify and stop export of ucsi_init() Lee Jones
2020-07-06 13:33 ` [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret' Lee Jones
2020-07-06 16:56 ` Eric W. Biederman
2020-07-06 17:57 ` Lee Jones
2020-07-06 13:33 ` [PATCH 26/32] usb: early: xhci-dbc: Supply missing 'xhci-dbgp.h' headerfile Lee Jones
2020-07-06 13:50 ` Jann Horn
2020-07-06 13:33 ` [PATCH 27/32] usb: early: xhci-dbc: File headers are not good candidates for kerneldoc Lee Jones
2020-07-06 13:33 ` [PATCH 28/32] usb: host: ehci-platform: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Lee Jones
2020-07-06 13:33 ` [PATCH 29/32] usb: dwc3: dwc3-qcom: " Lee Jones
2020-07-06 13:33 ` [PATCH 30/32] usb: host: fhci-tds: Remove unused variables 'buf' and 'extra_data' Lee Jones
2020-07-06 13:33 ` [PATCH 31/32] usb: host: fhci-sched: Remove unused variable 'td' Lee Jones
2020-07-06 13:33 ` [PATCH 32/32] usb: host: xhci-plat: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca14707c-7d40-07ac-da1d-ca27a2e93dcd@redhat.com \
--to=hdegoede@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).